graphql-engine/server/src-test/Hasura/Base/Error/TestInstances.hs

{-# OPTIONS_GHC -Wno-orphans #-}

module Hasura.Base.Error.TestInstances () where

import Data.Text qualified as Text
import Hasura.Base.Error
import Hasura.Prelude

-- Orphan instance so that we can write assertions over 'Either QErr a'.
instance Show QErr where
  show = Text.unpack . showQErr
server: Remove the Show instance from QErr and anything that touches it. We only use these `Show` instances in error messages (where we call `show` explicitly anyway) and test cases (in which Hspec requires `Show a` for any `a` in an assertion). This removes the instance in favor of a custom `showQErr` function (which serializes the error to JSON). It is then used in certain error message production which previously called `show` on a `QErr`. There are two places where we serialize a QErr and then construct a new QErr from the resulting string. Instead, we modify the existing QErr to add extra information. An orphan `Show QErr` instance is retained for tests so that we can have nice test failure messages. This is preparation for future changes in which the error message within `QErr` will not be exposed directly, and therefore will not have a `Show` instance. That said, it feels like a sensible kind of cleanup anyway. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4897 GitOrigin-RevId: 8f79f7a356f0aea571156f39aefac242bf751f3a 2022-07-01 14:47:20 +03:00			`{-# OPTIONS_GHC -Wno-orphans #-}`

			`module Hasura.Base.Error.TestInstances () where`

			`import Data.Text qualified as Text`
			`import Hasura.Base.Error`
			`import Hasura.Prelude`

server: Remove `QErr` and `Code` dependencies from the schema parsers. In the process of decoupling the schema parsers from the GraphQL Engine, we need to remove dependencies on `Hasura.Base.Error`. First of all, we have avoided using `QErr` in schema parsers code, instead returning a more appropriate data type which can be converted to a `Hasura.Base.Error.QErr` later. Secondly, we create a new `ParseErrorCode` type to represent parse failure types, which are then converted to a `Hasura.Base.Error.Code` later. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5181 GitOrigin-RevId: 8655e26adb1e7d5e3d552c77a8a403f987b53467 2022-07-27 15:24:50 +03:00			`-- Orphan instance so that we can write assertions over 'Either QErr a'.`
server: Remove the Show instance from QErr and anything that touches it. We only use these `Show` instances in error messages (where we call `show` explicitly anyway) and test cases (in which Hspec requires `Show a` for any `a` in an assertion). This removes the instance in favor of a custom `showQErr` function (which serializes the error to JSON). It is then used in certain error message production which previously called `show` on a `QErr`. There are two places where we serialize a QErr and then construct a new QErr from the resulting string. Instead, we modify the existing QErr to add extra information. An orphan `Show QErr` instance is retained for tests so that we can have nice test failure messages. This is preparation for future changes in which the error message within `QErr` will not be exposed directly, and therefore will not have a `Show` instance. That said, it feels like a sensible kind of cleanup anyway. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4897 GitOrigin-RevId: 8f79f7a356f0aea571156f39aefac242bf751f3a 2022-07-01 14:47:20 +03:00			`instance Show QErr where`
			`show = Text.unpack . showQErr`