2021-07-07 04:43:42 +03:00
|
|
|
{-# LANGUAGE ViewPatterns #-}
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
-- | The RQL metadata query ('/v1/metadata')
|
2021-11-04 19:08:33 +03:00
|
|
|
module Hasura.Server.API.Metadata
|
|
|
|
( RQLMetadata,
|
|
|
|
RQLMetadataV1 (..),
|
|
|
|
runMetadataQuery,
|
|
|
|
)
|
|
|
|
where
|
2021-01-07 12:04:22 +03:00
|
|
|
|
2022-03-11 02:22:54 +03:00
|
|
|
import Control.Lens (_Just)
|
2021-09-24 01:56:37 +03:00
|
|
|
import Control.Monad.Trans.Control (MonadBaseControl)
|
|
|
|
import Data.Aeson
|
|
|
|
import Data.Aeson.Casing
|
|
|
|
import Data.Aeson.Types qualified as A
|
|
|
|
import Data.Environment qualified as Env
|
|
|
|
import Data.Has (Has)
|
|
|
|
import Data.Text qualified as T
|
|
|
|
import Data.Text.Extended qualified as T
|
2022-08-19 00:56:47 +03:00
|
|
|
import GHC.Generics.Extended (constrName)
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.Base.Error
|
|
|
|
import Hasura.EncJSON
|
|
|
|
import Hasura.Logging qualified as L
|
|
|
|
import Hasura.Metadata.Class
|
2022-03-11 02:22:54 +03:00
|
|
|
import Hasura.Prelude hiding (first)
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.RQL.DDL.Action
|
|
|
|
import Hasura.RQL.DDL.ApiLimit
|
|
|
|
import Hasura.RQL.DDL.ComputedField
|
|
|
|
import Hasura.RQL.DDL.CustomTypes
|
2022-08-18 01:13:32 +03:00
|
|
|
import Hasura.RQL.DDL.DataConnector
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.RQL.DDL.Endpoint
|
|
|
|
import Hasura.RQL.DDL.EventTrigger
|
|
|
|
import Hasura.RQL.DDL.GraphqlSchemaIntrospection
|
|
|
|
import Hasura.RQL.DDL.InheritedRoles
|
|
|
|
import Hasura.RQL.DDL.Metadata
|
|
|
|
import Hasura.RQL.DDL.Network
|
|
|
|
import Hasura.RQL.DDL.Permission
|
|
|
|
import Hasura.RQL.DDL.QueryCollection
|
|
|
|
import Hasura.RQL.DDL.QueryTags
|
|
|
|
import Hasura.RQL.DDL.Relationship
|
|
|
|
import Hasura.RQL.DDL.Relationship.Rename
|
|
|
|
import Hasura.RQL.DDL.RemoteRelationship
|
|
|
|
import Hasura.RQL.DDL.RemoteSchema
|
|
|
|
import Hasura.RQL.DDL.ScheduledTrigger
|
|
|
|
import Hasura.RQL.DDL.Schema
|
|
|
|
import Hasura.RQL.DDL.Schema.Source
|
2022-08-18 01:13:32 +03:00
|
|
|
import Hasura.RQL.DDL.SourceKinds
|
2022-03-11 02:22:54 +03:00
|
|
|
import Hasura.RQL.DDL.Webhook.Transform.Validation
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.RQL.Types.Action
|
|
|
|
import Hasura.RQL.Types.Allowlist
|
|
|
|
import Hasura.RQL.Types.ApiLimit
|
|
|
|
import Hasura.RQL.Types.Common
|
|
|
|
import Hasura.RQL.Types.CustomTypes
|
2022-03-13 10:40:06 +03:00
|
|
|
import Hasura.RQL.Types.Endpoint
|
2022-09-09 11:26:44 +03:00
|
|
|
import Hasura.RQL.Types.EventTrigger
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.RQL.Types.Eventing.Backend
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.RQL.Types.GraphqlSchemaIntrospection
|
|
|
|
import Hasura.RQL.Types.Metadata
|
|
|
|
import Hasura.RQL.Types.Metadata.Backend
|
|
|
|
import Hasura.RQL.Types.Network
|
|
|
|
import Hasura.RQL.Types.Permission
|
|
|
|
import Hasura.RQL.Types.QueryCollection
|
|
|
|
import Hasura.RQL.Types.RemoteSchema
|
|
|
|
import Hasura.RQL.Types.Roles
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.RQL.Types.Run
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.RQL.Types.ScheduledTrigger
|
|
|
|
import Hasura.RQL.Types.SchemaCache
|
|
|
|
import Hasura.RQL.Types.SchemaCache.Build
|
|
|
|
import Hasura.RQL.Types.Source
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.SQL.AnyBackend
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.SQL.Backend
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.Server.API.Backend
|
|
|
|
import Hasura.Server.API.Instances ()
|
2022-04-22 17:50:01 +03:00
|
|
|
import Hasura.Server.Types
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.Server.Utils (APIVersion (..))
|
|
|
|
import Hasura.Session
|
|
|
|
import Hasura.Tracing qualified as Tracing
|
|
|
|
import Network.HTTP.Client.Manager qualified as HTTP
|
2021-01-07 12:04:22 +03:00
|
|
|
|
2021-02-16 11:08:19 +03:00
|
|
|
data RQLMetadataV1
|
2021-09-24 01:56:37 +03:00
|
|
|
= -- Sources
|
|
|
|
RMAddSource !(AnyBackend AddSource)
|
2021-07-07 04:43:42 +03:00
|
|
|
| RMDropSource DropSource
|
|
|
|
| RMRenameSource !RenameSource
|
2022-06-22 10:06:19 +03:00
|
|
|
| RMUpdateSource !(AnyBackend UpdateSource)
|
2022-08-30 02:51:34 +03:00
|
|
|
| RMListSourceKinds !ListSourceKinds
|
2022-09-02 20:50:09 +03:00
|
|
|
| RMGetSourceKindCapabilities !GetSourceKindCapabilities
|
2022-08-30 02:51:34 +03:00
|
|
|
| RMGetSourceTables !GetSourceTables
|
|
|
|
| RMGetTableInfo !GetTableInfo
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Tables
|
|
|
|
RMTrackTable !(AnyBackend TrackTableV2)
|
|
|
|
| RMUntrackTable !(AnyBackend UntrackTable)
|
2021-07-07 04:43:42 +03:00
|
|
|
| RMSetTableCustomization !(AnyBackend SetTableCustomization)
|
2022-08-04 12:35:58 +03:00
|
|
|
| RMSetApolloFederationConfig (AnyBackend SetApolloFederationConfig)
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Tables (PG-specific)
|
|
|
|
RMPgSetTableIsEnum !SetTableIsEnum
|
|
|
|
| -- Tables permissions
|
|
|
|
RMCreateInsertPermission !(AnyBackend (CreatePerm InsPerm))
|
2021-07-07 04:43:42 +03:00
|
|
|
| RMCreateSelectPermission !(AnyBackend (CreatePerm SelPerm))
|
|
|
|
| RMCreateUpdatePermission !(AnyBackend (CreatePerm UpdPerm))
|
|
|
|
| RMCreateDeletePermission !(AnyBackend (CreatePerm DelPerm))
|
2022-04-06 15:47:35 +03:00
|
|
|
| RMDropInsertPermission !(AnyBackend DropPerm)
|
|
|
|
| RMDropSelectPermission !(AnyBackend DropPerm)
|
|
|
|
| RMDropUpdatePermission !(AnyBackend DropPerm)
|
|
|
|
| RMDropDeletePermission !(AnyBackend DropPerm)
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMSetPermissionComment !(AnyBackend SetPermComment)
|
|
|
|
| -- Tables relationships
|
|
|
|
RMCreateObjectRelationship !(AnyBackend CreateObjRel)
|
|
|
|
| RMCreateArrayRelationship !(AnyBackend CreateArrRel)
|
|
|
|
| RMDropRelationship !(AnyBackend DropRel)
|
|
|
|
| RMSetRelationshipComment !(AnyBackend SetRelComment)
|
|
|
|
| RMRenameRelationship !(AnyBackend RenameRel)
|
|
|
|
| -- Tables remote relationships
|
2021-12-01 07:53:34 +03:00
|
|
|
RMCreateRemoteRelationship !(AnyBackend CreateFromSourceRelationship)
|
|
|
|
| RMUpdateRemoteRelationship !(AnyBackend CreateFromSourceRelationship)
|
Fix several issues with remote relationships.
## Remaining Work
- [x] changelog entry
- [x] more tests: `<backend>_delete_remote_relationship` is definitely untested
- [x] negative tests: we probably want to assert that there are some APIs we DON'T support
- [x] update the console to use the new API, if necessary
- [x] ~~adding the corresponding documentation for the API for other backends (only `pg_` was added here)~~
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3170
- [x] ~~deciding which backends should support this API~~
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3170
- [x] ~~deciding what to do about potentially overlapping schematic representations~~
- ~~cf. https://github.com/hasura/graphql-engine-mono/pull/3157#issuecomment-995307624~~
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3171
- [x] ~~add more descriptive versioning information to some of the types that are changing in this PR~~
- cf. https://github.com/hasura/graphql-engine-mono/pull/3157#discussion_r769830920
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3172
## Description
This PR fixes several important issues wrt. the remote relationship API.
- it fixes a regression introduced by [#3124](https://github.com/hasura/graphql-engine-mono/pull/3124), which prevented `<backend>_create_remote_relationship` from accepting the old argument format (break of backwards compatibility, broke the console)
- it removes the command `create_remote_relationship` added to the v1/metadata API as a work-around as part of [#3124](https://github.com/hasura/graphql-engine-mono/pull/3124)
- it reverts the subsequent fix in the console: [#3149](https://github.com/hasura/graphql-engine-mono/pull/3149)
Furthermore, this PR also addresses two other issues:
- THE DOCUMENTATION OF THE METADATA API WAS WRONG, and documented `create_remote_relationship` instead of `<backend>_create_remote_relationship`: this PR fixes this by adding `pg_` everywhere, but does not attempt to add the corresponding documentation for other backends, partly because:
- `<backend>_delete_remote_relationship` WAS BROKEN ON NON-POSTGRES BACKENDS; it always expected an argument parameterized by Postgres.
As of main, the `<backend>_(create|update|delete)_remote_relationship` commands are supported on Postgres, Citus, BigQuery, but **NOT MSSQL**. I do not know if this is intentional or not, if it even should be publicized or not, and as a result this PR doesn't change this.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3157
Co-authored-by: jkachmar <8461423+jkachmar@users.noreply.github.com>
GitOrigin-RevId: 37e2f41522a9229a11c595574c3f4984317d652a
2021-12-16 23:28:08 +03:00
|
|
|
| RMDeleteRemoteRelationship !(AnyBackend DeleteFromSourceRelationship)
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Functions
|
|
|
|
RMTrackFunction !(AnyBackend TrackFunctionV2)
|
2021-07-07 04:43:42 +03:00
|
|
|
| RMUntrackFunction !(AnyBackend UnTrackFunction)
|
2021-10-07 16:02:19 +03:00
|
|
|
| RMSetFunctionCustomization (AnyBackend SetFunctionCustomization)
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Functions permissions
|
|
|
|
RMCreateFunctionPermission !(AnyBackend FunctionPermissionArgument)
|
|
|
|
| RMDropFunctionPermission !(AnyBackend FunctionPermissionArgument)
|
2022-05-04 17:52:29 +03:00
|
|
|
| -- Computed fields
|
|
|
|
RMAddComputedField !(AnyBackend AddComputedField)
|
|
|
|
| RMDropComputedField !(AnyBackend DropComputedField)
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Tables event triggers
|
2022-03-11 02:22:54 +03:00
|
|
|
RMCreateEventTrigger !(AnyBackend (Unvalidated1 CreateEventTriggerQuery))
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMDeleteEventTrigger !(AnyBackend DeleteEventTriggerQuery)
|
|
|
|
| RMRedeliverEvent !(AnyBackend RedeliverEventQuery)
|
|
|
|
| RMInvokeEventTrigger !(AnyBackend InvokeEventTriggerQuery)
|
2022-09-09 11:26:44 +03:00
|
|
|
| RMCleanupEventTriggerLog !TriggerLogCleanupConfig
|
2022-09-13 11:33:44 +03:00
|
|
|
| RMStartEventTriggerCleanup !TriggerLogCleanupToggleConfig
|
|
|
|
| RMPauseEventTriggerCleanup !TriggerLogCleanupToggleConfig
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Remote schemas
|
|
|
|
RMAddRemoteSchema !AddRemoteSchemaQuery
|
|
|
|
| RMUpdateRemoteSchema !AddRemoteSchemaQuery
|
|
|
|
| RMRemoveRemoteSchema !RemoteSchemaNameQuery
|
|
|
|
| RMReloadRemoteSchema !RemoteSchemaNameQuery
|
2021-01-07 12:04:22 +03:00
|
|
|
| RMIntrospectRemoteSchema !RemoteSchemaNameQuery
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Remote schemas permissions
|
|
|
|
RMAddRemoteSchemaPermissions !AddRemoteSchemaPermission
|
2021-01-18 13:38:34 +03:00
|
|
|
| RMDropRemoteSchemaPermissions !DropRemoteSchemaPermissions
|
2022-03-17 23:53:56 +03:00
|
|
|
| -- Remote Schema remote relationships
|
|
|
|
RMCreateRemoteSchemaRemoteRelationship CreateRemoteSchemaRemoteRelationship
|
|
|
|
| RMUpdateRemoteSchemaRemoteRelationship CreateRemoteSchemaRemoteRelationship
|
|
|
|
| RMDeleteRemoteSchemaRemoteRelationship DeleteRemoteSchemaRemoteRelationship
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Scheduled triggers
|
2022-03-11 02:22:54 +03:00
|
|
|
RMCreateCronTrigger !(Unvalidated CreateCronTrigger)
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMDeleteCronTrigger !ScheduledTriggerName
|
2021-01-07 12:04:22 +03:00
|
|
|
| RMCreateScheduledEvent !CreateScheduledEvent
|
|
|
|
| RMDeleteScheduledEvent !DeleteScheduledEvent
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMGetScheduledEvents !GetScheduledEvents
|
|
|
|
| RMGetEventInvocations !GetEventInvocations
|
2022-01-27 09:43:39 +03:00
|
|
|
| RMGetCronTriggers
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Actions
|
2022-03-11 02:22:54 +03:00
|
|
|
RMCreateAction !(Unvalidated CreateAction)
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMDropAction !DropAction
|
2022-03-11 02:22:54 +03:00
|
|
|
| RMUpdateAction !(Unvalidated UpdateAction)
|
2021-01-07 12:04:22 +03:00
|
|
|
| RMCreateActionPermission !CreateActionPermission
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMDropActionPermission !DropActionPermission
|
|
|
|
| -- Query collections, allow list related
|
|
|
|
RMCreateQueryCollection !CreateCollection
|
2022-08-19 16:36:02 +03:00
|
|
|
| RMRenameQueryCollection !RenameCollection
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMDropQueryCollection !DropCollection
|
|
|
|
| RMAddQueryToCollection !AddQueryToCollection
|
|
|
|
| RMDropQueryFromCollection !DropQueryFromCollection
|
2022-02-08 19:53:30 +03:00
|
|
|
| RMAddCollectionToAllowlist !AllowlistEntry
|
|
|
|
| RMDropCollectionFromAllowlist !DropCollectionFromAllowlist
|
|
|
|
| RMUpdateScopeOfCollectionInAllowlist !UpdateScopeOfCollectionInAllowlist
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Rest endpoints
|
|
|
|
RMCreateRestEndpoint !CreateEndpoint
|
|
|
|
| RMDropRestEndpoint !DropEndpoint
|
2022-08-18 01:13:32 +03:00
|
|
|
| -- GraphQL Data Connectors
|
|
|
|
RMDCAddAgent !DCAddAgent
|
|
|
|
| RMDCDeleteAgent !DCDeleteAgent
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Custom types
|
|
|
|
RMSetCustomTypes !CustomTypes
|
|
|
|
| -- Api limits
|
|
|
|
RMSetApiLimits !ApiLimit
|
2021-02-11 20:54:25 +03:00
|
|
|
| RMRemoveApiLimits
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Metrics config
|
|
|
|
RMSetMetricsConfig !MetricsConfig
|
2021-02-11 20:54:25 +03:00
|
|
|
| RMRemoveMetricsConfig
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Inherited roles
|
|
|
|
RMAddInheritedRole !InheritedRole
|
[Preview] Inherited roles for postgres read queries
fixes #3868
docker image - `hasura/graphql-engine:inherited-roles-preview-48b73a2de`
Note:
To be able to use the inherited roles feature, the graphql-engine should be started with the env variable `HASURA_GRAPHQL_EXPERIMENTAL_FEATURES` set to `inherited_roles`.
Introduction
------------
This PR implements the idea of multiple roles as presented in this [paper](https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/FGALanguageICDE07.pdf). The multiple roles feature in this PR can be used via inherited roles. An inherited role is a role which can be created by combining multiple singular roles. For example, if there are two roles `author` and `editor` configured in the graphql-engine, then we can create a inherited role with the name of `combined_author_editor` role which will combine the select permissions of the `author` and `editor` roles and then make GraphQL queries using the `combined_author_editor`.
How are select permissions of different roles are combined?
------------------------------------------------------------
A select permission includes 5 things:
1. Columns accessible to the role
2. Row selection filter
3. Limit
4. Allow aggregation
5. Scalar computed fields accessible to the role
Suppose there are two roles, `role1` gives access to the `address` column with row filter `P1` and `role2` gives access to both the `address` and the `phone` column with row filter `P2` and we create a new role `combined_roles` which combines `role1` and `role2`.
Let's say the following GraphQL query is queried with the `combined_roles` role.
```graphql
query {
employees {
address
phone
}
}
```
This will translate to the following SQL query:
```sql
select
(case when (P1 or P2) then address else null end) as address,
(case when P2 then phone else null end) as phone
from employee
where (P1 or P2)
```
The other parameters of the select permission will be combined in the following manner:
1. Limit - Minimum of the limits will be the limit of the inherited role
2. Allow aggregations - If any of the role allows aggregation, then the inherited role will allow aggregation
3. Scalar computed fields - same as table column fields, as in the above example
APIs for inherited roles:
----------------------
1. `add_inherited_role`
`add_inherited_role` is the [metadata API](https://hasura.io/docs/1.0/graphql/core/api-reference/index.html#schema-metadata-api) to create a new inherited role. It accepts two arguments
`role_name`: the name of the inherited role to be added (String)
`role_set`: list of roles that need to be combined (Array of Strings)
Example:
```json
{
"type": "add_inherited_role",
"args": {
"role_name":"combined_user",
"role_set":[
"user",
"user1"
]
}
}
```
After adding the inherited role, the inherited role can be used like single roles like earlier
Note:
An inherited role can only be created with non-inherited/singular roles.
2. `drop_inherited_role`
The `drop_inherited_role` API accepts the name of the inherited role and drops it from the metadata. It accepts a single argument:
`role_name`: name of the inherited role to be dropped
Example:
```json
{
"type": "drop_inherited_role",
"args": {
"role_name":"combined_user"
}
}
```
Metadata
---------
The derived roles metadata will be included under the `experimental_features` key while exporting the metadata.
```json
{
"experimental_features": {
"derived_roles": [
{
"role_name": "manager_is_employee_too",
"role_set": [
"employee",
"manager"
]
}
]
}
}
```
Scope
------
Only postgres queries and subscriptions are supported in this PR.
Important points:
-----------------
1. All columns exposed to an inherited role will be marked as `nullable`, this is done so that cell value nullification can be done.
TODOs
-------
- [ ] Tests
- [ ] Test a GraphQL query running with a inherited role without enabling inherited roles in experimental features
- [] Tests for aggregate queries, limit, computed fields, functions, subscriptions (?)
- [ ] Introspection test with a inherited role (nullability changes in a inherited role)
- [ ] Docs
- [ ] Changelog
Co-authored-by: Vamshi Surabhi <6562944+0x777@users.noreply.github.com>
GitOrigin-RevId: 3b8ee1e11f5ceca80fe294f8c074d42fbccfec63
2021-03-08 14:14:13 +03:00
|
|
|
| RMDropInheritedRole !DropInheritedRole
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Metadata management
|
|
|
|
RMReplaceMetadata !ReplaceMetadata
|
|
|
|
| RMExportMetadata !ExportMetadata
|
|
|
|
| RMClearMetadata !ClearMetadata
|
|
|
|
| RMReloadMetadata !ReloadMetadata
|
|
|
|
| RMGetInconsistentMetadata !GetInconsistentMetadata
|
2021-07-07 04:43:42 +03:00
|
|
|
| RMDropInconsistentMetadata !DropInconsistentMetadata
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Introspection options
|
|
|
|
RMSetGraphqlSchemaIntrospectionOptions !SetGraphqlIntrospectionOptions
|
|
|
|
| -- Network
|
|
|
|
RMAddHostToTLSAllowlist !AddHostToTLSAllowlist
|
2021-08-24 10:36:32 +03:00
|
|
|
| RMDropHostFromTLSAllowlist !DropHostFromTLSAllowlist
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- QueryTags
|
|
|
|
RMSetQueryTagsConfig !SetQueryTagsConfig
|
|
|
|
| -- Debug
|
|
|
|
RMDumpInternalState !DumpInternalState
|
|
|
|
| RMGetCatalogState !GetCatalogState
|
|
|
|
| RMSetCatalogState !SetCatalogState
|
2022-03-11 02:22:54 +03:00
|
|
|
| RMTestWebhookTransform !(Unvalidated TestWebhookTransform)
|
2021-09-24 01:56:37 +03:00
|
|
|
| -- Bulk metadata queries
|
|
|
|
RMBulk [RQLMetadataRequest]
|
2022-08-19 00:56:47 +03:00
|
|
|
deriving (Generic)
|
|
|
|
|
|
|
|
-- NOTE! If you add a new request type here that is read-only, make sure to
|
|
|
|
-- update queryModifiesMetadata
|
2021-01-07 12:04:22 +03:00
|
|
|
|
2021-07-07 04:43:42 +03:00
|
|
|
instance FromJSON RQLMetadataV1 where
|
2021-09-24 01:56:37 +03:00
|
|
|
parseJSON = withObject "RQLMetadataV1" \o -> do
|
2021-07-07 04:43:42 +03:00
|
|
|
queryType <- o .: "type"
|
2021-09-24 01:56:37 +03:00
|
|
|
let args :: forall a. FromJSON a => A.Parser a
|
|
|
|
args = o .: "args"
|
2021-07-07 04:43:42 +03:00
|
|
|
case queryType of
|
|
|
|
-- backend agnostic
|
2021-09-24 01:56:37 +03:00
|
|
|
"rename_source" -> RMRenameSource <$> args
|
|
|
|
"add_remote_schema" -> RMAddRemoteSchema <$> args
|
|
|
|
"update_remote_schema" -> RMUpdateRemoteSchema <$> args
|
|
|
|
"remove_remote_schema" -> RMRemoveRemoteSchema <$> args
|
|
|
|
"reload_remote_schema" -> RMReloadRemoteSchema <$> args
|
|
|
|
"introspect_remote_schema" -> RMIntrospectRemoteSchema <$> args
|
|
|
|
"add_remote_schema_permissions" -> RMAddRemoteSchemaPermissions <$> args
|
|
|
|
"drop_remote_schema_permissions" -> RMDropRemoteSchemaPermissions <$> args
|
2022-03-17 23:53:56 +03:00
|
|
|
"create_remote_schema_remote_relationship" -> RMCreateRemoteSchemaRemoteRelationship <$> args
|
|
|
|
"update_remote_schema_remote_relationship" -> RMUpdateRemoteSchemaRemoteRelationship <$> args
|
|
|
|
"delete_remote_schema_remote_relationship" -> RMDeleteRemoteSchemaRemoteRelationship <$> args
|
2022-09-09 11:26:44 +03:00
|
|
|
"cleanup_event_trigger_logs" -> RMCleanupEventTriggerLog <$> args
|
2022-09-13 11:33:44 +03:00
|
|
|
"start_event_trigger_cleanups" -> RMStartEventTriggerCleanup <$> args
|
|
|
|
"pause_event_trigger_cleanups" -> RMPauseEventTriggerCleanup <$> args
|
2021-09-24 01:56:37 +03:00
|
|
|
"create_cron_trigger" -> RMCreateCronTrigger <$> args
|
|
|
|
"delete_cron_trigger" -> RMDeleteCronTrigger <$> args
|
|
|
|
"create_scheduled_event" -> RMCreateScheduledEvent <$> args
|
|
|
|
"delete_scheduled_event" -> RMDeleteScheduledEvent <$> args
|
|
|
|
"get_scheduled_events" -> RMGetScheduledEvents <$> args
|
|
|
|
"get_event_invocations" -> RMGetEventInvocations <$> args
|
2022-01-27 09:43:39 +03:00
|
|
|
"get_cron_triggers" -> pure RMGetCronTriggers
|
2021-09-24 01:56:37 +03:00
|
|
|
"create_action" -> RMCreateAction <$> args
|
|
|
|
"drop_action" -> RMDropAction <$> args
|
|
|
|
"update_action" -> RMUpdateAction <$> args
|
|
|
|
"create_action_permission" -> RMCreateActionPermission <$> args
|
|
|
|
"drop_action_permission" -> RMDropActionPermission <$> args
|
|
|
|
"create_query_collection" -> RMCreateQueryCollection <$> args
|
2022-08-19 16:36:02 +03:00
|
|
|
"rename_query_collection" -> RMRenameQueryCollection <$> args
|
2021-09-24 01:56:37 +03:00
|
|
|
"drop_query_collection" -> RMDropQueryCollection <$> args
|
|
|
|
"add_query_to_collection" -> RMAddQueryToCollection <$> args
|
|
|
|
"drop_query_from_collection" -> RMDropQueryFromCollection <$> args
|
|
|
|
"add_collection_to_allowlist" -> RMAddCollectionToAllowlist <$> args
|
|
|
|
"drop_collection_from_allowlist" -> RMDropCollectionFromAllowlist <$> args
|
2022-02-08 19:53:30 +03:00
|
|
|
"update_scope_of_collection_in_allowlist" -> RMUpdateScopeOfCollectionInAllowlist <$> args
|
2021-09-24 01:56:37 +03:00
|
|
|
"create_rest_endpoint" -> RMCreateRestEndpoint <$> args
|
|
|
|
"drop_rest_endpoint" -> RMDropRestEndpoint <$> args
|
2022-08-18 01:13:32 +03:00
|
|
|
"dc_add_agent" -> RMDCAddAgent <$> args
|
|
|
|
"dc_delete_agent" -> RMDCDeleteAgent <$> args
|
|
|
|
"list_source_kinds" -> RMListSourceKinds <$> args
|
2022-09-02 20:50:09 +03:00
|
|
|
"get_source_kind_capabilities" -> RMGetSourceKindCapabilities <$> args
|
2022-08-30 02:51:34 +03:00
|
|
|
"get_source_tables" -> RMGetSourceTables <$> args
|
|
|
|
"get_table_info" -> RMGetTableInfo <$> args
|
2021-09-24 01:56:37 +03:00
|
|
|
"set_custom_types" -> RMSetCustomTypes <$> args
|
|
|
|
"set_api_limits" -> RMSetApiLimits <$> args
|
|
|
|
"remove_api_limits" -> pure RMRemoveApiLimits
|
|
|
|
"set_metrics_config" -> RMSetMetricsConfig <$> args
|
|
|
|
"remove_metrics_config" -> pure RMRemoveMetricsConfig
|
|
|
|
"add_inherited_role" -> RMAddInheritedRole <$> args
|
|
|
|
"drop_inherited_role" -> RMDropInheritedRole <$> args
|
|
|
|
"replace_metadata" -> RMReplaceMetadata <$> args
|
|
|
|
"export_metadata" -> RMExportMetadata <$> args
|
|
|
|
"clear_metadata" -> RMClearMetadata <$> args
|
|
|
|
"reload_metadata" -> RMReloadMetadata <$> args
|
|
|
|
"get_inconsistent_metadata" -> RMGetInconsistentMetadata <$> args
|
|
|
|
"drop_inconsistent_metadata" -> RMDropInconsistentMetadata <$> args
|
|
|
|
"add_host_to_tls_allowlist" -> RMAddHostToTLSAllowlist <$> args
|
|
|
|
"drop_host_from_tls_allowlist" -> RMDropHostFromTLSAllowlist <$> args
|
|
|
|
"dump_internal_state" -> RMDumpInternalState <$> args
|
|
|
|
"get_catalog_state" -> RMGetCatalogState <$> args
|
|
|
|
"set_catalog_state" -> RMSetCatalogState <$> args
|
2021-07-07 04:43:42 +03:00
|
|
|
"set_graphql_schema_introspection_options" -> RMSetGraphqlSchemaIntrospectionOptions <$> args
|
2021-09-29 11:13:30 +03:00
|
|
|
"test_webhook_transform" -> RMTestWebhookTransform <$> args
|
2021-09-24 01:56:37 +03:00
|
|
|
"set_query_tags" -> RMSetQueryTagsConfig <$> args
|
|
|
|
"bulk" -> RMBulk <$> args
|
2022-08-24 00:46:10 +03:00
|
|
|
-- Backend prefixed metadata actions:
|
2021-07-07 04:43:42 +03:00
|
|
|
_ -> do
|
2022-08-24 00:46:10 +03:00
|
|
|
-- 1) Parse the backend source kind and metadata command:
|
2022-04-29 05:13:13 +03:00
|
|
|
(backendSourceKind, cmd) <- parseQueryType queryType
|
|
|
|
dispatchAnyBackend @BackendAPI backendSourceKind \(backendSourceKind' :: BackendSourceKind b) -> do
|
2022-08-24 00:46:10 +03:00
|
|
|
-- 2) Parse the args field:
|
2022-04-29 05:13:13 +03:00
|
|
|
argValue <- args
|
2022-08-24 00:46:10 +03:00
|
|
|
-- 2) Attempt to run all the backend specific command parsers against the source kind, cmd, and arg:
|
|
|
|
-- NOTE: If parsers succeed then this will pick out the first successful one.
|
2022-04-29 05:13:13 +03:00
|
|
|
command <- choice <$> sequenceA [p backendSourceKind' cmd argValue | p <- metadataV1CommandParsers @b]
|
|
|
|
onNothing command $
|
|
|
|
fail $
|
|
|
|
"unknown metadata command \"" <> T.unpack cmd
|
|
|
|
<> "\" for backend "
|
|
|
|
<> T.unpack (T.toTxt backendSourceKind')
|
2022-08-24 00:46:10 +03:00
|
|
|
|
|
|
|
-- | Parse the Metadata API action type returning a tuple of the
|
|
|
|
-- 'BackendSourceKind' and the action suffix.
|
|
|
|
--
|
|
|
|
-- For example: @"pg_add_source"@ parses as @(PostgresVanillaValue, "add_source")@
|
|
|
|
parseQueryType :: MonadFail m => Text -> m (AnyBackend BackendSourceKind, Text)
|
|
|
|
parseQueryType queryType =
|
|
|
|
let (prefix, T.drop 1 -> cmd) = T.breakOn "_" queryType
|
|
|
|
in (,cmd) <$> backendSourceKindFromText prefix
|
|
|
|
`onNothing` fail
|
|
|
|
( "unknown metadata command \"" <> T.unpack queryType
|
|
|
|
<> "\"; \""
|
|
|
|
<> T.unpack prefix
|
|
|
|
<> "\" was not recognized as a valid backend name"
|
|
|
|
)
|
2021-07-07 04:43:42 +03:00
|
|
|
|
2021-02-16 11:08:19 +03:00
|
|
|
data RQLMetadataV2
|
|
|
|
= RMV2ReplaceMetadata !ReplaceMetadataV2
|
2021-09-24 01:56:37 +03:00
|
|
|
| RMV2ExportMetadata !ExportMetadata
|
Clean metadata arguments
## Description
Thanks to #1664, the Metadata API types no longer require a `ToJSON` instance. This PR follows up with a cleanup of the types of the arguments to the metadata API:
- whenever possible, it moves those argument types to where they're used (RQL.DDL.*)
- it removes all unrequired instances (mostly `ToJSON`)
This PR does not attempt to do it for _all_ such argument types. For some of the metadata operations, the type used to describe the argument to the API and used to represent the value in the metadata are one and the same (like for `CreateEndpoint`). Sometimes, the two types are intertwined in complex ways (`RemoteRelationship` and `RemoteRelationshipDef`). In the spirit of only doing uncontroversial cleaning work, this PR only moves types that are not used outside of RQL.DDL.
Furthermore, this is a small step towards separating the different types all jumbled together in RQL.Types.
## Notes
This PR also improves several `FromJSON` instances to make use of `withObject`, and to use a human readable string instead of a type name in error messages whenever possible. For instance:
- before: `expected Object for Object, but encountered X`
after: `expected Object for add computed field, but encountered X`
- before: `Expecting an object for update query`
after: `expected Object for update query, but encountered X`
This PR also renames `CreateFunctionPermission` to `FunctionPermissionArgument`, to remove the quite surprising `type DropFunctionPermission = CreateFunctionPermission`.
This PR also deletes some dead code, mostly in RQL.DML.
This PR also moves a PG-specific source resolving function from DDL.Schema.Source to the only place where it is used: App.hs.
https://github.com/hasura/graphql-engine-mono/pull/1844
GitOrigin-RevId: a594521194bb7fe6a111b02a9e099896f9fed59c
2021-07-27 13:41:42 +03:00
|
|
|
deriving (Generic)
|
2021-07-07 04:43:42 +03:00
|
|
|
|
|
|
|
instance FromJSON RQLMetadataV2 where
|
2021-09-24 01:56:37 +03:00
|
|
|
parseJSON =
|
|
|
|
genericParseJSON $
|
|
|
|
defaultOptions
|
|
|
|
{ constructorTagModifier = snakeCase . drop 4,
|
|
|
|
sumEncoding = TaggedObject "type" "args"
|
|
|
|
}
|
2021-02-16 11:08:19 +03:00
|
|
|
|
2021-02-19 05:39:30 +03:00
|
|
|
data RQLMetadataRequest
|
2021-02-16 11:08:19 +03:00
|
|
|
= RMV1 !RQLMetadataV1
|
|
|
|
| RMV2 !RQLMetadataV2
|
|
|
|
|
2021-02-19 05:39:30 +03:00
|
|
|
instance FromJSON RQLMetadataRequest where
|
|
|
|
parseJSON = withObject "RQLMetadataRequest" $ \o -> do
|
2021-02-16 11:08:19 +03:00
|
|
|
version <- o .:? "version" .!= VIVersion1
|
|
|
|
let val = Object o
|
|
|
|
case version of
|
|
|
|
VIVersion1 -> RMV1 <$> parseJSON val
|
|
|
|
VIVersion2 -> RMV2 <$> parseJSON val
|
|
|
|
|
2022-08-19 00:56:47 +03:00
|
|
|
-- | The payload for the @/v1/metadata@ endpoint. See:
|
|
|
|
--
|
|
|
|
-- https://hasura.io/docs/latest/graphql/core/api-reference/metadata-api/index/
|
2021-09-24 01:56:37 +03:00
|
|
|
data RQLMetadata = RQLMetadata
|
|
|
|
{ _rqlMetadataResourceVersion :: !(Maybe MetadataResourceVersion),
|
|
|
|
_rqlMetadata :: !RQLMetadataRequest
|
Clean metadata arguments
## Description
Thanks to #1664, the Metadata API types no longer require a `ToJSON` instance. This PR follows up with a cleanup of the types of the arguments to the metadata API:
- whenever possible, it moves those argument types to where they're used (RQL.DDL.*)
- it removes all unrequired instances (mostly `ToJSON`)
This PR does not attempt to do it for _all_ such argument types. For some of the metadata operations, the type used to describe the argument to the API and used to represent the value in the metadata are one and the same (like for `CreateEndpoint`). Sometimes, the two types are intertwined in complex ways (`RemoteRelationship` and `RemoteRelationshipDef`). In the spirit of only doing uncontroversial cleaning work, this PR only moves types that are not used outside of RQL.DDL.
Furthermore, this is a small step towards separating the different types all jumbled together in RQL.Types.
## Notes
This PR also improves several `FromJSON` instances to make use of `withObject`, and to use a human readable string instead of a type name in error messages whenever possible. For instance:
- before: `expected Object for Object, but encountered X`
after: `expected Object for add computed field, but encountered X`
- before: `Expecting an object for update query`
after: `expected Object for update query, but encountered X`
This PR also renames `CreateFunctionPermission` to `FunctionPermissionArgument`, to remove the quite surprising `type DropFunctionPermission = CreateFunctionPermission`.
This PR also deletes some dead code, mostly in RQL.DML.
This PR also moves a PG-specific source resolving function from DDL.Schema.Source to the only place where it is used: App.hs.
https://github.com/hasura/graphql-engine-mono/pull/1844
GitOrigin-RevId: a594521194bb7fe6a111b02a9e099896f9fed59c
2021-07-27 13:41:42 +03:00
|
|
|
}
|
2021-02-19 05:39:30 +03:00
|
|
|
|
|
|
|
instance FromJSON RQLMetadata where
|
|
|
|
parseJSON = withObject "RQLMetadata" $ \o -> do
|
|
|
|
_rqlMetadataResourceVersion <- o .:? "resource_version"
|
|
|
|
_rqlMetadata <- parseJSON $ Object o
|
2021-09-24 01:56:37 +03:00
|
|
|
pure RQLMetadata {..}
|
|
|
|
|
|
|
|
runMetadataQuery ::
|
2021-10-13 19:38:56 +03:00
|
|
|
( MonadIO m,
|
2021-09-24 01:56:37 +03:00
|
|
|
MonadBaseControl IO m,
|
|
|
|
Tracing.MonadTrace m,
|
|
|
|
MonadMetadataStorage m,
|
2022-09-09 11:26:44 +03:00
|
|
|
MonadResolveSource m,
|
|
|
|
MonadEventLogCleanup m
|
2021-09-24 01:56:37 +03:00
|
|
|
) =>
|
|
|
|
Env.Environment ->
|
|
|
|
L.Logger L.Hasura ->
|
|
|
|
InstanceId ->
|
|
|
|
UserInfo ->
|
|
|
|
HTTP.Manager ->
|
|
|
|
ServerConfigCtx ->
|
|
|
|
RebuildableSchemaCache ->
|
|
|
|
RQLMetadata ->
|
|
|
|
m (EncJSON, RebuildableSchemaCache)
|
|
|
|
runMetadataQuery env logger instanceId userInfo httpManager serverConfigCtx schemaCache RQLMetadata {..} = do
|
2022-08-19 00:56:47 +03:00
|
|
|
(metadata, currentResourceVersion) <- Tracing.trace "fetchMetadata" fetchMetadata
|
2021-01-07 12:04:22 +03:00
|
|
|
((r, modMetadata), modSchemaCache, cacheInvalidations) <-
|
2021-02-19 05:39:30 +03:00
|
|
|
runMetadataQueryM env currentResourceVersion _rqlMetadata
|
2021-09-24 01:56:37 +03:00
|
|
|
& flip runReaderT logger
|
|
|
|
& runMetadataT metadata
|
|
|
|
& runCacheRWT schemaCache
|
|
|
|
& peelRun (RunCtx userInfo httpManager serverConfigCtx)
|
|
|
|
& runExceptT
|
|
|
|
& liftEitherM
|
2021-01-07 12:04:22 +03:00
|
|
|
-- set modified metadata in storage
|
2021-05-21 05:46:58 +03:00
|
|
|
if queryModifiesMetadata _rqlMetadata
|
2021-12-08 09:26:46 +03:00
|
|
|
then case (_sccMaintenanceMode serverConfigCtx, _sccReadOnlyMode serverConfigCtx) of
|
|
|
|
(MaintenanceModeDisabled, ReadOnlyModeDisabled) -> do
|
2021-09-24 01:56:37 +03:00
|
|
|
-- set modified metadata in storage
|
2022-08-19 00:56:47 +03:00
|
|
|
newResourceVersion <-
|
|
|
|
Tracing.trace "setMetadata" $
|
|
|
|
setMetadata (fromMaybe currentResourceVersion _rqlMetadataResourceVersion) modMetadata
|
2022-03-17 23:53:56 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
-- notify schema cache sync
|
2022-08-19 00:56:47 +03:00
|
|
|
Tracing.trace "notifySchemaCacheSync" $
|
|
|
|
notifySchemaCacheSync newResourceVersion instanceId cacheInvalidations
|
2021-09-24 01:56:37 +03:00
|
|
|
(_, modSchemaCache', _) <-
|
2022-08-19 00:56:47 +03:00
|
|
|
Tracing.trace "setMetadataResourceVersionInSchemaCache" $
|
|
|
|
setMetadataResourceVersionInSchemaCache newResourceVersion
|
|
|
|
& runCacheRWT modSchemaCache
|
|
|
|
& peelRun (RunCtx userInfo httpManager serverConfigCtx)
|
|
|
|
& runExceptT
|
|
|
|
& liftEitherM
|
2021-08-24 10:36:32 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
pure (r, modSchemaCache')
|
2022-04-28 23:55:13 +03:00
|
|
|
(MaintenanceModeEnabled (), ReadOnlyModeDisabled) ->
|
2021-12-08 09:26:46 +03:00
|
|
|
throw500 "metadata cannot be modified in maintenance mode"
|
|
|
|
(MaintenanceModeDisabled, ReadOnlyModeEnabled) ->
|
|
|
|
throw400 NotSupported "metadata cannot be modified in read-only mode"
|
2022-04-28 23:55:13 +03:00
|
|
|
(MaintenanceModeEnabled (), ReadOnlyModeEnabled) ->
|
2021-09-24 01:56:37 +03:00
|
|
|
throw500 "metadata cannot be modified in maintenance mode"
|
|
|
|
else pure (r, modSchemaCache)
|
2021-01-07 12:04:22 +03:00
|
|
|
|
2021-02-19 05:39:30 +03:00
|
|
|
queryModifiesMetadata :: RQLMetadataRequest -> Bool
|
2021-02-18 19:46:14 +03:00
|
|
|
queryModifiesMetadata = \case
|
|
|
|
RMV1 q ->
|
|
|
|
case q of
|
2021-09-24 01:56:37 +03:00
|
|
|
RMRedeliverEvent _ -> False
|
|
|
|
RMInvokeEventTrigger _ -> False
|
2021-04-27 07:22:32 +03:00
|
|
|
RMGetInconsistentMetadata _ -> False
|
2021-09-24 01:56:37 +03:00
|
|
|
RMIntrospectRemoteSchema _ -> False
|
|
|
|
RMDumpInternalState _ -> False
|
|
|
|
RMSetCatalogState _ -> False
|
|
|
|
RMGetCatalogState _ -> False
|
|
|
|
RMExportMetadata _ -> False
|
|
|
|
RMGetEventInvocations _ -> False
|
2022-01-27 09:43:39 +03:00
|
|
|
RMGetCronTriggers -> False
|
2021-09-24 01:56:37 +03:00
|
|
|
RMGetScheduledEvents _ -> False
|
|
|
|
RMCreateScheduledEvent _ -> False
|
|
|
|
RMDeleteScheduledEvent _ -> False
|
2021-10-05 02:49:51 +03:00
|
|
|
RMTestWebhookTransform _ -> False
|
2022-09-15 10:34:03 +03:00
|
|
|
RMGetSourceKindCapabilities _ -> False
|
|
|
|
RMListSourceKinds _ -> False
|
|
|
|
RMGetSourceTables _ -> False
|
|
|
|
RMGetTableInfo _ -> False
|
2021-09-24 01:56:37 +03:00
|
|
|
RMBulk qs -> any queryModifiesMetadata qs
|
2022-09-15 10:34:03 +03:00
|
|
|
-- We used to assume that the fallthrough was True,
|
|
|
|
-- but it is better to be explicit here to warn when new constructors are added.
|
|
|
|
RMAddSource _ -> True
|
|
|
|
RMDropSource _ -> True
|
|
|
|
RMRenameSource _ -> True
|
|
|
|
RMUpdateSource _ -> True
|
|
|
|
RMTrackTable _ -> True
|
|
|
|
RMUntrackTable _ -> True
|
|
|
|
RMSetTableCustomization _ -> True
|
|
|
|
RMSetApolloFederationConfig _ -> True
|
|
|
|
RMPgSetTableIsEnum _ -> True
|
|
|
|
RMCreateInsertPermission _ -> True
|
|
|
|
RMCreateSelectPermission _ -> True
|
|
|
|
RMCreateUpdatePermission _ -> True
|
|
|
|
RMCreateDeletePermission _ -> True
|
|
|
|
RMDropInsertPermission _ -> True
|
|
|
|
RMDropSelectPermission _ -> True
|
|
|
|
RMDropUpdatePermission _ -> True
|
|
|
|
RMDropDeletePermission _ -> True
|
|
|
|
RMSetPermissionComment _ -> True
|
|
|
|
RMCreateObjectRelationship _ -> True
|
|
|
|
RMCreateArrayRelationship _ -> True
|
|
|
|
RMDropRelationship _ -> True
|
|
|
|
RMSetRelationshipComment _ -> True
|
|
|
|
RMRenameRelationship _ -> True
|
|
|
|
RMCreateRemoteRelationship _ -> True
|
|
|
|
RMUpdateRemoteRelationship _ -> True
|
|
|
|
RMDeleteRemoteRelationship _ -> True
|
|
|
|
RMTrackFunction _ -> True
|
|
|
|
RMUntrackFunction _ -> True
|
|
|
|
RMSetFunctionCustomization _ -> True
|
|
|
|
RMCreateFunctionPermission _ -> True
|
|
|
|
RMDropFunctionPermission _ -> True
|
|
|
|
RMAddComputedField _ -> True
|
|
|
|
RMDropComputedField _ -> True
|
|
|
|
RMCreateEventTrigger _ -> True
|
|
|
|
RMDeleteEventTrigger _ -> True
|
|
|
|
RMCleanupEventTriggerLog _ -> True
|
|
|
|
RMStartEventTriggerCleanup _ -> True
|
|
|
|
RMPauseEventTriggerCleanup _ -> True
|
|
|
|
RMAddRemoteSchema _ -> True
|
|
|
|
RMUpdateRemoteSchema _ -> True
|
|
|
|
RMRemoveRemoteSchema _ -> True
|
|
|
|
RMReloadRemoteSchema _ -> True
|
|
|
|
RMAddRemoteSchemaPermissions _ -> True
|
|
|
|
RMDropRemoteSchemaPermissions _ -> True
|
|
|
|
RMCreateRemoteSchemaRemoteRelationship _ -> True
|
|
|
|
RMUpdateRemoteSchemaRemoteRelationship _ -> True
|
|
|
|
RMDeleteRemoteSchemaRemoteRelationship _ -> True
|
|
|
|
RMCreateCronTrigger _ -> True
|
|
|
|
RMDeleteCronTrigger _ -> True
|
|
|
|
RMCreateAction _ -> True
|
|
|
|
RMDropAction _ -> True
|
|
|
|
RMUpdateAction _ -> True
|
|
|
|
RMCreateActionPermission _ -> True
|
|
|
|
RMDropActionPermission _ -> True
|
|
|
|
RMCreateQueryCollection _ -> True
|
|
|
|
RMRenameQueryCollection _ -> True
|
|
|
|
RMDropQueryCollection _ -> True
|
|
|
|
RMAddQueryToCollection _ -> True
|
|
|
|
RMDropQueryFromCollection _ -> True
|
|
|
|
RMAddCollectionToAllowlist _ -> True
|
|
|
|
RMDropCollectionFromAllowlist _ -> True
|
|
|
|
RMUpdateScopeOfCollectionInAllowlist _ -> True
|
|
|
|
RMCreateRestEndpoint _ -> True
|
|
|
|
RMDropRestEndpoint _ -> True
|
|
|
|
RMDCAddAgent _ -> True
|
|
|
|
RMDCDeleteAgent _ -> True
|
|
|
|
RMSetCustomTypes _ -> True
|
|
|
|
RMSetApiLimits _ -> True
|
|
|
|
RMRemoveApiLimits -> True
|
|
|
|
RMSetMetricsConfig _ -> True
|
|
|
|
RMRemoveMetricsConfig -> True
|
|
|
|
RMAddInheritedRole _ -> True
|
|
|
|
RMDropInheritedRole _ -> True
|
|
|
|
RMReplaceMetadata _ -> True
|
|
|
|
RMClearMetadata _ -> True
|
|
|
|
RMReloadMetadata _ -> True
|
|
|
|
RMDropInconsistentMetadata _ -> True
|
|
|
|
RMSetGraphqlSchemaIntrospectionOptions _ -> True
|
|
|
|
RMAddHostToTLSAllowlist _ -> True
|
|
|
|
RMDropHostFromTLSAllowlist _ -> True
|
|
|
|
RMSetQueryTagsConfig _ -> True
|
2021-02-19 05:39:30 +03:00
|
|
|
RMV2 q ->
|
|
|
|
case q of
|
2021-04-27 07:22:32 +03:00
|
|
|
RMV2ExportMetadata _ -> False
|
2021-09-24 01:56:37 +03:00
|
|
|
_ -> True
|
|
|
|
|
|
|
|
runMetadataQueryM ::
|
2021-10-13 19:38:56 +03:00
|
|
|
( MonadIO m,
|
2021-09-24 01:56:37 +03:00
|
|
|
MonadBaseControl IO m,
|
|
|
|
CacheRWM m,
|
|
|
|
Tracing.MonadTrace m,
|
|
|
|
UserInfoM m,
|
|
|
|
HTTP.HasHttpManagerM m,
|
|
|
|
MetadataM m,
|
|
|
|
MonadMetadataStorageQueryAPI m,
|
|
|
|
HasServerConfigCtx m,
|
|
|
|
MonadReader r m,
|
2022-09-09 11:26:44 +03:00
|
|
|
Has (L.Logger L.Hasura) r,
|
|
|
|
MonadEventLogCleanup m
|
2021-09-24 01:56:37 +03:00
|
|
|
) =>
|
|
|
|
Env.Environment ->
|
|
|
|
MetadataResourceVersion ->
|
|
|
|
RQLMetadataRequest ->
|
|
|
|
m EncJSON
|
|
|
|
runMetadataQueryM env currentResourceVersion =
|
|
|
|
withPathK "args" . \case
|
2022-08-19 00:56:47 +03:00
|
|
|
-- NOTE: This is a good place to install tracing, since it's involved in
|
|
|
|
-- the recursive case via "bulk":
|
|
|
|
RMV1 q ->
|
|
|
|
Tracing.trace ("v1 " <> T.pack (constrName q)) $
|
|
|
|
runMetadataQueryV1M env currentResourceVersion q
|
|
|
|
RMV2 q ->
|
|
|
|
Tracing.trace ("v2 " <> T.pack (constrName q)) $
|
|
|
|
runMetadataQueryV2M currentResourceVersion q
|
2021-09-24 01:56:37 +03:00
|
|
|
|
|
|
|
runMetadataQueryV1M ::
|
|
|
|
forall m r.
|
2021-10-13 19:38:56 +03:00
|
|
|
( MonadIO m,
|
2021-09-24 01:56:37 +03:00
|
|
|
MonadBaseControl IO m,
|
|
|
|
CacheRWM m,
|
|
|
|
Tracing.MonadTrace m,
|
|
|
|
UserInfoM m,
|
|
|
|
HTTP.HasHttpManagerM m,
|
|
|
|
MetadataM m,
|
|
|
|
MonadMetadataStorageQueryAPI m,
|
|
|
|
HasServerConfigCtx m,
|
|
|
|
MonadReader r m,
|
2022-09-09 11:26:44 +03:00
|
|
|
Has (L.Logger L.Hasura) r,
|
|
|
|
MonadEventLogCleanup m
|
2021-09-24 01:56:37 +03:00
|
|
|
) =>
|
|
|
|
Env.Environment ->
|
|
|
|
MetadataResourceVersion ->
|
|
|
|
RQLMetadataV1 ->
|
|
|
|
m EncJSON
|
2021-02-19 05:39:30 +03:00
|
|
|
runMetadataQueryV1M env currentResourceVersion = \case
|
2021-09-24 01:56:37 +03:00
|
|
|
RMAddSource q -> dispatchMetadata runAddSource q
|
|
|
|
RMDropSource q -> runDropSource q
|
|
|
|
RMRenameSource q -> runRenameSource q
|
2022-06-22 10:06:19 +03:00
|
|
|
RMUpdateSource q -> dispatchMetadata runUpdateSource q
|
2022-08-30 02:51:34 +03:00
|
|
|
RMListSourceKinds q -> runListSourceKinds q
|
2022-09-02 20:50:09 +03:00
|
|
|
RMGetSourceKindCapabilities q -> runGetSourceKindCapabilities q
|
2022-08-30 02:51:34 +03:00
|
|
|
RMGetSourceTables q -> runGetSourceTables q
|
|
|
|
RMGetTableInfo q -> runGetTableInfo q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMTrackTable q -> dispatchMetadata runTrackTableV2Q q
|
2022-07-27 10:56:53 +03:00
|
|
|
RMUntrackTable q -> dispatchMetadataAndEventTrigger runUntrackTableQ q
|
2021-10-07 16:02:19 +03:00
|
|
|
RMSetFunctionCustomization q -> dispatchMetadata runSetFunctionCustomization q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMSetTableCustomization q -> dispatchMetadata runSetTableCustomization q
|
2022-08-04 12:35:58 +03:00
|
|
|
RMSetApolloFederationConfig q -> dispatchMetadata runSetApolloFederationConfig q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMPgSetTableIsEnum q -> runSetExistingTableIsEnumQ q
|
|
|
|
RMCreateInsertPermission q -> dispatchMetadata runCreatePerm q
|
|
|
|
RMCreateSelectPermission q -> dispatchMetadata runCreatePerm q
|
|
|
|
RMCreateUpdatePermission q -> dispatchMetadata runCreatePerm q
|
|
|
|
RMCreateDeletePermission q -> dispatchMetadata runCreatePerm q
|
2022-04-06 15:47:35 +03:00
|
|
|
RMDropInsertPermission q -> dispatchMetadata (runDropPerm PTInsert) q
|
|
|
|
RMDropSelectPermission q -> dispatchMetadata (runDropPerm PTSelect) q
|
|
|
|
RMDropUpdatePermission q -> dispatchMetadata (runDropPerm PTUpdate) q
|
|
|
|
RMDropDeletePermission q -> dispatchMetadata (runDropPerm PTDelete) q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMSetPermissionComment q -> dispatchMetadata runSetPermComment q
|
|
|
|
RMCreateObjectRelationship q -> dispatchMetadata (runCreateRelationship ObjRel . unCreateObjRel) q
|
|
|
|
RMCreateArrayRelationship q -> dispatchMetadata (runCreateRelationship ArrRel . unCreateArrRel) q
|
|
|
|
RMDropRelationship q -> dispatchMetadata runDropRel q
|
|
|
|
RMSetRelationshipComment q -> dispatchMetadata runSetRelComment q
|
|
|
|
RMRenameRelationship q -> dispatchMetadata runRenameRel q
|
|
|
|
RMCreateRemoteRelationship q -> dispatchMetadata runCreateRemoteRelationship q
|
|
|
|
RMUpdateRemoteRelationship q -> dispatchMetadata runUpdateRemoteRelationship q
|
Fix several issues with remote relationships.
## Remaining Work
- [x] changelog entry
- [x] more tests: `<backend>_delete_remote_relationship` is definitely untested
- [x] negative tests: we probably want to assert that there are some APIs we DON'T support
- [x] update the console to use the new API, if necessary
- [x] ~~adding the corresponding documentation for the API for other backends (only `pg_` was added here)~~
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3170
- [x] ~~deciding which backends should support this API~~
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3170
- [x] ~~deciding what to do about potentially overlapping schematic representations~~
- ~~cf. https://github.com/hasura/graphql-engine-mono/pull/3157#issuecomment-995307624~~
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3171
- [x] ~~add more descriptive versioning information to some of the types that are changing in this PR~~
- cf. https://github.com/hasura/graphql-engine-mono/pull/3157#discussion_r769830920
- deferred to https://github.com/hasura/graphql-engine-mono/issues/3172
## Description
This PR fixes several important issues wrt. the remote relationship API.
- it fixes a regression introduced by [#3124](https://github.com/hasura/graphql-engine-mono/pull/3124), which prevented `<backend>_create_remote_relationship` from accepting the old argument format (break of backwards compatibility, broke the console)
- it removes the command `create_remote_relationship` added to the v1/metadata API as a work-around as part of [#3124](https://github.com/hasura/graphql-engine-mono/pull/3124)
- it reverts the subsequent fix in the console: [#3149](https://github.com/hasura/graphql-engine-mono/pull/3149)
Furthermore, this PR also addresses two other issues:
- THE DOCUMENTATION OF THE METADATA API WAS WRONG, and documented `create_remote_relationship` instead of `<backend>_create_remote_relationship`: this PR fixes this by adding `pg_` everywhere, but does not attempt to add the corresponding documentation for other backends, partly because:
- `<backend>_delete_remote_relationship` WAS BROKEN ON NON-POSTGRES BACKENDS; it always expected an argument parameterized by Postgres.
As of main, the `<backend>_(create|update|delete)_remote_relationship` commands are supported on Postgres, Citus, BigQuery, but **NOT MSSQL**. I do not know if this is intentional or not, if it even should be publicized or not, and as a result this PR doesn't change this.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3157
Co-authored-by: jkachmar <8461423+jkachmar@users.noreply.github.com>
GitOrigin-RevId: 37e2f41522a9229a11c595574c3f4984317d652a
2021-12-16 23:28:08 +03:00
|
|
|
RMDeleteRemoteRelationship q -> dispatchMetadata runDeleteRemoteRelationship q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMTrackFunction q -> dispatchMetadata runTrackFunctionV2 q
|
|
|
|
RMUntrackFunction q -> dispatchMetadata runUntrackFunc q
|
|
|
|
RMCreateFunctionPermission q -> dispatchMetadata runCreateFunctionPermission q
|
|
|
|
RMDropFunctionPermission q -> dispatchMetadata runDropFunctionPermission q
|
2022-05-04 17:52:29 +03:00
|
|
|
RMAddComputedField q -> dispatchMetadata runAddComputedField q
|
|
|
|
RMDropComputedField q -> dispatchMetadata runDropComputedField q
|
2022-03-11 02:22:54 +03:00
|
|
|
RMCreateEventTrigger q ->
|
2022-03-15 11:41:03 +03:00
|
|
|
dispatchMetadataAndEventTrigger
|
2022-03-11 02:22:54 +03:00
|
|
|
( validateTransforms
|
|
|
|
(unUnvalidate1 . cetqRequestTransform . _Just)
|
|
|
|
(runCreateEventTriggerQuery . _unUnvalidate1)
|
|
|
|
)
|
|
|
|
q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMDeleteEventTrigger q -> dispatchMetadataAndEventTrigger runDeleteEventTriggerQuery q
|
|
|
|
RMRedeliverEvent q -> dispatchEventTrigger runRedeliverEvent q
|
|
|
|
RMInvokeEventTrigger q -> dispatchEventTrigger runInvokeEventTrigger q
|
2022-09-09 11:26:44 +03:00
|
|
|
RMCleanupEventTriggerLog q -> runCleanupEventTriggerLog q
|
2022-09-13 11:33:44 +03:00
|
|
|
RMStartEventTriggerCleanup q -> runEventTriggerStartCleanup q
|
|
|
|
RMPauseEventTriggerCleanup q -> runEventTriggerPauseCleanup q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMAddRemoteSchema q -> runAddRemoteSchema env q
|
|
|
|
RMUpdateRemoteSchema q -> runUpdateRemoteSchema env q
|
|
|
|
RMRemoveRemoteSchema q -> runRemoveRemoteSchema q
|
|
|
|
RMReloadRemoteSchema q -> runReloadRemoteSchema q
|
|
|
|
RMIntrospectRemoteSchema q -> runIntrospectRemoteSchema q
|
|
|
|
RMAddRemoteSchemaPermissions q -> runAddRemoteSchemaPermissions q
|
|
|
|
RMDropRemoteSchemaPermissions q -> runDropRemoteSchemaPermissions q
|
2022-03-17 23:53:56 +03:00
|
|
|
RMCreateRemoteSchemaRemoteRelationship q -> runCreateRemoteSchemaRemoteRelationship q
|
|
|
|
RMUpdateRemoteSchemaRemoteRelationship q -> runUpdateRemoteSchemaRemoteRelationship q
|
|
|
|
RMDeleteRemoteSchemaRemoteRelationship q -> runDeleteRemoteSchemaRemoteRelationship q
|
2022-03-11 02:22:54 +03:00
|
|
|
RMCreateCronTrigger q ->
|
|
|
|
validateTransforms
|
|
|
|
(unUnvalidate . cctRequestTransform . _Just)
|
|
|
|
(runCreateCronTrigger . _unUnvalidate)
|
|
|
|
q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMDeleteCronTrigger q -> runDeleteCronTrigger q
|
|
|
|
RMCreateScheduledEvent q -> runCreateScheduledEvent q
|
|
|
|
RMDeleteScheduledEvent q -> runDeleteScheduledEvent q
|
|
|
|
RMGetScheduledEvents q -> runGetScheduledEvents q
|
|
|
|
RMGetEventInvocations q -> runGetEventInvocations q
|
2022-01-27 09:43:39 +03:00
|
|
|
RMGetCronTriggers -> runGetCronTriggers
|
2022-03-11 02:22:54 +03:00
|
|
|
RMCreateAction q ->
|
|
|
|
validateTransforms
|
|
|
|
(unUnvalidate . caDefinition . adRequestTransform . _Just)
|
|
|
|
(runCreateAction . _unUnvalidate)
|
|
|
|
q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMDropAction q -> runDropAction q
|
2022-03-11 02:22:54 +03:00
|
|
|
RMUpdateAction q ->
|
|
|
|
validateTransforms
|
|
|
|
(unUnvalidate . uaDefinition . adRequestTransform . _Just)
|
|
|
|
(runUpdateAction . _unUnvalidate)
|
|
|
|
q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMCreateActionPermission q -> runCreateActionPermission q
|
|
|
|
RMDropActionPermission q -> runDropActionPermission q
|
|
|
|
RMCreateQueryCollection q -> runCreateCollection q
|
2022-08-19 16:36:02 +03:00
|
|
|
RMRenameQueryCollection q -> runRenameCollection q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMDropQueryCollection q -> runDropCollection q
|
|
|
|
RMAddQueryToCollection q -> runAddQueryToCollection q
|
|
|
|
RMDropQueryFromCollection q -> runDropQueryFromCollection q
|
|
|
|
RMAddCollectionToAllowlist q -> runAddCollectionToAllowlist q
|
|
|
|
RMDropCollectionFromAllowlist q -> runDropCollectionFromAllowlist q
|
2022-02-08 19:53:30 +03:00
|
|
|
RMUpdateScopeOfCollectionInAllowlist q -> runUpdateScopeOfCollectionInAllowlist q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMCreateRestEndpoint q -> runCreateEndpoint q
|
|
|
|
RMDropRestEndpoint q -> runDropEndpoint q
|
2022-08-18 01:13:32 +03:00
|
|
|
RMDCAddAgent q -> runAddDataConnectorAgent q
|
|
|
|
RMDCDeleteAgent q -> runDeleteDataConnectorAgent q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMSetCustomTypes q -> runSetCustomTypes q
|
|
|
|
RMSetApiLimits q -> runSetApiLimits q
|
|
|
|
RMRemoveApiLimits -> runRemoveApiLimits
|
|
|
|
RMSetMetricsConfig q -> runSetMetricsConfig q
|
|
|
|
RMRemoveMetricsConfig -> runRemoveMetricsConfig
|
|
|
|
RMAddInheritedRole q -> runAddInheritedRole q
|
|
|
|
RMDropInheritedRole q -> runDropInheritedRole q
|
|
|
|
RMReplaceMetadata q -> runReplaceMetadata q
|
|
|
|
RMExportMetadata q -> runExportMetadata q
|
|
|
|
RMClearMetadata q -> runClearMetadata q
|
|
|
|
RMReloadMetadata q -> runReloadMetadata q
|
|
|
|
RMGetInconsistentMetadata q -> runGetInconsistentMetadata q
|
|
|
|
RMDropInconsistentMetadata q -> runDropInconsistentMetadata q
|
2021-05-05 15:25:27 +03:00
|
|
|
RMSetGraphqlSchemaIntrospectionOptions q -> runSetGraphqlSchemaIntrospectionOptions q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMAddHostToTLSAllowlist q -> runAddHostToTLSAllowlist q
|
|
|
|
RMDropHostFromTLSAllowlist q -> runDropHostFromTLSAllowlist q
|
|
|
|
RMDumpInternalState q -> runDumpInternalState q
|
|
|
|
RMGetCatalogState q -> runGetCatalogState q
|
|
|
|
RMSetCatalogState q -> runSetCatalogState q
|
2022-03-11 02:22:54 +03:00
|
|
|
RMTestWebhookTransform q ->
|
|
|
|
validateTransforms
|
|
|
|
(unUnvalidate . twtTransformer)
|
|
|
|
(runTestWebhookTransform . _unUnvalidate)
|
|
|
|
q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMSetQueryTagsConfig q -> runSetQueryTagsConfig q
|
|
|
|
RMBulk q -> encJFromList <$> indexedMapM (runMetadataQueryM env currentResourceVersion) q
|
2021-07-07 04:43:42 +03:00
|
|
|
where
|
2021-09-24 01:56:37 +03:00
|
|
|
dispatchMetadata ::
|
|
|
|
(forall b. BackendMetadata b => i b -> a) ->
|
|
|
|
AnyBackend i ->
|
|
|
|
a
|
2021-09-06 14:15:36 +03:00
|
|
|
dispatchMetadata f x = dispatchAnyBackend @BackendMetadata x f
|
|
|
|
|
|
|
|
dispatchEventTrigger :: (forall b. BackendEventTrigger b => i b -> a) -> AnyBackend i -> a
|
|
|
|
dispatchEventTrigger f x = dispatchAnyBackend @BackendEventTrigger x f
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
dispatchMetadataAndEventTrigger ::
|
|
|
|
(forall b. (BackendMetadata b, BackendEventTrigger b) => i b -> a) ->
|
|
|
|
AnyBackend i ->
|
|
|
|
a
|
2021-09-09 14:54:19 +03:00
|
|
|
dispatchMetadataAndEventTrigger f x = dispatchAnyBackendWithTwoConstraints @BackendMetadata @BackendEventTrigger x f
|
2021-02-16 11:08:19 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
runMetadataQueryV2M ::
|
|
|
|
( MonadIO m,
|
|
|
|
CacheRWM m,
|
2022-09-13 07:16:35 +03:00
|
|
|
MonadBaseControl IO m,
|
2021-09-24 01:56:37 +03:00
|
|
|
MetadataM m,
|
|
|
|
MonadMetadataStorageQueryAPI m,
|
|
|
|
MonadReader r m,
|
2022-09-15 14:45:14 +03:00
|
|
|
Has (L.Logger L.Hasura) r,
|
|
|
|
MonadEventLogCleanup m
|
2021-09-24 01:56:37 +03:00
|
|
|
) =>
|
|
|
|
MetadataResourceVersion ->
|
|
|
|
RQLMetadataV2 ->
|
|
|
|
m EncJSON
|
2021-02-19 05:39:30 +03:00
|
|
|
runMetadataQueryV2M currentResourceVersion = \case
|
2021-02-16 11:08:19 +03:00
|
|
|
RMV2ReplaceMetadata q -> runReplaceMetadataV2 q
|
2021-09-24 01:56:37 +03:00
|
|
|
RMV2ExportMetadata q -> runExportMetadataV2 currentResourceVersion q
|