hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-09-22 07:58:52 +03:00
Code Issues Projects Releases Wiki Activity

console semver check fix for non-tag versions (#1134)

Browse Source
This commit is contained in:
Aravind Shankar 2018-12-03 14:43:49 +05:30 committed by Shahidh K Muhammed
parent 5f6293c185
commit 0281a1bfe1
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
console/package-lock.json generated
View File

@ -2140,7 +2140,7 @@
"dependencies": {
"dotenv": {
"version": "2.0.0",
"resolved": "https://registry.npmjs.org/dotenv/-/dotenv-2.0.0.tgz",
"resolved": "http://registry.npmjs.org/dotenv/-/dotenv-2.0.0.tgz",
"integrity": "sha1-vXWcNXqqcDZeAclrewvsCKbg2Uk=",
"dev": true
}
@ -4352,7 +4352,7 @@
},
"load-json-file": {
"version": "2.0.0",
"resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz",
"resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz",
"integrity": "sha1-eUfkIUmvgNaWy/eXvKq8/h/inKg=",
"dev": true,
"requires": {

2
console/package.json
View File

@ -94,7 +94,7 @@
"redux": "^4.0.0",
"redux-logger": "^3.0.6",
"redux-thunk": "^2.2.0",
"semver": "^5.3.0",
"semver": "5.5.1",
"subscriptions-transport-ws": "^0.9.12",
"uuid": "^3.0.1",
"valid-url": "^1.0.9"

6
console/src/helpers/semver.js
View File

@ -33,14 +33,12 @@ const getPreRelease = version => {
const semverCheck = (component, serverVersion) => {
if (component in componentsSemver) {
const componentCoerce = semver.valid(
semver.coerce(componentsSemver[component])
);
const componentCoerce = semver.valid(componentsSemver[component]);
if (componentCoerce == null) {
return false;
}
const serverCoerce = semver.valid(semver.coerce(serverVersion));
const serverCoerce = semver.valid(serverVersion);
if (serverCoerce == null) {
return true;
}