This commit is contained in:
Kirankumar Ambati 2019-09-27 12:36:08 +05:30 committed by Rikin Kachhia
parent 68332fac54
commit 0bf1d9ac83
3 changed files with 9 additions and 10 deletions

View File

@ -53,12 +53,10 @@ class App extends Component {
);
}
if (telemetry.console_opts) {
if (!telemetry.console_opts.telemetryNotificationShown) {
if (telemetry.console_opts && !telemetry.console_opts.telemetryNotificationShown) {
dispatch(showTelemetryNotification());
dispatch(telemetryNotificationShown());
}
}
return (
<ErrorBoundary metadata={metadata} dispatch={dispatch}>

View File

@ -2,10 +2,11 @@ import React from 'react';
import styles from '../Common.scss';
/*
This is a Button HOC that takes al the props supported by <button> and also
- color: (default: white) color of the button; currently supports yellow, red, green, gray, white
This is a Button HOC that takes all the props supported by <button>
- color(default: white): color of the button; currently supports yellow, red, green, gray and white
- size: size of the button; currently supports xs (extra small), sm(small)
- className: although you can provide any CSS classname, it is recommended to use only the positioning related classes and not the ones that change the appearance (color, font, size) of the button
- className: although you can provide any CSS classname, it is recommended to use only the positioning related classes
and not the ones that change the appearance (color, font, size) of the button
*/
const Button = props => {

View File

@ -36,7 +36,7 @@ class QueryBuilderJson extends React.Component {
};
const isCustomJsonObject = object => {
// check if is array
// check if it is an array
if (object instanceof Array) {
// if empty array
if (object.length === 0) {
@ -68,7 +68,7 @@ class QueryBuilderJson extends React.Component {
return true;
}
// check if is object and not a React element
// check if it is an object and not a React element
return object instanceof Object && !React.isValidElement(object);
};