hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 01:12:56 +03:00
Code Issues Projects Releases Wiki Activity

cli: generate migrations for mssql databases in hasura console mode

Browse Source 
closes https://github.com/hasura/graphql-engine/issues/7011

https://github.com/hasura/graphql-engine-mono/pull/1527

Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: c03af1b9c4221263a5e23a41bb710010fe82c018
This commit is contained in:
Kali Vara Purushotham Santhati 2021-06-15 11:59:45 +05:30 committed by hasura-bot
parent ad2f48c534
commit 0ce7769603
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -13,6 +13,7 @@
- console: add modify functionality on columns, primary keys & unique keys to MS SQL Server tables - console: add modify functionality on columns, primary keys & unique keys to MS SQL Server tables
- cli: add interactive prompt to get input when `--database-name` flag is missing - cli: add interactive prompt to get input when `--database-name` flag is missing
- cli: fix metadata export to avoid unnecessary empty lines in actions.graphql (#5338) - cli: fix metadata export to avoid unnecessary empty lines in actions.graphql (#5338)
- cli: generate migrations for mssql databases in hasura console mode (#7011)
## v2.0.0-beta.1 ## v2.0.0-beta.1

6
cli/migrate/api/migrate.go
View File

@ -151,11 +151,11 @@ func MigrateAPI(c *gin.Context) {
return return
} }
createOptions := cmd.New(timestamp, request.Name, filepath.Join(ec.MigrationDir, sourceName)) createOptions := cmd.New(timestamp, request.Name, filepath.Join(ec.MigrationDir, sourceName))
if version != int(cli.V1) { if version != int(cli.V1) && migrate.IsMigrationsSupported(sourceKind) {
sqlUp := &bytes.Buffer{} sqlUp := &bytes.Buffer{}
sqlDown := &bytes.Buffer{} sqlDown := &bytes.Buffer{}
for _, arg := range request.Up { for _, arg := range request.Up {
if arg.Type == hasuradb.RunSQL { if strings.Contains(arg.Type, "run_sql") {
argByt, err := json.Marshal(arg.Args) argByt, err := json.Marshal(arg.Args)
if err != nil { if err != nil {
c.JSON(http.StatusInternalServerError, &Response{Code: "request_parse_error", Message: err.Error()}) c.JSON(http.StatusInternalServerError, &Response{Code: "request_parse_error", Message: err.Error()})
@ -173,7 +173,7 @@ func MigrateAPI(c *gin.Context) {
} }
for _, arg := range request.Down { for _, arg := range request.Down {
if arg.Type == hasuradb.RunSQL { if strings.Contains(arg.Type, "run_sql") {
argByt, err := json.Marshal(arg.Args) argByt, err := json.Marshal(arg.Args)
if err != nil { if err != nil {
c.JSON(http.StatusInternalServerError, &Response{Code: "request_parse_error", Message: err.Error()}) c.JSON(http.StatusInternalServerError, &Response{Code: "request_parse_error", Message: err.Error()})