hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 01:12:56 +03:00
Code Issues Projects Releases Wiki Activity

use multiwayif instead of nested if-else

Browse Source
This commit is contained in:
Karthikeyan Chinnakonda 2020-08-21 16:21:55 +05:30
parent d4e2955ece
commit 22d563c3b6
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
server/src-lib/Hasura/RQL/DDL/RemoteRelationship/Validate.hs
View File

@ -415,15 +415,13 @@ isTypeCoercible actualType expectedType =
let (actualBaseType, actualNestingLevel) = getBaseTyWithNestedLevelsCount actualType
(expectedBaseType, expectedNestingLevel) = getBaseTyWithNestedLevelsCount expectedType
in
if actualBaseType == expectedBaseType
then if (actualNestingLevel == expectedNestingLevel || actualNestingLevel == 0)
-- The check of 'actualNestedCount == 0' is the case of coercing a singleton type
-- into an array type
then pure ()
else Failure (pure $ ExpectedTypeButGot expectedType actualType)
-- we cannot coerce two types with different nesting levels,
if | actualBaseType /= expectedBaseType -> raiseValidationError
-- we cannot coerce two types with different nesting levels,
-- for example, we cannot coerce [Int] to [[Int]]
else Failure (pure $ ExpectedTypeButGot expectedType actualType)
| (actualNestingLevel == expectedNestingLevel || actualNestingLevel == 0) -> pure ()
| otherwise -> raiseValidationError
where
raiseValidationError = Failure (pure $ ExpectedTypeButGot expectedType actualType)
assertListType :: G.GType -> Validation (NonEmpty ValidationError) ()
assertListType actualType =