cli: remove irrelevant flags from init command (close #4508) (#4549)

This commit is contained in:
Shraddha Agrawal 2020-04-25 11:33:13 +05:30 committed by GitHub
parent 41d3595aab
commit 38529b3960
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 14 deletions

View File

@ -4,7 +4,7 @@
### Bug fixes and improvements
(Remove this and start adding entries)
- cli: remove irrelevant flags from init command (close #4508) (#4549)
## `v1.2.0-beta.5`

View File

@ -68,12 +68,9 @@ func NewInitCmd(ec *cli.ExecutionContext) *cobra.Command {
f := initCmd.Flags()
f.Var(cli.NewConfigVersionValue(cli.V2, &opts.Version), "version", "config version to be used")
f.StringVar(&opts.InitDir, "directory", "", "name of directory where files will be created")
f.StringVar(&opts.MetadataDir, "metadata-directory", "metadata", "name of directory where metadata files will be created")
f.StringVar(&opts.Endpoint, "endpoint", "", "http(s) endpoint for Hasura GraphQL Engine")
f.StringVar(&opts.AdminSecret, "admin-secret", "", "admin secret for Hasura GraphQL Engine")
f.StringVar(&opts.AdminSecret, "access-key", "", "access key for Hasura GraphQL Engine")
f.StringVar(&opts.ActionKind, "action-kind", "synchronous", "kind to be used for an action")
f.StringVar(&opts.ActionHandler, "action-handler-webhook-baseurl", "http://localhost:3000", "webhook baseurl to be used for an action")
f.StringVar(&opts.Template, "install-manifest", "", "install manifest to be cloned")
f.MarkDeprecated("access-key", "use --admin-secret instead")
f.MarkDeprecated("directory", "use directory-name argument instead")
@ -88,10 +85,6 @@ type InitOptions struct {
Endpoint string
AdminSecret string
InitDir string
MetadataDir string
ActionKind string
ActionHandler string
Template string
}
@ -176,10 +169,10 @@ func (o *InitOptions) createFiles() error {
ServerConfig: cli.ServerConfig{
Endpoint: "http://localhost:8080",
},
MetadataDirectory: o.MetadataDir,
MetadataDirectory: "metadata",
ActionConfig: &types.ActionExecutionConfig{
Kind: o.ActionKind,
HandlerWebhookBaseURL: o.ActionHandler,
Kind: "synchronous",
HandlerWebhookBaseURL: "http://localhost:3000",
},
}
}

View File

@ -39,13 +39,10 @@ Options
::
--action-handler-webhook-baseurl string webhook baseurl to be used for an action (default "http://localhost:3000")
--action-kind string kind to be used for an action (default "synchronous")
--admin-secret string admin secret for Hasura GraphQL engine
--endpoint string http(s) endpoint for Hasura GraphQL engine
-h, --help help for init
--install-manifest string install manifest to be cloned
--metadata-directory string name of directory where metadata files will be created (default "metadata")
--version string config version to be used (default "2")
Options inherited from parent commands