hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-14 17:02:49 +03:00
Code Issues Projects Releases Wiki Activity

console: remove comments that contain internal doc links

Browse Source 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9978
GitOrigin-RevId: f16e82fe466039665abef1f633a82236f6288a43
This commit is contained in:
Vijay Prasanna 2023-07-28 13:48:43 +05:30 committed by hasura-bot
parent 102fc81fd1
commit 3aa56fc05f
3 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/libs/console/legacy-ce/src/lib/Globals.ts
View File

@ -136,9 +136,6 @@ export type CloudCliEnv = {
type ProCliEnv = CloudCliEnv;
type ProLiteCliEnv = CloudCliEnv;
// Until this non-discriminated-union-based `EnvVars` exist, please keep the following spreadsheet
// https://docs.google.com/spreadsheets/d/10feBESWKCfFuh7g9436Orp4i4fNoQxjnt5xxhrrdtJo/edit#gid=0
// updated with all the env vars that the Console receives and their possible values. The spreadsheet acts as the source of truth for the environment variables, at the moment
export type EnvVars = {
nodeEnv?: string;
apiHost?: string;

5
frontend/libs/console/legacy-ce/src/lib/docs/dev/analytics.stories.mdx
View File

@ -69,11 +69,6 @@ Currently
- All the sections of the Console redact everything for Heap (see the usage of `<Analytics />`, you can verify it by opening the devtools and looking for the `data-analytics-name` attribute used at section-containers level, here is an example ![The Console showing a section with the data redaction attributes](./images/storybook-assets/analytics/section-data-redaction.jpg 'Data redaction at the section level')
What we have to do
- One by one, we must refactor every section to stop exposing sensitive data (see here [the complete list of exposed data](https://docs.google.com/document/d/1bVXpz0p1k2os7lmvSuwDzQDUoYwGQ9thOyckcuI6Hgk))
- Then, we must remove the section-level data redaction
## Custom events
Custom events are helpful to

2
frontend/libs/console/legacy-ce/src/lib/features/Analytics/core/heap/getRedactAttributes.ts
View File

@ -3,8 +3,6 @@ import type { RedactOptions, HtmlRedactAttributes } from './types';
/**
* The options to use to redact every data from an HTML element.
*
* @see: the list of sensitive data in the DOM elements https://docs.google.com/document/d/1bVXpz0p1k2os7lmvSuwDzQDUoYwGQ9thOyckcuI6Hgk/edit#heading=h.c9iw8i7zh51x
*
* @deprecated It is meant for migrating from app-redaction to section-redaction, but must be removed
* when all the sections have been migrated to surgically redact only the components that contain sensitive data.
*/