hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-14 17:02:49 +03:00
Code Issues Projects Releases Wiki Activity

chore: remove isProLiteConsole function

Browse Source 
This PR reports back to main the changes discussed here: https://hasurahq.slack.com/archives/CKATHV1J7/p1685348635635059?thread_ts=1684879014.661199&cid=CKATHV1J7

TL;DR
- we created a isProConsole function and used it in isDynamicDBRoutingEnabled. We merged this on main
- we opened a cherry pick PR
- we figured out that the isProConsole misses the license key validation feature, so the function was not doing what the function name suggested.
- in the cherry pick PR we removed the generic isProConsole function (whose name was misleading) and replaced it with an inline console type check in the isDynamicDBRoutingEnabled. (the console type-only check is ok in that particular feature)

Since the last point happened only on the cherry-pick PR, we opened this PR to do the same on the main branch.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9368
GitOrigin-RevId: e358862e479ac2efa7268787ab2ca32d5a0994b5
This commit is contained in:
Daniele Cammareri 2023-06-13 10:20:49 +02:00 committed by hasura-bot
parent d3fd27d9db
commit 4a269b84fc
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/libs/console/legacy-ce/src/lib/utils/proConsole.ts
View File

@ -16,10 +16,6 @@ export const isProConsole = (env: ProConsoleEnv) => {
return false;
};
export const isProLiteConsole = (env: ProConsoleEnv) => {
return env.consoleType === 'pro-lite';
};
// Commented this function so that it's not used
// export const isProLiteConsole = (env: ProConsoleEnv) => {
// return env.consoleType === 'pro-lite';
@ -53,7 +49,7 @@ export const isImportFromOpenAPIEnabled = isProConsole;
export const isDynamicDBRoutingEnabled = isProConsole;
// isProConsole or isProLiteConsole
export const isCachingEnabled = (env: ProConsoleEnv) =>
isProConsole(env) || isProLiteConsole(env);
isProConsole(env) || env.consoleType === 'pro-lite';
export const isEEClassicConsole = () => {
return window.__env.eeMode || false;