tests: disable stringifyNumbers in tests

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6338 GitOrigin-RevId: d3819dfda342af2b70df00d49edfc05dfa9582f5
2024-12-14 17:02:49 +03:00 · 2022-10-13 13:18:06 +01:00 · 2022-10-13 13:18:06 +01:00 · 4e23afed8d
commit 4e23afed8d
parent b2f89f6685
33 changed files with 34 additions and 195 deletions
--- a/server/lib/api-tests/test/Test/LongIdentifiersSpec.hs
+++ b/server/lib/api-tests/test/Test/LongIdentifiersSpec.hs
@ -52,12 +52,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnv, _) ->
@ -92,12 +87,7 @@ spec = do
        [ (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Mutations/Delete/AllSpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Delete/AllSpec.hs
@ -41,12 +41,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Mutations/Delete/FieldSpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Delete/FieldSpec.hs
@ -40,12 +40,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Mutations/Delete/NestedFieldSpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Delete/NestedFieldSpec.hs
@ -41,12 +41,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Mutations/Delete/PrimaryKeySpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Delete/PrimaryKeySpec.hs
@ -41,12 +41,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Mutations/Insert/MultipleSpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Insert/MultipleSpec.hs
@ -40,12 +40,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Mutations/Insert/SingleSpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Insert/SingleSpec.hs
@ -40,12 +40,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Mutations/Update/FieldSpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Update/FieldSpec.hs
@ -41,12 +41,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Mutations/Update/PrimaryKeySpec.hs
+++ b/server/lib/api-tests/test/Test/Mutations/Update/PrimaryKeySpec.hs
@ -41,12 +41,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Postgres/JsonbSpec.hs
+++ b/server/lib/api-tests/test/Test/Postgres/JsonbSpec.hs
@ -38,12 +38,7 @@ spec =
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/AggregationSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/AggregationSpec.hs
@ -54,12 +54,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnv, _) ->
--- a/server/lib/api-tests/test/Test/Queries/Directives/IncludeAndSkipSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Directives/IncludeAndSkipSpec.hs
@ -65,12 +65,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/Directives/IncludeSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Directives/IncludeSpec.hs
@ -68,12 +68,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/Directives/SkipSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Directives/SkipSpec.hs
@ -68,12 +68,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/DirectivesSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/DirectivesSpec.hs
@ -65,12 +65,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/FilterSearchSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/FilterSearchSpec.hs
@ -67,12 +67,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/MultiColumnObjectRelationshipsSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/MultiColumnObjectRelationshipsSpec.hs
@ -66,12 +66,7 @@ spec = do
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv,
                  setupRelationships Fixture.Cockroach testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/NestedObjectSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/NestedObjectSpec.hs
@ -67,12 +67,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/Paginate/LimitSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Paginate/LimitSpec.hs
@ -67,12 +67,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/Paginate/OffsetSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Paginate/OffsetSpec.hs
@ -67,12 +67,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Queries/Simple/NoQueriesAvailableSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Simple/NoQueriesAvailableSpec.hs
@ -47,12 +47,7 @@ spec = do
                (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
                  { Fixture.setupTeardown = \(testEnv, _) ->
                      [ Cockroach.setupTablesAction tables testEnv
-                      ],
-                    Fixture.customOptions =
-                      Just $
-                        Fixture.defaultOptions
-                          { Fixture.stringifyNumbers = True
-                          }
+                      ]
                  },
                (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
                  { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Queries/Simple/ObjectQueriesSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Simple/ObjectQueriesSpec.hs
@ -49,12 +49,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Queries/Simple/OperationNameSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Simple/OperationNameSpec.hs
@ -46,12 +46,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnv, _) ->
--- a/server/lib/api-tests/test/Test/Queries/Simple/PrimaryKeySpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/Simple/PrimaryKeySpec.hs
@ -41,12 +41,7 @@ spec =
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Queries/SortSpec.hs
+++ b/server/lib/api-tests/test/Test/Queries/SortSpec.hs
@ -67,12 +67,7 @@ spec = do
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Schema/ConflictsSpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/ConflictsSpec.hs
@ -42,8 +42,7 @@ spec =
                Just $
                  Fixture.defaultOptions
                    { Fixture.skipTests =
-                        Just "Disabled until we can dynamically change server settings per test. To test, add EFHideUpdateManyFields to soSubscriptions in Harness.Constants -> serveOptions",
-                      Fixture.stringifyNumbers = True
+                        Just "Disabled until we can dynamically change server settings per test. To test, add EFHideUpdateManyFields to soSubscriptions in Harness.Constants -> serveOptions"
                    }
            }
        ]
--- a/server/lib/api-tests/test/Test/Schema/CustomFieldNames/MutationSpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/CustomFieldNames/MutationSpec.hs
@ -45,12 +45,7 @@ spec = do
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv,
                  setupTeardown testEnv Fixture.Cockroach
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnv, _) ->
--- a/server/lib/api-tests/test/Test/Schema/CustomFieldNames/QuerySpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/CustomFieldNames/QuerySpec.hs
@ -52,12 +52,7 @@ spec = do
            { Fixture.setupTeardown = \(testEnv, _) ->
                [ Cockroach.setupTablesAction schema testEnv,
                  setupTeardown testEnv Fixture.Cockroach
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnv, _) ->
--- a/server/lib/api-tests/test/Test/Schema/EnumSpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/EnumSpec.hs
@ -46,12 +46,7 @@ spec =
                        Cockroach.run_ teardown
                    },
                  Cockroach.setupTablesAction schema testEnvironment
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.Citus)
            { Fixture.setupTeardown = \(testEnvironment, _) ->
--- a/server/lib/api-tests/test/Test/Schema/TableRelationships/ArrayRelationshipsSpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/TableRelationships/ArrayRelationshipsSpec.hs
@ -39,12 +39,7 @@ spec = do
            },
          (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
-                [Cockroach.setupTablesAction schema testEnv],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                [Cockroach.setupTablesAction schema testEnv]
            },
          (Fixture.fixture $ Fixture.Backend Fixture.SQLServer)
            { Fixture.setupTeardown = \(testEnv, _) ->
--- a/server/lib/api-tests/test/Test/Schema/TableRelationships/ObjectRelationshipsSpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/TableRelationships/ObjectRelationshipsSpec.hs
@ -61,12 +61,7 @@ spec = do
    ( NE.fromList
        [ (Fixture.fixture $ Fixture.Backend Fixture.Cockroach)
            { Fixture.setupTeardown = \(testEnv, _) ->
-                [Cockroach.setupTablesAction schema testEnv],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                [Cockroach.setupTablesAction schema testEnv]
            }
        ]
    )
--- a/server/lib/api-tests/test/Test/Schema/ViewsSpec.hs
+++ b/server/lib/api-tests/test/Test/Schema/ViewsSpec.hs
@ -42,12 +42,7 @@ spec =
                [ Cockroach.setupTablesAction schema testEnvironment,
                  setupCockroach,
                  setupMetadata Fixture.Cockroach testEnvironment
-                ],
-              Fixture.customOptions =
-                Just $
-                  Fixture.defaultOptions
-                    { Fixture.stringifyNumbers = True
-                    }
+                ]
            }
        ]
    )
--- a/server/lib/test-harness/src/Harness/Constants.hs
+++ b/server/lib/test-harness/src/Harness/Constants.hs
@ -252,7 +252,7 @@ serveOptions =
      soConsoleAssetsDir = Just "../console/static/dist",
      soConsoleSentryDsn = Nothing,
      soEnableTelemetry = False,
-      soStringifyNum = Options.StringifyNumbers,
+      soStringifyNum = Options.Don'tStringifyNumbers,
      soDangerousBooleanCollapse = Options.Don'tDangerouslyCollapseBooleans,
      soEnabledAPIs = testSuiteEnabledApis,
      soLiveQueryOpts = ES.mkSubscriptionsOptions Nothing Nothing,