server: Add warning log for no admin secret

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5034
GitOrigin-RevId: 82498837c38c66882aa1cc7c78131aa965fe70ac

.circleci/test-server-flags.sh

@@ -96,12 +96,12 @@ kill_hge
 ###### Test --use-prepared-statements=true
 key="HGE$RANDOM$RANDOM"
 
-run_hge_with_flags --use-prepared-statements=true
+run_hge_with_flags --use-prepared-statements=true --admin-secret="$key"
 
 echoInfo "Test --use-prepared-statements=true"
+kill_hge
 grep -F '"use_prepared_statements":true' "$OUTPUT_FOLDER/graphql-engine.log" >/dev/null || (cat "$OUTPUT_FOLDER/graphql-engine.log" && false)
 
-kill_hge
 
 ######### Test HASURA_GRAPHQL_USE_PREPARED_STATEMENTS=abcd
 

CHANGELOG.md

@@ -4,6 +4,9 @@
 
 ### Bug fixes and improvements
 
+
+- server: add warning log for missing admin secret
+
 ## v2.10.0-beta.1
 
 ### Introducing Apollo Federation v1 support (experimental)

server/src-lib/Hasura/App.hs

@@ -327,6 +327,15 @@ initialiseServeCtx env GlobalCtx {..} so@ServeOptions {..} serverMetrics = do
   instanceId <- liftIO generateInstanceId
   latch <- liftIO newShutdownLatch
   loggers@(Loggers loggerCtx logger pgLogger) <- mkLoggers soEnabledLogTypes soLogLevel
+  when (null soAdminSecret) $ do
+    let errMsg :: Text
+        errMsg = "WARNING: No admin secret provided"
+    unLogger logger $
+      StartupLog
+        { slLogLevel = LevelWarn,
+          slKind = "no_admin_secret",
+          slInfo = A.toJSON errMsg
+        }
   -- log serve options
   unLogger logger $ serveOptsToLog so