hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-11-10 10:29:12 +03:00
Code Issues Projects Releases Wiki Activity

server/mssql: fix pytest class names for update mutations

Browse Source 
**TLDR**: Rename the pytest class names for update mutations by suffixing with `MSSQL` instead of `Mssql`.

We run the pytest in the CI using option `-k "MSSQL or Common"` which runs the test classes having `Common` or `MSSQL` in their name. Assuming the option `-k` to be case insensitive I named the update mutation test classes ending with `Mssql`. To confirm whether the CI is running the update mutation tests, I opened this PR with a commit making a test to fail and it is not reflected in the CI (all tests are passing!). I renamed the test classes with `MSSQL` as suffix. Now, the CI is able to capture the failing test as expected. Finally, the failing test is fixed.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3227
GitOrigin-RevId: 65b2b2bfbaca64c44ff7607148c32eb0c15e4956
This commit is contained in:
Rakesh Emmadi 2021-12-29 23:32:48 +05:30 committed by hasura-bot
parent 234a5385cd
commit 549a5a31f0
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/CONTRIBUTING.md
View File

@ -313,7 +313,10 @@ The current convention is to indicate the backend(s) tests can be run against in
This naming convention enables easier test filtering with [pytest command line flags](https://docs.pytest.org/en/6.2.x/usage.html#specifying-tests-selecting-tests).
The backend-specific and common test suites are disjoint; for example, run `pytest --integration -k "Common or MySQL" --backend mysql` to run all MySQL tests.
The backend-specific and common test suites are disjoint; for example, run `pytest --integration -k "Common or MySQL" --backend mysql** to run all MySQL tests.
**Note:** The `-k` option flag is case sensitive for pytest version(s) `< 5.4`. Until the pytest is [upgraded](https://github.com/hasura/graphql-engine-mono/issues/3236),
keywords `MySQL`, `MSSQL`, `Bigquery` and `Common` strictly be used for suffixing class names.
#### Building with profiling

4
server/tests-py/test_graphql_mutations.py
View File

@ -514,7 +514,7 @@ class TestGraphqlUpdatePermissions:
@pytest.mark.parametrize("backend", ['mssql'])
@use_mutation_fixtures
class TestGraphqlUpdateBasicMssql:
class TestGraphqlUpdateBasicMSSQL:
def test_set_author_name(self, hge_ctx):
check_query_f(hge_ctx, self.dir() + "/author_set_name_mssql.yaml")
@ -543,7 +543,7 @@ class TestGraphqlUpdateBasicMssql:
@pytest.mark.parametrize("backend", ['mssql'])
@use_mutation_fixtures
class TestGraphqlUpdatePermissionsMssql:
class TestGraphqlUpdatePermissionsMSSQL:
def test_user_update_author(self, hge_ctx):
check_query_f(hge_ctx, self.dir() + "/user_update_author_mssql.yaml")