hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-14 17:02:49 +03:00
Code Issues Projects Releases Wiki Activity

Make only one failing instance in each test (#678)

Browse Source 
<!-- Thank you for submitting this PR! :) -->

## Description

Very occasionally these tests fail with the wrong duplicated graphql
name. Not sure why, I assume some unpredictable HashMap ordering
somewhere. In lieu of changing all HashMaps to BTreeMaps in engine
(which isn't immediately possible because of missing `Ord` instances for
`serde_json::Value`), let's make only one set of failing items in these
tests so the same one goes wrong each time.

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 6dff998ae66aedbcca05dd05dc6fcb12e6d704c3
This commit is contained in:
Daniel Harvey 2024-06-06 12:03:27 +01:00 committed by hasura-bot
parent 49e0c79d9e
commit 560cc5755c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
v3/crates/engine/tests/validate_metadata_artifacts/metadata_with_scalar_comparison_type_reused.json
View File

@ -651,7 +651,7 @@
"dataConnectorScalarType": "String",
"representation": "String",
"graphql": {
"comparisonExpressionTypeName": "String_Comparison_Exp"
"comparisonExpressionTypeName": "String_Comparison_Exp_DB1"
}
}
},
@ -663,7 +663,7 @@
"dataConnectorScalarType": "String",
"representation": "String",
"graphql": {
"comparisonExpressionTypeName": "String_Comparison_Exp"
"comparisonExpressionTypeName": "String_Comparison_Exp_DB2"
}
}
},

4
v3/crates/engine/tests/validate_metadata_artifacts/metadata_with_scalar_comparison_type_reused_for_different_scalars.json
View File

@ -712,7 +712,7 @@
"dataConnectorScalarType": "String",
"representation": "String",
"graphql": {
"comparisonExpressionTypeName": "String_Comparison_Exp"
"comparisonExpressionTypeName": "String_Comparison_Exp_DB1"
}
}
},
@ -724,7 +724,7 @@
"dataConnectorScalarType": "String",
"representation": "String",
"graphql": {
"comparisonExpressionTypeName": "String_Comparison_Exp"
"comparisonExpressionTypeName": "String_Comparison_Exp_DB2"
}
}
},