mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-09-11 10:46:25 +03:00
Avoid building the engine twice when only running unit tests.
### Description When running the tests with `dev.sh`, we always build the engine, before attempting to run the tests. This builds the engine twice, due to the flag change. This PR changes this to only do this first build if we're planning to actually run the integration tests. https://github.com/hasura/graphql-engine-mono/pull/1964 GitOrigin-RevId: 32e8a6568f3665ad99adaf42421a711241974638
This commit is contained in:
parent
d185212c3e
commit
7720496b95
@ -443,16 +443,15 @@ elif [ "$MODE" = "test" ]; then
|
||||
export SCHEDULED_TRIGGERS_WEBHOOK_DOMAIN="http://127.0.0.1:5594"
|
||||
export REMOTE_SCHEMAS_WEBHOOK_DOMAIN="http://127.0.0.1:5000"
|
||||
|
||||
# It's better UX to build first (possibly failing) before trying to launch
|
||||
# PG, but make sure that new-run uses the exact same build plan, else we risk
|
||||
# rebuilding twice... ugh
|
||||
# Formerly this was a `cabal build` but mixing cabal build and cabal run
|
||||
# seems to conflict now, causing re-linking, haddock runs, etc. Instead do a
|
||||
# `graphql-engine version` to trigger build
|
||||
cabal new-run --project-file=cabal.project.dev-sh -- exe:graphql-engine \
|
||||
--metadata-database-url="$PG_DB_URL" version
|
||||
|
||||
if [ "$RUN_INTEGRATION_TESTS" = true ]; then
|
||||
# It's better UX to build first (possibly failing) before trying to launch
|
||||
# PG, but make sure that new-run uses the exact same build plan, else we risk
|
||||
# rebuilding twice... ugh
|
||||
# Formerly this was a `cabal build` but mixing cabal build and cabal run
|
||||
# seems to conflict now, causing re-linking, haddock runs, etc. Instead do a
|
||||
# `graphql-engine version` to trigger build
|
||||
cabal new-run --project-file=cabal.project.dev-sh -- exe:graphql-engine \
|
||||
--metadata-database-url="$PG_DB_URL" version
|
||||
start_dbs
|
||||
else
|
||||
# unit tests just need access to a postgres instance:
|
||||
|
Loading…
Reference in New Issue
Block a user