hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-11-10 18:50:52 +03:00
Code Issues Projects Releases Wiki Activity

Correct the names and references of various DC SQLite make targets.

Browse Source 
`spawn-dc-sqlite-agent` was incorrectly named, and the `start-dc-sqlite-agent` target was missing. In addition, we usually only make the `start-xyz` target public in `make help`, and so only that needs a comment.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5804
GitOrigin-RevId: 8064ce148d004ef73dbd8570ef30435423ede0a1
This commit is contained in:
Samir Talwar 2022-09-08 09:47:30 +02:00 committed by hasura-bot
parent 8d7c089273
commit 880f165b81
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
scripts/make/test-infrastructure.mk
View File

@ -126,25 +126,26 @@ spawn-dc-reference-agent:
docker compose up -d --build dc-reference-agent docker compose up -d --build dc-reference-agent
.PHONY: wait-for-dc-reference-agent .PHONY: wait-for-dc-reference-agent
## wait-for-dc-reference-agent: call health endpoint of DataConnector reference agent until it is ready
wait-for-dc-reference-agent: wait-for-dc-reference-agent:
$(DB_UTILS) wait_for_http_success $(DC_REFERENCE_AGENT_URL) "dc-reference-agent" $(DB_UTILS) wait_for_http_success $(DC_REFERENCE_AGENT_URL) "dc-reference-agent"
.PHONY: spawn-sqlite-reference-agent .PHONY: start-dc-sqlite-agent
spawn-sqlite-reference-agent: ## start-dc-sqlite-agent: start the Data Connectors SQLite agent in Docker and wait for it to be ready
start-dc-sqlite-agent: spawn-dc-sqlite-agent wait-for-dc-sqlite-agent
.PHONY: spawn-dc-sqlite-agent
spawn-dc-sqlite-agent:
docker compose up -d --build dc-sqlite-agent docker compose up -d --build dc-sqlite-agent
.PHONY: wait-for-dc-sqlite-agent .PHONY: wait-for-dc-sqlite-agent
## wait-for-dc-sqlite-agent: call health endpoint of DataConnector SQLite agent until it is ready
wait-for-dc-sqlite-agent: wait-for-dc-sqlite-agent:
$(DB_UTILS) wait_for_http_success $(DC_SQLITE_AGENT_URL) "dc-sqlite-agent" $(DB_UTILS) wait_for_http_success $(DC_SQLITE_AGENT_URL) "dc-sqlite-agent"
.PHONY: start-backends .PHONY: start-backends
## start-backends: start local PostgreSQL, MariaDB, and MS SQL Server in Docker and wait for them to be ready ## start-backends: start all known backends in Docker and wait for them to be ready
start-backends: \ start-backends: \
spawn-postgres spawn-sqlserver spawn-mysql spawn-citus spawn-dc-reference-agent spawn-dc-sqlite-agent spawn-cockroach\ spawn-postgres spawn-sqlserver spawn-mysql spawn-citus spawn-dc-reference-agent spawn-dc-sqlite-agent spawn-cockroach \
wait-for-postgres wait-for-sqlserver wait-for-mysql wait-for-citus wait-for-dc-reference-agent wait-for-cockroach\ wait-for-postgres wait-for-sqlserver wait-for-mysql wait-for-citus wait-for-dc-reference-agent wait-for-dc-sqlite-agent wait-for-cockroach
wait-for-dc-sqlite-agent wait-for-dc-reference-agent
.PHONY: stop-everything .PHONY: stop-everything
## stop-everything: tear down test databases ## stop-everything: tear down test databases