From 8ef270404a09ec52a946537aa839ab05e376636f Mon Sep 17 00:00:00 2001 From: Tirumarai Selvan Date: Tue, 5 Apr 2022 14:19:47 +0530 Subject: [PATCH] support for graphql-ws is considered GA PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4155 GitOrigin-RevId: 40033eb41849e88fc1b7a84a607ae9ce4abccf0b --- CHANGELOG.md | 1 + .../core/databases/ms-sql-server/subscriptions/index.mdx | 5 ++--- .../core/databases/postgres/subscriptions/index.mdx | 7 +++---- .../core/databases/ms-sql-server/subscriptions/index.rst | 4 ++-- .../core/databases/postgres/subscriptions/index.rst | 4 ++-- 5 files changed, 10 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 473e1832f22..f0841197394 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ - console: remove need for clicking the Modify btn before editing a remote schema (#1193, #8262) - cli: fix remote schema metadata formatting issues (#7608) - cli: fix query collections metadata formatting issues (#7616) +- docs: support for `graphql-ws` is considered GA ## v2.5.0-beta.1 diff --git a/docs-new/docs/graphql/core/databases/ms-sql-server/subscriptions/index.mdx b/docs-new/docs/graphql/core/databases/ms-sql-server/subscriptions/index.mdx index 4bbd1712e07..14e3fdbb55c 100644 --- a/docs-new/docs/graphql/core/databases/ms-sql-server/subscriptions/index.mdx +++ b/docs-new/docs/graphql/core/databases/ms-sql-server/subscriptions/index.mdx @@ -58,9 +58,8 @@ by the library and the [GraphQL over WebSocket Protocol](https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md) by the [graphql-ws](https://github.com/enisdenjo/graphql-ws) library for -sending and receiving events. The support for `graphql-ws` is currently -considered as `BETA`. The GraphQL engine uses the -`Sec-WebSocket-Protocol` header to determine the server Implementation +sending and receiving events. The GraphQL engine uses the +`Sec-WebSocket-Protocol` header to determine the communication protocol that'll be used. By default, the GraphQL engine will use the `apollographql/subscriptions-transport-ws` protocol. diff --git a/docs-new/docs/graphql/core/databases/postgres/subscriptions/index.mdx b/docs-new/docs/graphql/core/databases/postgres/subscriptions/index.mdx index 791b60d12bb..065cdf3c46d 100644 --- a/docs-new/docs/graphql/core/databases/postgres/subscriptions/index.mdx +++ b/docs-new/docs/graphql/core/databases/postgres/subscriptions/index.mdx @@ -52,11 +52,10 @@ Hasura GraphQL engine uses the [GraphQL over WebSocket Protocol](https://github. by the [apollographql/subscriptions-transport-ws](https://github.com/apollographql/subscriptions-transport-ws) library and the [GraphQL over WebSocket Protocol](https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md) by the [graphql-ws](https://github.com/enisdenjo/graphql-ws) library for -sending and receiving events. The support for `graphql-ws` is currently -considered as `BETA`. The GraphQL engine uses the -`Sec-WebSocket-Protocol` header to determine the server Implementation +sending and receiving events. The GraphQL engine uses the +`Sec-WebSocket-Protocol` header to determine the communication protocol that'll be used. By default, the GraphQL engine will use the -`apollographql/subscriptions-transport-ws` implementation. +`apollographql/subscriptions-transport-ws` protocol. :::info Setting headers for subscriptions with Apollo client diff --git a/docs/graphql/core/databases/ms-sql-server/subscriptions/index.rst b/docs/graphql/core/databases/ms-sql-server/subscriptions/index.rst index 60d372f13ce..7282fc74051 100644 --- a/docs/graphql/core/databases/ms-sql-server/subscriptions/index.rst +++ b/docs/graphql/core/databases/ms-sql-server/subscriptions/index.rst @@ -56,8 +56,8 @@ Hasura GraphQL engine uses the `GraphQL over WebSocket Protocol `__ by the `apollographql/subscriptions-transport-ws `__ library and the `GraphQL over WebSocket Protocol `__ -by the `graphql-ws `__ library for sending and receiving events. The support for -``graphql-ws`` is currently considered as ``BETA``. The GraphQL engine uses the ``Sec-WebSocket-Protocol`` header to determine +by the `graphql-ws `__ library for sending and receiving events. +The GraphQL engine uses the ``Sec-WebSocket-Protocol`` header to determine the server Implementation that'll be used. By default, the GraphQL engine will use the ``apollographql/subscriptions-transport-ws`` protocol. .. admonition:: Setting headers for subscriptions with Apollo client diff --git a/docs/graphql/core/databases/postgres/subscriptions/index.rst b/docs/graphql/core/databases/postgres/subscriptions/index.rst index 2b33c1b88f5..f7eb08ab0c6 100644 --- a/docs/graphql/core/databases/postgres/subscriptions/index.rst +++ b/docs/graphql/core/databases/postgres/subscriptions/index.rst @@ -54,8 +54,8 @@ Hasura GraphQL engine uses the `GraphQL over WebSocket Protocol `__ by the `apollographql/subscriptions-transport-ws `__ library and the `GraphQL over WebSocket Protocol `__ -by the `graphql-ws `__ library for sending and receiving events. The support for -``graphql-ws`` is currently considered as ``BETA``. The GraphQL engine uses the ``Sec-WebSocket-Protocol`` header to determine +by the `graphql-ws `__ library for sending and receiving events. +The GraphQL engine uses the ``Sec-WebSocket-Protocol`` header to determine the server Implementation that'll be used. By default, the GraphQL engine will use the ``apollographql/subscriptions-transport-ws`` implementation. .. admonition:: Setting headers for subscriptions with Apollo client