mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-14 17:02:49 +03:00
Check worker status before calling success callback
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10070 GitOrigin-RevId: e25c9fb5b89c4463766eca0909120d57b2b4c14f
This commit is contained in:
parent
6d3a426250
commit
95fcd44a45
@ -16,6 +16,7 @@ import Globals from '../../../../../../Globals';
|
||||
import {
|
||||
controlPlaneClient,
|
||||
FETCH_CONFIG_STATUS,
|
||||
FetchConfigStatusSubscription,
|
||||
} from '../../../../../../features/ControlPlane';
|
||||
|
||||
type HasuraDBCreationPayload = {
|
||||
@ -162,25 +163,37 @@ export function useCreateHasuraCloudDatasource(
|
||||
* If the change has not propagated to a worker to which the `pg_add_source` request is routed to,
|
||||
* the server would throw an `inconsistent_object` error as the new env var will not be found.
|
||||
*
|
||||
* To handle this, we wait for the changes to be propagated to all
|
||||
* To handle this, we wait for the changes to be propagated to all the live hasura
|
||||
* workers of a tenant before attempting to connect the DB.
|
||||
*
|
||||
* We do that by verifying that the new config hash has been set
|
||||
* for all workers of the tenant using the `config_status` table.
|
||||
* for all the live workers of the tenant using the `config_status` table
|
||||
*
|
||||
* Hash is compared against the `config_status` table and worker status
|
||||
* is checked against the `hasura_worker` table
|
||||
*
|
||||
* Additionally add a timeout interval with retries as an additional
|
||||
* redundancy since it throws CORS error locally
|
||||
*/
|
||||
const { unsubscribe } = controlPlaneClient.subscribe(
|
||||
const { unsubscribe } =
|
||||
controlPlaneClient.subscribe<FetchConfigStatusSubscription>(
|
||||
FETCH_CONFIG_STATUS,
|
||||
{
|
||||
tenantId: Globals.hasuraCloudTenantId,
|
||||
},
|
||||
data => {
|
||||
const configStatusData = data.hasura_worker
|
||||
.map(config_status_obj =>
|
||||
config_status_obj.config_statuses.map(
|
||||
config_data => config_data
|
||||
)
|
||||
)
|
||||
.flat(1);
|
||||
|
||||
if (
|
||||
// check if all workers are successfully configured with the new hash
|
||||
data.config_status.every(
|
||||
(config: { hash: string; message: string }) =>
|
||||
configStatusData.every(
|
||||
config =>
|
||||
config.message === 'Service configured successfully' &&
|
||||
config.hash !== oldConfigHash
|
||||
)
|
||||
|
@ -94,7 +94,7 @@ export const updateEnvVars = (
|
||||
if (response.errors) {
|
||||
throw new Error(response.errors[0]?.message);
|
||||
} else {
|
||||
return response.updateTenantEnv;
|
||||
return response.data.updateTenantEnv;
|
||||
}
|
||||
});
|
||||
})
|
||||
|
File diff suppressed because it is too large
Load Diff
@ -266,14 +266,11 @@ export const ADD_SCHEMA_REGISTRY_FEATURE_REQUEST = gql(`
|
||||
|
||||
export const FETCH_CONFIG_STATUS = gql(`
|
||||
subscription FetchConfigStatus($tenantId: uuid!) {
|
||||
config_status(
|
||||
where: {
|
||||
tenant_id: { _eq: $tenantId }
|
||||
is_active: { _eq: true }
|
||||
}
|
||||
) {
|
||||
hasura_worker(where: {config_statuses: {is_active: {_eq: true}, tenant_id: {_eq: $tenantId}}, status: {_eq: "live"}}) {
|
||||
config_statuses(where: {is_active: {_eq: true}, tenant_id: {_eq: $tenantId}}) {
|
||||
hash
|
||||
message
|
||||
worker_id
|
||||
}
|
||||
}
|
||||
`);
|
||||
}`);
|
||||
|
Loading…
Reference in New Issue
Block a user