hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-14 17:02:49 +03:00
Code Issues Projects Releases Wiki Activity

server: check for event triggers before throwing source-cleanup-failed warnings

Browse Source 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8885
GitOrigin-RevId: 7e02829608c6838f5db8226b532b436dd97f1b22
This commit is contained in:
paritosh-08 2023-04-25 01:20:48 +05:30 committed by hasura-bot
parent 8af30c4c6b
commit b158aae73b
2 changed files with 22 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/lib/api-tests/src/Test/API/Metadata/InconsistentSpec.hs
View File

@ -119,14 +119,6 @@ tests = do
`shouldReturnYaml` [yaml|
is_consistent: true
inconsistent_objects: []
warnings:
- code: source-cleanup-failed
message: >-
Could not cleanup the source '"postgres"' while dropping it from the graphql-engine as it is
inconsistent. Please consider cleaning the resources created by the graphql engine, refer
https://hasura.io/docs/latest/graphql/core/event-triggers/remove-event-triggers/#clean-footprints-manually
type: source
name: source postgres
|]
reloadMetadata :: Value

43
server/src-lib/Hasura/RQL/DDL/Metadata.hs
View File

@ -103,18 +103,19 @@ postDropSourceHookHelper ::
postDropSourceHookHelper oldSchemaCache sourceName sourceMetadataBackend = do
logger :: (HL.Logger HL.Hasura) <- asks getter
AB.dispatchAnyBackend @BackendMetadata sourceMetadataBackend \(_ :: SourceMetadata b) -> do
AB.dispatchAnyBackend @BackendMetadata sourceMetadataBackend \(oldSourceMetadata :: SourceMetadata b) -> do
let sourceInfoMaybe = unsafeSourceInfo @b =<< HM.lookup sourceName (scSources oldSchemaCache)
case sourceInfoMaybe of
Nothing -> do
let message =
"Could not cleanup the source '"
<> sourceName
<<> "' while dropping it from the graphql-engine as it is inconsistent."
<> " Please consider cleaning the resources created by the graphql engine,"
<> " refer https://hasura.io/docs/latest/graphql/core/event-triggers/remove-event-triggers/#clean-footprints-manually"
HL.unLogger logger $ MetadataLog HL.LevelWarn message J.Null
warn $ MetadataWarning WCSourceCleanupFailed (MOSource sourceName) message
unless (null (getTriggersMap oldSourceMetadata)) do
let message =
"Could not cleanup the source '"
<> sourceName
<<> "' while dropping it from the graphql-engine as it is inconsistent."
<> " Please consider cleaning the resources created by the graphql engine,"
<> " refer https://hasura.io/docs/latest/graphql/core/event-triggers/remove-event-triggers/#clean-footprints-manually"
HL.unLogger logger $ MetadataLog HL.LevelWarn message J.Null
warn $ MetadataWarning WCSourceCleanupFailed (MOSource sourceName) message
Just sourceInfo -> runPostDropSourceHook defaultSource sourceInfo
runClearMetadata ::
@ -475,18 +476,18 @@ runReplaceMetadataV2' ReplaceMetadataV2 {..} = do
flip catchError catcher do
sourceConfigMaybe <- askSourceConfigMaybe @b source
case sourceConfigMaybe of
Nothing -> do
-- TODO: Add user facing docs on how to drop triggers manually. Issue #7104
let message =
"Could not drop SQL triggers present in the source '"
<> source
<<> "' as it is inconsistent."
<> " While creating an event trigger, Hasura creates SQL triggers on the table."
<> " Please refer https://hasura.io/docs/latest/graphql/core/event-triggers/remove-event-triggers/#clean-up-event-trigger-footprints-manually "
<> " to delete the sql triggers from the database manually."
<> " For more details, please refer https://hasura.io/docs/latest/graphql/core/event-triggers/index.html "
warn $ MetadataWarning WCSourceCleanupFailed sourceObjID message
logger $ MetadataLog HL.LevelWarn message J.Null
Nothing ->
unless (null oldTriggersMap) do
let message =
"Could not drop SQL triggers present in the source '"
<> source
<<> "' as it is inconsistent."
<> " While creating an event trigger, Hasura creates SQL triggers on the table."
<> " Please refer https://hasura.io/docs/latest/graphql/core/event-triggers/remove-event-triggers/#clean-up-event-trigger-footprints-manually "
<> " to delete the sql triggers from the database manually."
<> " For more details, please refer https://hasura.io/docs/latest/graphql/core/event-triggers/index.html "
warn $ MetadataWarning WCSourceCleanupFailed sourceObjID message
logger $ MetadataLog HL.LevelWarn message J.Null
Just sourceConfig -> do
for_ droppedEventTriggers \triggerName -> do
-- TODO: The `tableName` parameter could be computed while building