hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 09:22:43 +03:00
Code Issues Projects Releases Wiki Activity

better name for resolve_data_connector_type_mappings in metadata resolver (#401)

Browse Source 
<!-- Thank you for submitting this PR! :) -->

## Description

Addressing
https://github.com/hasura/v3-engine/pull/398#discussion_r1538623981

V3_GIT_ORIGIN_REV_ID: 8f9c4f95fd2c57246693168c901640872b479741
This commit is contained in:
Daniel Harvey 2024-03-26 08:54:34 +00:00 committed by hasura-bot
parent 7dd3dfa235
commit b6f6d48027
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
v3/crates/engine/src/metadata/resolved/metadata.rs
View File

@ -126,7 +126,8 @@ pub fn resolve_metadata(metadata: open_dds::Metadata) -> Result<Metadata, Error>
> = HashMap::new();
// resolve object types
let data_connector_type_mappings = resolve_data_connector_type_mappings(
// TODO: make this return more values rather than blindly mutating it's inputs
let data_connector_type_mappings = resolve_data_connector_type_mappings_and_objects(
&metadata_accessor,
&data_connectors,
&mut types,
@ -297,8 +298,10 @@ fn resolve_data_connectors(
Ok(data_connectors)
}
/// resolve object types
fn resolve_data_connector_type_mappings(
/// resolve object types, matching them to that in the data connectors
/// this currently works by mutating `types` and `existing_graphql_types`, we should try
/// and change this to return new values here and make the caller combine them together
fn resolve_data_connector_type_mappings_and_objects(
metadata_accessor: &open_dds::accessor::MetadataAccessor,
data_connectors: &HashMap<Qualified<DataConnectorName>, DataConnectorContext>,
types: &mut HashMap<Qualified<CustomTypeName>, TypeRepresentation>,
@ -318,6 +321,7 @@ fn resolve_data_connector_type_mappings(
{
let qualified_object_type_name =
Qualified::new(subgraph.to_string(), object_type_definition.name.clone());
let mut resolved_type = resolve_object_type(
object_type_definition,
existing_graphql_types,