hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-14 17:02:49 +03:00
Code Issues Projects Releases Wiki Activity

Unify two getObject methods

Browse Source
This commit is contained in:
Auke Booij 2020-08-20 18:24:33 +02:00
parent 1a14acdc0f
commit bd6bb40355
1 changed files with 16 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
server/src-lib/Hasura/GraphQL/Schema/Remote.hs
View File

@ -191,7 +191,7 @@ remoteSchemaInterface schemaDoc defn@(G.InterfaceTypeDefinition description name
P.memoizeOn 'remoteSchemaObject defn do P.memoizeOn 'remoteSchemaObject defn do
subFieldParsers <- traverse (remoteField' schemaDoc) fields subFieldParsers <- traverse (remoteField' schemaDoc) fields
objs :: [Parser 'Output n ()] <- objs :: [Parser 'Output n ()] <-
traverse (getObject >=> remoteSchemaObject schemaDoc) possibleTypes traverse (getObject schemaDoc name >=> remoteSchemaObject schemaDoc) possibleTypes
-- In the Draft GraphQL spec (> June 2018), interfaces can themselves -- In the Draft GraphQL spec (> June 2018), interfaces can themselves
-- implement superinterfaces. In the future, we may need to support this -- implement superinterfaces. In the future, we may need to support this
-- here. -- here.
@ -202,15 +202,6 @@ remoteSchemaInterface schemaDoc defn@(G.InterfaceTypeDefinition description name
-- should have a check that expresses that that collection of objects is equal -- should have a check that expresses that that collection of objects is equal
-- to 'possibelTypes'. -- to 'possibelTypes'.
pure $ void $ P.selectionSetInterface name description subFieldParsers objs pure $ void $ P.selectionSetInterface name description subFieldParsers objs
where
getObject :: G.Name -> m G.ObjectTypeDefinition
getObject objectName =
onNothing (lookupObject schemaDoc objectName) $
case lookupInterface schemaDoc objectName of
Nothing -> throw400 RemoteSchemaError $ "Could not find type " <> squote objectName
<> ", which is defined as a member type of Union " <> squote name
Just _ -> throw400 RemoteSchemaError $ "Union type " <> squote name <>
" can only include object types. It cannot include " <> squote objectName
-- | 'remoteSchemaUnion' returns a output parser for a given 'UnionTypeDefinition'. -- | 'remoteSchemaUnion' returns a output parser for a given 'UnionTypeDefinition'.
remoteSchemaUnion remoteSchemaUnion
@ -221,19 +212,24 @@ remoteSchemaUnion
-> m (Parser 'Output n ()) -> m (Parser 'Output n ())
remoteSchemaUnion schemaDoc defn@(G.UnionTypeDefinition description name _directives objectNames) = remoteSchemaUnion schemaDoc defn@(G.UnionTypeDefinition description name _directives objectNames) =
P.memoizeOn 'remoteSchemaObject defn do P.memoizeOn 'remoteSchemaObject defn do
objDefs <- traverse getObject objectNames objDefs <- traverse (getObject schemaDoc name) objectNames
objs :: [Parser 'Output n ()] <- traverse (remoteSchemaObject schemaDoc) objDefs objs :: [Parser 'Output n ()] <- traverse (remoteSchemaObject schemaDoc) objDefs
when (null objs) $ when (null objs) $
throw400 RemoteSchemaError $ "List of member types cannot be empty for union type " <> squote name throw400 RemoteSchemaError $ "List of member types cannot be empty for union type " <> squote name
pure $ void $ P.selectionSetUnion name description objs pure $ void $ P.selectionSetUnion name description objs
where
getObject :: G.Name -> m G.ObjectTypeDefinition getObject
getObject objectName = :: MonadError QErr m
=> SchemaIntrospection
-> G.Name
-> G.Name
-> m G.ObjectTypeDefinition
getObject schemaDoc name objectName =
onNothing (lookupObject schemaDoc objectName) $ onNothing (lookupObject schemaDoc objectName) $
case lookupInterface schemaDoc objectName of case lookupInterface schemaDoc objectName of
Nothing -> throw400 RemoteSchemaError $ "Could not find type " <> squote objectName Nothing -> throw400 RemoteSchemaError $ "Could not find type " <> squote objectName
<> ", which is defined as a member type of Union " <> squote name <> ", which is defined as a member type of " <> squote name
Just _ -> throw400 RemoteSchemaError $ "Union type " <> squote name <> Just _ -> throw400 RemoteSchemaError $ "Type " <> squote name <>
" can only include object types. It cannot include " <> squote objectName " can only include object types. It cannot include " <> squote objectName
-- | remoteSchemaInputObject returns an input parser for a given 'G.InputObjectTypeDefinition' -- | remoteSchemaInputObject returns an input parser for a given 'G.InputObjectTypeDefinition'