hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-10-05 14:28:08 +03:00
Code Issues Projects Releases Wiki Activity

Revise function-root-field-customisation.md

Browse Source 
### Description
* Removed unresolved questions since resolved
* Change status 'draft' → 'published'

### Changelog

- [X] `no-changelog-required` .

### Related Issues

fix https://github.com/hasura/graphql-engine/issues/7405

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2496
GitOrigin-RevId: 0bdba7f5d52f2a4bd70c525dab12698e9ceddb28
This commit is contained in:
Philip Lykke Carlsen 2021-10-04 13:39:05 +02:00 committed by hasura-bot
parent 648c566d0b
commit c839fc55df
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
rfcs/function-root-field-customisation.md
View File

@ -11,7 +11,7 @@ authors:
Philip Lykke Carlsen <philip@hasura.io>
discussion:
https://github.com/hasura/graphql-engine/issues/7405
state: draft
state: published
---
```
@ -79,18 +79,7 @@ interfere with any other features.
### Unresolved Questions
We need an API for updating this configuration from the console.
For table configuration, it is done through `set_table_customization` so we need
something similar to that for functions too. I'm wondering if it makes sense to
just add `replace_if_exists` key to `track_function` API instead of a
`set_function_customization` API.
Amending the the `FunctionConfiguration` with new fields also introduces these
fields to the deprecated `track_function` (v2) in the `/v1/query` API. Is this
a problem?
Is there any overlap with the work in https://github.com/hasura/graphql-engine-mono/pull/1616
that needs to be considered?
None. See linked discussion for historically unresolved questions.
## How