hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-12 14:05:16 +03:00
Code Issues Projects Releases Wiki Activity

Allow 14 digit prefixes for migration directories during `hasura scri…

Browse Source 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/11092
GitOrigin-RevId: 4c0b0adc92cb85827eb60849b43aa86591da0819
This commit is contained in:
Sandeep Raj Kumar 2024-11-25 21:51:25 +05:30 committed by hasura-bot
parent e3d3029b54
commit d72fea0e48
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cli/internal/scripts/update-project-v3.go
View File

@ -294,7 +294,7 @@ func getMatchingFilesAndDirs(fs afero.Fs, parentDir string, matcher func(string)
func isHasuraCLIGeneratedMigration(dirPath string) (bool, error) { func isHasuraCLIGeneratedMigration(dirPath string) (bool, error) {
var op errors.Op = "scripts.isHasuraCLIGeneratedMigration" var op errors.Op = "scripts.isHasuraCLIGeneratedMigration"
const regex = `^([0-9]{13})_(.*)$` const regex = `^([0-9]{13,14})_(.*)$`
match, err := regexp.MatchString(regex, filepath.Base(dirPath)) match, err := regexp.MatchString(regex, filepath.Base(dirPath))
if err != nil { if err != nil {
return match, errors.E(op, err) return match, errors.E(op, err)

18
cli/internal/scripts/update-project-v3_test.go
View File

@ -59,6 +59,24 @@ func Test_checkIfDirectoryIsMigration(t *testing.T) {
false, false,
require.NoError, require.NoError,
}, },
{
"can check if a directory name is a valid migration, 14 chars",
args{
dirPath: "16048559649031_test",
},
true,
false,
require.NoError,
},
{
"can check if a directory name is a valid migration, 15 chars",
args{
dirPath: "160485596490312_test",
},
false,
false,
require.NoError,
},
} }
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {