server: add "SET check_function_bodies=false" in pg_dump clean output

GitOrigin-RevId: f0526f9666c3986d8e3b374556859043f10dbe8d

CHANGELOG.md

@@ -8,6 +8,7 @@
 - server: add 'replace_configuration' option (default: false) in the add source API payload
 - server: add a comment field for actions (#231)
 - server: accept GeoJSON for MSSQL geometry and geography operators (#787)
+- server: update pg_dump clean output to disable function body validation in create function statements to avoid errors due to forward references
 - server: fix a bug preventing some MSSQL foreign key relationships from being tracked
 - console: add a comment field for actions (#231)
 

docs/graphql/core/api-reference/pgdump.rst

@@ -69,6 +69,7 @@ Sample response
   HTTP/1.1 200 OK
   Content-Type: application/sql
 
+  SET check_function_bodies = false;
   CREATE TABLE public.author (
       id integer NOT NULL,
       name text NOT NULL

server/src-lib/Hasura/Server/API/PGDump.hs

@@ -82,7 +82,6 @@ execPGDump b ci = do
       , "SET client_encoding = 'UTF8';"
       , "SET standard_conforming_strings = on;"
       , "SELECT pg_catalog.set_config('search_path', '', false);"
-      , "SET check_function_bodies = false;"
       , "SET xmloption = content;"
       , "SET client_min_messages = warning;"
       , "SET row_security = off;"

server/tests-py/pgdump/pg_dump_public.yaml

@@ -1,3 +1,5 @@
+# Test output of pg_dump clean output.
+# Including "SET check_function_bodies = false;" avoids https://github.com/hasura/graphql-engine-mono/issues/1007
 descriptions: Execute pg_dump on public schema
 url: /v1alpha1/pg_dump
 status: 200
@@ -11,6 +13,7 @@ query:
   clean_output: true
 # response on postgres 9.4 and 9.5
 response_9: |
+  SET check_function_bodies = false;
   CREATE TABLE public.articles (
       id integer NOT NULL,
       author_id integer NOT NULL,
@@ -45,6 +48,7 @@ response_9: |
       ADD CONSTRAINT articles_author_id_fkey FOREIGN KEY (author_id) REFERENCES public.authors(id);
 # response on postgres 10 and 11
 response_10_11: |
+  SET check_function_bodies = false;
   CREATE TABLE public.articles (
       id integer NOT NULL,
       author_id integer NOT NULL,