hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 01:12:56 +03:00
Code Issues Projects Releases Wiki Activity

feature(server): CockroachDB now supports distinct. Document and test

Browse Source 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8596
GitOrigin-RevId: 3dbc5fccb1d4387041a5a80794158c4f50b70848
This commit is contained in:
Gil Mizrahi 2023-04-03 14:49:46 +03:00 committed by hasura-bot
parent c08dc03d72
commit ed4f3b7406
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/docs/databases/postgres/cockroachdb/hasura-cockroachdb-compatibility.mdx
View File

@ -29,9 +29,8 @@ Currently, the following features are supported with CockroachDB and Hasura:
## Queries ## Queries
Queries are fully supported except for queries containing `distinct_on` arguments, [see issue](https://github.com/cockroachdb/cockroach/issues/90763), but please note that GraphQL key Queries are fully supported, but please note that GraphQL key ordering in JSON objects is not guaranteed.
ordering in JSON objects is not guaranteed. This is because CockroachDB implements the `JSONB` variant of the Postgres This is because CockroachDB implements the `JSONB` variant of the Postgres JSON types, which do not preserve key ordering.
JSON types, which do not preserve key ordering.
Please also note that SERIAL columns will produce numbers that overflow JavaScript numbers. These will need special Please also note that SERIAL columns will produce numbers that overflow JavaScript numbers. These will need special
treatment by either enabling the treatment by either enabling the

6
server/lib/api-tests/src/Test/Queries/DistinctSpec.hs
View File

@ -10,6 +10,7 @@ import Data.Aeson (Value)
import Data.List.NonEmpty qualified as NE import Data.List.NonEmpty qualified as NE
import Harness.Backend.BigQuery qualified as BigQuery import Harness.Backend.BigQuery qualified as BigQuery
import Harness.Backend.Citus qualified as Citus import Harness.Backend.Citus qualified as Citus
import Harness.Backend.Cockroach qualified as Cockroach
import Harness.Backend.Postgres qualified as Postgres import Harness.Backend.Postgres qualified as Postgres
import Harness.GraphqlEngine (postGraphql) import Harness.GraphqlEngine (postGraphql)
import Harness.Quoter.Graphql (graphql) import Harness.Quoter.Graphql (graphql)
@ -36,6 +37,11 @@ spec = do
[ Citus.setupTablesAction schema testEnv [ Citus.setupTablesAction schema testEnv
] ]
}, },
(Fixture.fixture $ Fixture.Backend Cockroach.backendTypeMetadata)
{ Fixture.setupTeardown = \(testEnv, _) ->
[ Cockroach.setupTablesAction schema testEnv
]
},
(Fixture.fixture $ Fixture.Backend BigQuery.backendTypeMetadata) (Fixture.fixture $ Fixture.Backend BigQuery.backendTypeMetadata)
{ Fixture.setupTeardown = \(testEnv, _) -> { Fixture.setupTeardown = \(testEnv, _) ->
[ BigQuery.setupTablesAction schema testEnv [ BigQuery.setupTablesAction schema testEnv