This is a small continuation of this PR. It got merged before I could get these additional fixes in:
https://github.com/hasura/graphql-engine-mono/pull/6561
This PR addresses:
- Issues correctly merging custom root fields when saving that resulted in saved changes sometimes not saving
- Implements a fix @vijayprasanna13 made to issues with saving custom column names in a slightly refactored version of the same concept.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6575
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: 161ad46a8c667e022447a89aca057fd7f07379a7
This installs the ODBC Driver 18 for SQL Server in all our shipped Docker images, and update our tests and documentation accordingly.
This version supports arm64, and therefore can run natively (or via Docker) on macOS on aarch64.
`msodbcsql17` is still installed in production-targeted Docker images so that users do not _have_ to migrate to the new driver.
Nix expressions are packaged for the new driver, as it is not yet available in nixpkgs.
In this version, [the default encryption setting was changed from "no" to "yes"](https://techcommunity.microsoft.com/t5/sql-server-blog/odbc-driver-18-0-for-sql-server-released/ba-p/3169228). In addition, "mandatory" and "optional" were added as synonyms for "yes" and "no" respectively.
I have therefore modified all connection strings in tests to specify `Encrypt=optional` (and changed some from `Encrypt=no`). I chose "optional" rather than "no" because I feel it's more honest; these connection strings will work with or without an encrypted connection.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6241
GitOrigin-RevId: 959f88dd1f271ef06a3616bc46b358f364f6cdfd
Adds a browse rows component for GDC sources
Cleans up the implementation of the FilterSection and additonal refactoring
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6178
GitOrigin-RevId: 82c3f729edb05778e81b08254608797617b45aaf
## Description 🔖
This adds the ability to edit **GraphQL Field Customization** when either connecting or editing a db connection for an agent.
This was implemented using the newest form and form components:
<img width="548" alt="Screen Shot 2022-09-29 at 3 42 16 PM" src="https://user-images.githubusercontent.com/49927862/193155139-c0eb71fb-4829-42d9-8ec1-90582fe8054a.png">
## Solution and Design 🎨
This is a fairly minimal addition that makes use of the existing `react-hook-form` compatible `Form` and components. I had to edit the zod schema with the correct properties from the spec for GQL Sources.
I created a new dir for the `CustomizationForm` and implemented it in both the Connect and Edit components.
A quick note on a directory convention I am using here:
It's fairly common to have a components folder, and then within that, have sub-directories for more complicated components.
In that model, I have found it useful to use a `parts` directory as a next level of granularity within a component directory.
This helps to avoid cluttered components folder, by optionally adding a `parts` folder inside a component's folder for pieces that you want to break out but are NOT shared with anything else.
I've done this here with a fairly simple component `src/features/ConnectDB/components/Customization/parts/SectionHeader.tsx`, but one that benefits from having it's own component.
## Review Setup 💻
Video of feature:
https://www.loom.com/share/d737afca4be04da28f6943c1c8164d6f
### Tests
Added new customization form to storybook here ->> http://localhost:6006/?path=/story/data-connect-graphql-field-customization--primary
### Note on commit history
We had some issues trying to fix my accidental commital of a package-lock.json file and ended up doing some song and dance which involved @solomon-b ending up with credit for the first few commits. Just as a note for history, his name is on them, but it's my code, so if there's something to comment on, direct it to me.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6134
Co-authored-by: Solomon <24038+solomon-b@users.noreply.github.com>
GitOrigin-RevId: 0c8891e246e5d048e70b6a8a91331f21049d1c8c
