hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 17:31:56 +03:00
Code Issues Projects Releases Wiki Activity
6,726 Commits 138 Branches 441 Tags 4.4 GiB
3509ef8afc
Commit Graph

949 Commits

Author SHA1 Message Date
Antoine Leblanc
3a400fab3d Rewrite OpenAPI 
### Description

This PR rewrites OpenAPI to be more idiomatic. Some noteworthy changes:
- we accumulate all required information during the Analyze phase, to avoid having to do a single lookup in the schema cache during the OpenAPI generation phase (we now only need the schema cache as input to run the analysis)
- we no longer build intermediary endpoint information and aggregate it, we directly build the the `PathItem` for each endpoint; additionally, that means we no longer have to assume that different methods have the same metadata
- we no longer have to first declare types, then craft references: we do everything in one step
- we now properly deal with nullability by treating "typeName" and "typeName!" as different
- we add a bunch of additional fields in the generated "schema", such as title
- we do now support enum values in both input and output positions
- checking whether the request body is required is now performed on the fly rather than by introspecting the generated schema
- the methods in the file are sorted by topic

### Controversial point

However, this PR creates some additional complexity, that we might not want to keep. The main complexity is _knot-tying_: to avoid lookups when generating the OpenAPI, it builds an actual graph of input types, which means that we need something similar to (but simpler than) `MonadSchema`, to avoid infinite recursions when analyzing the input types of a query. To do this, this PR introduces `CircularT`, a lesser `SchemaT` that aims at avoiding ever having to reinvent this particular wheel ever again.

### Remaining work

- [x] fix existing tests (they are all failing due to some of the schema changes)
- [ ] add tests to cover the new features:
  - [x] tests for `CircularT`
  - [ ] tests for enums in output schemas
- [x] extract / document `CircularT` if we wish to keep it
- [x] add more comments to `OpenAPI`
- [x] have a second look at `buildVariableSchema`
- [x] fix all missing diagnostics in `Analyze`
- [x] add a Changelog entry?

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4654
Co-authored-by: David Overton <7734777+dmoverton@users.noreply.github.com>
GitOrigin-RevId: f4a9191f22dfcc1dccefd6a52f5c586b6ad17172
 2022-06-30 12:57:09 +00:00
Vishnu Bharathi
b4f9626b00 ci: tag release v2.8.3 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4915
Co-authored-by: Divi <32202683+imperfect-fourth@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: e7f5372829b8bb4d84f30b20c4cd488f516389d1
 2022-06-30 10:57:25 +00:00
Vishnu Bharathi
331ae6ab56 ci: tag release v2.8.2 and v2.8.2-pro.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4899
GitOrigin-RevId: 5e1aa15b8fc1c744d7f9362596ac0d31d5235a2a
 2022-06-29 13:54:48 +00:00
Abby Sassel
9d93baa96f server/postgres: parameterise array variables in queries/subscriptions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4776
Co-authored-by: Tom Harding <6302310+i-am-tom@users.noreply.github.com>
Co-authored-by: Brandon Martin <40686+codedmart@users.noreply.github.com>
GitOrigin-RevId: ca962e3bfaa28ef00c5d04273d6604348d7da1c8
 2022-06-29 13:37:11 +00:00
Brandon Martin
5e29a1304d Revert "Add _cast support for other postgres datatypes fix #6050 and … 
…fix #5426"

This reverts commit f85742318167d1e51f463c45fcd00f26269c2555.

## Description ✍️
With this commit there is the possiblity that you could get conflicting
type definitions with remote schemas. Reverting for now as we determine
a solution. At which point we will add this back in.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4879
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
GitOrigin-RevId: 932b4a9226717c826d4bde7e375695354cee8c0c
 2022-06-29 12:09:40 +00:00
Lyndon Maydwell
ab8369bdcf PG SSL-cert maybe fields 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4767
GitOrigin-RevId: 042fa622c6f208cf72fee40acee28e87ebcf1f67
 2022-06-28 01:26:03 +00:00
Rakesh Emmadi
7634be3216 server: fix dropping column from a table that has update permissions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4840
GitOrigin-RevId: cea142fe225315f4f4094f157d8a95df14273306
 2022-06-27 10:02:23 +00:00
hasura-bot
92f601587c cli: use 2-spaces indent for graphql query in metadata (fix #8469) 
GITHUB_PR_NUMBER: 8519
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8519

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4544
Co-authored-by: Yudai Shinnoki <2777896+shinnoki@users.noreply.github.com>
Co-authored-by: Divi <32202683+imperfect-fourth@users.noreply.github.com>
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: 3d9f9d1bf940e528a1ad9fab67b6ae818927ffac
 2022-06-27 05:27:19 +00:00
Karthikeyan Chinnakonda
db5d0b1d93 User facing docs for disabling root fields 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4616
Co-authored-by: Auke Booij <164426+abooij@users.noreply.github.com>
Co-authored-by: Marion Schleifer <5722022+marionschleifer@users.noreply.github.com>
GitOrigin-RevId: e4fc23245c6d4e53b8e355a858b2ab335348beba
 2022-06-23 13:16:54 +00:00
Varun Choudhary
866164357c console: support naming convention in source customization for postgres DB [CON-297] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4823
GitOrigin-RevId: a6a3bfcb9c7e16dd551d14dde3d424d07b8f1d15
 2022-06-23 06:51:16 +00:00
Benoit Ranque
e6614db17b console: Hide timescaledb internal schema from data tab 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4439
Co-authored-by: Sooraj <8408875+soorajshankar@users.noreply.github.com>
GitOrigin-RevId: 49c746e8d23b87363462942d4823c7ab9de2744e
 2022-06-22 07:38:38 +00:00
paritosh-08
98d899d4ba server: add update_source API and extend add_source to edit source customization 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4705
Co-authored-by: Rakesh Emmadi <12475069+rakeshkky@users.noreply.github.com>
GitOrigin-RevId: d185f19c88c4030075522d001fdbc0bafa66db8f
 2022-06-22 07:07:28 +00:00
Vishnu Bharathi
6b71746afd ci: tag release v2.8.1 and v2.9.0-beta.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4805
Co-authored-by: Daniel Harvey <4729125+danieljharvey@users.noreply.github.com>
Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 10c5557319c7f106c251c308efee6c135edc3fcd
 2022-06-21 10:10:10 +00:00
Philip Lykke Carlsen
6a15d3ea5f Fix zendesk-5146. Add check for empty columns in unique constraints g… 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4764
GitOrigin-RevId: 79e62f1ea2639ec81a48f5f71b58eaadf4fe6482
 2022-06-17 07:49:20 +00:00
Sooraj
b099ee5d66 console: add new table relationships tab to console 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4582
Co-authored-by: Matt Hardman <28978422+mattshardman@users.noreply.github.com>
GitOrigin-RevId: 3b362076a60b2dee73ee84945de23a0e7c1bcef0
 2022-06-16 18:11:38 +00:00
Daniel Harvey
249cbb914e server: Replace ValidationT with ExceptT in ParseT (close #3641) 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4712
GitOrigin-RevId: 6acfd8dc2276962d333c68ac85a7a729e87b6d2d
 2022-06-16 09:54:09 +00:00
Naveen Naidu
2526dd0114 server: fix create event trigger failure on tables with MSSQL reserved keywords as name 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4648
GitOrigin-RevId: 5e3eb614350b047f2e2384fea9b234bf0ad9d47f
 2022-06-15 17:11:44 +00:00
Rakesh Emmadi
b4534c1177 server/bigquery: apply LIMIT to computed field subqueries 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4694
GitOrigin-RevId: 9a0b7dd4afa5257b12b9e0e02e26b2ca6d283c9d
 2022-06-15 16:31:46 +00:00
Divi
c668aa1158 cli: improve error reporting in metadata apply command 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4454
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: ae66bdfdc140c1a2a7747fb0ff2acd6f7b577d3f
 2022-06-15 15:45:38 +00:00
Abhijeet Khangarot
132dffe4cf console: add support for mssql event triggers 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4558
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: 003710bc198caaf32a0c982d59aee9046d92aaf8
 2022-06-15 14:56:37 +00:00
Vishnu Bharathi
f96b5462ff ci: tag release v2.8.0 and v2.8.0-pro.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4732
GitOrigin-RevId: cc258aff48eed06ab2b2086f71c5e5220f608038
 2022-06-15 13:59:02 +00:00
Divi
b50aecdae4 cli: fix perfomance regression with large metadata in metadata apply 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4661
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: 48050e899592878c47c382281605a0c8666ddc8b
 2022-06-15 12:39:43 +00:00
Luca Restagno
31fb04e201 console: GQL field customization while adding databases 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4703
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: Daniel Harvey <4729125+danieljharvey@users.noreply.github.com>
GitOrigin-RevId: 885d7f9c459a0eb1e01f534a859465552ae76343
 2022-06-15 11:09:40 +00:00
Gil Mizrahi
5dd3f71539 server/telemetry: support multiple sources 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4493
GitOrigin-RevId: 3b34ea0aa6f78fa43c8d372d8b61d49191632eff
 2022-06-15 08:03:31 +00:00
Rikin Kachhia
7d8fa3a5ee console: add support for computed fields with session arg in permission builder 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4417
GitOrigin-RevId: 5fc528c9a3ab87a885ad2b85c3b2bde557ab6a22
 2022-06-13 06:53:14 +00:00
Benoit Ranque
525361d3d2 escape sql underscores in LIKE expressions (close #8435) 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4596
GitOrigin-RevId: 48f143b8e6bbc60371656cc4bfbae1a5864f9921
 2022-06-08 18:54:19 +00:00
Brandon Simmons
6e8da71ece server: migrate to aeson-2 in preparation for ghc 9.2 upgrade 
(Work here originally done by awjchen, rebased and fixed up for merge by
jberryman)

This is part of a merge train towards GHC 9.2 compatibility. The main
issue is the use of the new abstract `KeyMap` in 2.0. See:
https://hackage.haskell.org/package/aeson-2.0.3.0/changelog

Alex's original work is here:
#4305

BEHAVIOR CHANGE NOTE: This change causes a different arbitrary ordering
of serialized Json, for example during metadata export. CLI users care
about this in particular, and so we need to call it out as a _behavior
change_ as we did in v2.5.0. The good news though is that after this
change ordering should be more stable (alphabetical key order).

See: https://hasurahq.slack.com/archives/C01M20G1YRW/p1654012632634389

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4611
Co-authored-by: awjchen <13142944+awjchen@users.noreply.github.com>
GitOrigin-RevId: 700265162c782739b2bb88300ee3cda3819b2e87
 2022-06-08 15:32:27 +00:00
Vishnu Bharathi
af20404ac0 ci: tag release v2.8.0-beta.1 and v2.8.0-beta.1-pro.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4659
Co-authored-by: Tirumarai Selvan <8663570+tirumaraiselvan@users.noreply.github.com>
GitOrigin-RevId: 85914a11c339d9d77f265da702e38d3f9f46ff59
 2022-06-08 08:31:09 +00:00
Philip Lykke Carlsen
3e33fd6ff7 Make on_conflict schema available abstract of update permissions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4390
GitOrigin-RevId: 5f3f9da173cad37f9330c5a27fd1edfc2559a4d6
 2022-06-07 23:25:48 +00:00
Naveen Naidu
0817d46f1a server: log details of healthcheck failure 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4634
GitOrigin-RevId: 9a0c2ecd3db3fba15e352c9318127a82a36ac52b
 2022-06-07 11:24:20 +00:00
Karthikeyan Chinnakonda
d905911eab server: disable query/subscription root fields 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4524
Co-authored-by: Auke Booij <164426+abooij@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 1cae7a1596825925da9e82c2675507482f41c3fb
 2022-06-07 05:33:12 +00:00
Puru Gupta
ebc8cd5134 server: do not serialize env vars in logs or errors: PR III - Event Triggers 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4521
Co-authored-by: Naveen Naidu <30195193+Naveenaidu@users.noreply.github.com>
Co-authored-by: Brandon Simmons <210815+jberryman@users.noreply.github.com>
GitOrigin-RevId: c7702e8f3da466dc108936328de30ceb87df258a
 2022-06-05 20:28:13 +00:00
Aravind K P
384756f7be cli: support multiple admin secrets 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4566
GitOrigin-RevId: b03008099ec0b053fd24798b2b78d12471ed6fdd
 2022-06-03 13:29:56 +00:00
pranshi06
056765578f server: add support for custom scalar in action output types 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4185
GitOrigin-RevId: 16a24fdcdbd195b4b59bcca7957c469ba073dabb
 2022-06-03 09:48:26 +00:00
hasura-bot
e48f3cbef1 Add _cast support for other postgres datatypes fix #6050 and fix #5426 
GITHUB_PR_NUMBER: 8524
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8524

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4551
Co-authored-by: Abdullah Saleem <5978905+abdullah2993@users.noreply.github.com>
Co-authored-by: Abby Sassel <3883855+sassela@users.noreply.github.com>
GitOrigin-RevId: f85742318167d1e51f463c45fcd00f26269c2555
 2022-06-01 16:41:49 +00:00
Naveen Naidu
11867b50a4 server: extend backend_only setting for update and delete permissions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4530
Co-authored-by: Karthikeyan Chinnakonda <15602904+codingkarthik@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: c4c1a3bd9736ec275e77c6f55c76049c550443f9
 2022-05-31 14:42:14 +00:00
pranshi06
cd0f674821 server: Adds support to return array of scalars in Actions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3661
GitOrigin-RevId: bc37e7aa0cb861069536aa97aa4dff1fdc05e08b
 2022-05-31 05:23:47 +00:00
Rakesh Emmadi
af6eb1232e server/bigquery: computed fields SQL generation and execution 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4555
GitOrigin-RevId: c668cb6bd76ed646b9449d8037c2f9038c99e3a8
 2022-05-30 15:24:33 +00:00
Abhijeet Khangarot
b09bb602bd console: add support for application/x-www-form-urlencoded in rest connectors 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4354
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 44dc48f3f226c57aac4393133245bf70d5f68acd
 2022-05-30 13:51:15 +00:00
Gil Mizrahi
ae0dae0eed fix insertion of multiple empty objects 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4583
GitOrigin-RevId: a4eebf7d734c6556c2509ac66ccafbdb520189ba
 2022-05-30 12:18:36 +00:00
paritosh-08
42da1dbc2e server/docs: follow up on the naming convention 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4563
GitOrigin-RevId: 0ae1f226a63dae34e6cb0d001b4915c05b0974cf
 2022-05-27 05:56:52 +00:00
Gil Mizrahi
2b3d7c407b server/mssql: drop the temp table after delete 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4562
GitOrigin-RevId: f5f5815d9e2f58912a294cf564cfdc38995263d3
 2022-05-26 15:21:54 +00:00
paritosh-08
fd30fb343b server: naming conventions for auto generated fields 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3982
Co-authored-by: Brandon Simmons <210815+jberryman@users.noreply.github.com>
GitOrigin-RevId: f90b2e8f394e7bd69780f003d2d980475f104f42
 2022-05-26 11:55:29 +00:00
Vishnu Bharathi
0d1f1aad9a ci: tag release v2.7.0 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4553
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 6b822051ab9b72b2de93a0367a8fedaef544fab3
 2022-05-25 10:55:59 +00:00
Daniel Chambers
9e5f860a29 server: Default SourceMetadata's kind to Postgres Vanilla 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4514
Co-authored-by: David Overton <7734777+dmoverton@users.noreply.github.com>
GitOrigin-RevId: 37572758c3722a85ac005f5bd13a9bf6a407bad4
 2022-05-24 04:16:44 +00:00
Puru Gupta
5501f686df server: do not serialize env vars in logs or errors: PR I - Remote Schemas 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4463
Co-authored-by: Naveen Naidu <30195193+Naveenaidu@users.noreply.github.com>
Co-authored-by: Brandon Simmons <210815+jberryman@users.noreply.github.com>
GitOrigin-RevId: 71c6824130d71312f5bd5ae94fc268c0544c6ca3
 2022-05-21 09:05:59 +00:00
Vishnu Bharathi
b6eb71ae07 ci: tag release for v2.6.2 and v2.7.0-beta.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4499
GitOrigin-RevId: 8c4c6256ea953c55f8db03460e32d0a775d0d2ea
 2022-05-12 17:45:42 +00:00
Abhijeet Khangarot
936ee990c2 console: fix console crash on adding pg sources with connection params 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4485
GitOrigin-RevId: 00230fd2563fae9dcbdc03af5927dfeb1a82b965
 2022-05-12 12:15:53 +00:00
Gil Mizrahi
cd38a9a1fc server/postgres + server/mssql: Insert empty objects with default values 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4487
Co-authored-by: Abby Sassel <3883855+sassela@users.noreply.github.com>
GitOrigin-RevId: 3413f0b5dbe6ec42fff360d83b5202e4aa4aa86e
 2022-05-11 16:01:57 +00:00
Karthikeyan Chinnakonda
ce9912ff8c server: run_sql to not drop the SQL triggers created by the graphql-engine 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4397
GitOrigin-RevId: dcd43fc31f64af8c6c9c92c66d46a593d5b12fbd
 2022-05-10 13:47:16 +00:00
Vijay Prasanna
db07dcf60d console: new "add remote schema" page (with GQL customization) 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4428
GitOrigin-RevId: d8f82ffe86fd59abb43afa195b40c2fdafabb847
 2022-05-10 11:32:32 +00:00
Antoine Leblanc
697137dd77 Fix Postgres not padding timestamps correctly (fix hasura/graphql-engine#8096) 
## Description

As identified in hasura/graphql-engine#8096, the format string we used for timestamps was incorrect; we were using `%F`, which expands to `%Y-%m-%d`; but that meant that the year was not padded to four digits: `0001` would be represented simply as `1`. However, Postgres inteprets that `1` as `2001`, probably due to interpretation rules about two-digit years (in `25/12/01`, `01` is indeed `2001`).

```
# create table timestamp_test ( test timestamptz );
CREATE TABLE
# insert into timestamp_test values ('1-01-01T00:00:57Z');
INSERT 0 1
# select * from timestamp_test;
          test
------------------------
 2001-01-01 00:00:57+00
(1 row)
```

To fix this, this PR changes the format string to use `%0Y`, which always pads the year number with zeroes.

## Remaining work

- [x] write Changelog entry
- [ ] copy timestamp tests from the python suite into the hspec tests

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3536
GitOrigin-RevId: fa144111358339fd4a35b32d888c1d2c5b418ea6
 2022-05-09 12:18:18 +00:00
Vishnu Bharathi
9c90bb0b2c ci: tag release v2.5.2 and v2.6.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4430
GitOrigin-RevId: 9080dac0ffa75558401716ed8b437d63ff1d82c1
 2022-05-03 09:36:04 +00:00
Brandon Martin
5008b54813 Update CHANGELOG for known issue v2.6.0/v2.5.1 
## Description ✍️
Update CHANGELOG for known issue v2.6.0/v2.5.1

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4409
GitOrigin-RevId: ae22b1b9e1845de48859be56af83426ee8556c9f
 2022-05-02 13:31:01 +00:00
Naveen Naidu
955db8ab11 server: Use quote_ident for quoting table name when using regclass 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4413
Co-authored-by: Karthikeyan Chinnakonda <15602904+codingkarthik@users.noreply.github.com>
GitOrigin-RevId: 721fae15587bdab6f27b8d1189fe6e41c42097e7
 2022-05-02 13:16:55 +00:00
Varun Choudhary
bdaa6c38b9 console: allow users to remove prefix / suffix / root field namespace from a remote schema 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4379
GitOrigin-RevId: afdf4246c711c6972d7f33365cf98b75c1e6f78e
 2022-05-02 06:24:22 +00:00
Lyndon Maydwell
53ca4da79d Fixing URL parameter for variable <name> not supported bug in REST endpoints for Dates 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4345
GitOrigin-RevId: 0b739530757ee1081d764d9582e3c0e648861d4e
 2022-05-02 03:34:34 +00:00
Alberto Francesco Motta
b21d1c0495 changelog: update for v2.6.0 release 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4385
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
GitOrigin-RevId: b61cbd40163568cbc5f550ff9ed3157f5c0b474b
 2022-04-28 08:46:55 +00:00
Vishnu Bharathi
d78f6df534 ci: tag release v2.6.0 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4377
GitOrigin-RevId: defb105c8c21216db47285521ce3034c523e6c0a
 2022-04-27 10:12:15 +00:00
Rakesh Emmadi
6611fbd625 server/mssql: avoid encoding varchar values while generating SQL 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4314
GitOrigin-RevId: 852bc941782414c7d190c6195ff367493b927639
 2022-04-26 13:48:37 +00:00
Vijay Prasanna
c2ab5854f9 console: bug fixes for RS-to-RS relationships 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4357
Co-authored-by: Abhijeet Khangarot <26903230+abhi40308@users.noreply.github.com>
Co-authored-by: Matt Hardman <28978422+mattshardman@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: a695071a42a921e36082d99af110323298cb5569
 2022-04-26 12:31:50 +00:00
Vishnu Bharathi
0016d3cad5 cli: avoid exporting hasura-specific schemas during hasura init 
fixes https://github.com/hasura/graphql-engine/issues/8352

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4178
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: eff7067c34932435207eff794f9435356b55b666
 2022-04-25 13:06:52 +00:00
Karthikeyan Chinnakonda
3aa2cf5064 server: streaming subscriptions v1 (docs only) 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2948
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: Brandon Simmons <210815+jberryman@users.noreply.github.com>
Co-authored-by: paritosh-08 <85472423+paritosh-08@users.noreply.github.com>
GitOrigin-RevId: 9c02d34a525141fa41e894596f236525822dd1e0
 2022-04-25 07:56:16 +00:00
Vishnu Bharathi
7a6e38bd0a ci: tag release v2.5.1 and v2.6.0-beta.2 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4325
GitOrigin-RevId: 4b1aa341fe1feffcdb3e14e0465b191eab6e0204
 2022-04-21 14:13:40 +00:00
Aravind K P
23f32c3db4 cli: fix performance regression in v2.5.0 
closes https://github.com/hasura/graphql-engine/issues/8398

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4313
GitOrigin-RevId: 3f24434b8256ec30838ce0014a04f8dfdca7f0d5
 2022-04-21 11:55:12 +00:00
Naveen Naidu
abb57e58c8 server/MSSQL: Event Delivery System (Incremental PR - 3) 
</details>

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3392
Co-authored-by: Divi <32202683+imperfect-fourth@users.noreply.github.com>
GitOrigin-RevId: 9df6b0aa7d91f22571b72d3e467da23b916c9140
 2022-04-21 07:20:34 +00:00
Vamshi Surabhi
1ca0cb9c74 Fixes remote relationships on actions 
Fixes: https://github.com/hasura/graphql-engine/issues/8399. See [this comment](https://github.com/hasura/graphql-engine-mono/pull/4297/files#r853259983) for an explanation.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4297
Co-authored-by: Brandon Martin <40686+codedmart@users.noreply.github.com>
GitOrigin-RevId: accc85a77cb108224b1c78da709dc96d0e4e298d
 2022-04-19 17:49:57 +00:00
Sibi Prabakaran
a687e7419e Fix BigDecimal/BigNumeric serialization for BigQuery backend 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4268
GitOrigin-RevId: 0158ad7ef4e6b34de7a350f8bbbdc0255c9187e3
 2022-04-19 11:37:48 +00:00
Abhijeet Khangarot
d2f50e2a7e console: CON-135 add remote db relationships for views 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4286
GitOrigin-RevId: dee2f77557754d854368b9a7fad3c4173865cdcc
 2022-04-18 12:16:55 +00:00
hasura-bot
22120a026c don't drop nested typed null fields in actions (fix #8237) 
GITHUB_PR_NUMBER: 8238
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8238

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4272
Co-authored-by: Jesse Jaara <294363+Huulivoide@users.noreply.github.com>
Co-authored-by: Lyndon Maydwell <92299+sordina@users.noreply.github.com>
GitOrigin-RevId: 810ec935a1e1c75a06a1ad1427dedb179eb60d5e
 2022-04-18 09:59:16 +00:00
Vishnu Bharathi
810db83499 ci: use pg_dump from postgres 14 
fixes https://github.com/hasura/graphql-engine/issues/7676

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4254
GitOrigin-RevId: ca27952516bd60605c27254fce7f5267f472d9d5
 2022-04-18 06:25:02 +00:00
Sibi Prabakaran
74328156c5 Fix Decimal serialization for BigQuery backend 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4168
GitOrigin-RevId: 16072ce326ede22ba8be05f92fcfa0aaa2a7a644
 2022-04-13 17:09:45 +00:00
Rakesh Emmadi
503f22ba87 fix parsing remote relationship json definition from 1.x server catalog on migration 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4260
GitOrigin-RevId: c5a634ec7275d1cbee0bcda5ada9b21ae874f098
 2022-04-13 16:08:28 +00:00
Vishnu Bharathi
bf6c91c7c7 ci: tag release v2.5.0 and v2.6.0-beta.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4257
Co-authored-by: Alberto Francesco Motta <36401353+afmotta@users.noreply.github.com>
GitOrigin-RevId: 6dbed1919a8b5bd521aa76a16d460fc11bfc5fcc
 2022-04-13 08:49:28 +00:00
Vijay Prasanna
2811490a67 console: allow users to create bigquery-to-RS and mssql-to-RS relationships 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4244
Co-authored-by: Alberto Francesco Motta <36401353+afmotta@users.noreply.github.com>
GitOrigin-RevId: 996709ddbc7504b143f46379dd91c117729c771e
 2022-04-13 07:22:09 +00:00
Auke Booij
4a7bd4edcd Update hasura/pool to avoid a resource leak 
See hasura/pool#7

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4253
GitOrigin-RevId: 6e88870d05339ed5f466cce13ba6add3cb755d78
 2022-04-12 14:30:34 +00:00
Matt Hardman
1f1749a230 console: allow RS-to-DB edit & delete [CON-99] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4229
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: 3c06ecfb14137e7314518821ccc56ba53f92ee6d
 2022-04-12 13:36:17 +00:00
Naveen Naidu
bdff49fd55 server: redact sensitive info from logs for metadata queries 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4072
GitOrigin-RevId: 8e6043878ec4b4f073744614ddc9c7046ca93c82
 2022-04-11 17:50:22 +00:00
Vijay Prasanna
fd0f10f589 console: enable bigquery as an option in RS-to-DB remote joins 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4233
GitOrigin-RevId: 9ca1006d200b18f8dfeb37475b7e0df0a05fc8c9
 2022-04-11 16:56:07 +00:00
Alberto Francesco Motta
e1443981d4 [CON-130] Add a feature flag for RS relationships tab 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4184
GitOrigin-RevId: d96a64571bdbe52fd96b0a1a92cd883dbbb27d28
 2022-04-11 14:58:23 +00:00
Abhijeet Khangarot
99878d9c00 console: enable mssql for db-to-remoteDb and RS-to-DB relationships 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4243
GitOrigin-RevId: fe0f7e5d8f562ec0fae5204facd289f6a32346a5
 2022-04-11 14:01:18 +00:00
Naveen Naidu
d10b862b61 server: fix bugs in clear_metadata code path 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3927
Co-authored-by: Divi <32202683+imperfect-fourth@users.noreply.github.com>
Co-authored-by: Karthikeyan Chinnakonda <15602904+codingkarthik@users.noreply.github.com>
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
GitOrigin-RevId: 6f3457698029af94e9157c23b552ac2034f9c740
 2022-04-11 11:25:13 +00:00
Rakesh Emmadi
d561024254 server/postgres/citus: fix inserting values into columns with case sensitive enum types 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4196
GitOrigin-RevId: bbb9e565bc7143080eb1c50ade86b0e47b751387
 2022-04-11 08:05:25 +00:00
Vamshi Surabhi
bafd5be2b2 enable remote relationship metadata APIs on SQLServer 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4187
GitOrigin-RevId: 3e2a7734198df7758fc75610f4bcbd8e65a1c9de
 2022-04-07 15:48:49 +00:00
Sooraj
419b19c9e7 Integrate the RS-to-RS form into Remote Schema Relationship tab [CON-98] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4107
Co-authored-by: Matt Hardman <28978422+mattshardman@users.noreply.github.com>
Co-authored-by: Abhijeet Khangarot <26903230+abhi40308@users.noreply.github.com>
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
GitOrigin-RevId: 32a21e0733fbaeb82a0870bdabbe0122f9382d96
 2022-04-07 13:27:35 +00:00
hasura-bot
4c1c4cd773 fix(console): actions search case insensitive (close #6351) 
GITHUB_PR_NUMBER: 8368
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8368

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4144
Co-authored-by: Alex Parra <10448714+alex-parra@users.noreply.github.com>
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
Co-authored-by: Alberto Francesco Motta <36401353+afmotta@users.noreply.github.com>
GitOrigin-RevId: ea782e59e9e1a7ded032aa3821012dfaa2aa34db
 2022-04-06 09:21:21 +00:00
Evie Ciobanu
42480ee902 server: X -> MSSQL remote joins 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4097
GitOrigin-RevId: f39b82bac26f6ade83bd4f5e996dc26f5e048365
 2022-04-06 07:20:10 +00:00
Auke Booij
dfd09159ec Fix JSON encoding issue (fix hasura/graphql-engine#7543 and hasura/graphql-engine#8200) 
`encJFromAssocList` is broken since it does not appropriately escape the keys of the JSON dictionaries. Presumably it should.

This is a hotfix for a JSON encoding issue. Longer-term solutions are being discussed in hasura/graphql-engine-mono#3736.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4139
GitOrigin-RevId: 27afff319d268a4ec017c8eafd694cc17c2fd7f0
 2022-04-05 19:11:30 +00:00
Rakesh Emmadi
3f36b7c956 server/mssql: fix SQL generation for check constraints with relationships (fix #8225) 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4136
GitOrigin-RevId: 5fe54fe2118ac0309f5ed39696214f9b22768edf
 2022-04-05 10:10:32 +00:00
Tirumarai Selvan
8ef270404a support for graphql-ws is considered GA 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4155
GitOrigin-RevId: 40033eb41849e88fc1b7a84a607ae9ce4abccf0b
 2022-04-05 08:50:57 +00:00
Rikin Kachhia
bdd76adc74 console: remove need for clicking Modify before editing remote schema 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4092
Co-authored-by: hasura-bot <30118761+hasura-bot@users.noreply.github.com>
GitOrigin-RevId: b318e4d8f7c3d94a4b0aa5b55db9847e66cb6004
 2022-04-05 06:06:20 +00:00
Vijay Prasanna
d850086479 console: add RS-to-DB (only postgres & citus) relationships feature to remote schemas tab [CON-96] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4123
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
GitOrigin-RevId: 23c897b33d9051046ecf8a8837489318dd822c20
 2022-04-04 19:37:16 +00:00
Antoine Leblanc
b4f7e96665 Rewrite GraphQL.Analysis 
### Motivation

While we strive to write clear code, we have historically struggled at Hasura with having very different styles and standards across the codebase. There's been efforts to standardize our coding style, we have an official styleguide that isn't maintained as closely as it should... We still have some work in front of us.

However, in the last ~year or so, there's been a huge push towards incrementally improving the situation. As part of this we've been blocking PRs that don't add enough comments, or don't improve the files that they touch.

While looking at `Hasura.GraphQL.Analyse`, it became apparent that this file did not meet the engineering standards that I would expect to see addressed during a code review. Some ways in which I think it falls short:
- lack of documentation
- no clear distinction between public / internal components
- "unidiomatic" Haskell code (such as using `Either Result Error`)

While there's no problem with a file looking like this during development, those issues should have been caught at review time. The fact that they weren't indicates a problem in our process that we will need to address: code quality and maintainability is paramount, and we all need to do our part.

### Description

This PR rewrites all of `Hasura.GraphQL.Analyze`, and adapts `Hasura.Server.OpenAPI` accordingly where needed. I've attempted to clarify names and add documentation based on my understanding of the code, and to clean what was unused (such as field variables). I don't think this PR is good enough as is, and I welcome criticism where I got my comments wrong / am happy to help y'all add more.

This PR makes one small change in the way error messages are reported (and adjusts the corresponding test accordingly); each error message is now prefixed with the path within the selection set:
```
⚠️ $.test.foo.bar.baz.mizpelled: field 'mizpelled' not found in object 'Baz'
```

### Note

This PR is currently **on top of #3962**. You can preview the changes in isolation by [diffing the branches](https://github.com/hasura/graphql-engine-mono/compare/nicuveo/clean-rest-endpoint-inconsistency-check..nicuveo/rewrite-analysis).

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3963
Co-authored-by: paritosh-08 <85472423+paritosh-08@users.noreply.github.com>
GitOrigin-RevId: 5ec38e0e753f0c12096a350db0737658495e2f15
 2022-04-04 05:54:59 +00:00
Aravind K P
e46777b7ea cli: fix formatting errors in query collection metadata 
closes https://github.com/hasura/graphql-engine/issues/7616
closes https://github.com/hasura/graphql-engine/issues/8205

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3955
GitOrigin-RevId: dc97e23e78d522cb7ac4d57ad825526eaa90a4de
 2022-03-31 14:02:49 +00:00
Rikin Kachhia
127bdcdf5c console: enable mssql aggregation query permissions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4125
GitOrigin-RevId: c57c1f6cff409033ec8e73297ddcc8235cf71d52
 2022-03-31 12:39:19 +00:00
Aravind K P
649ef41e3c cli: fix remote schema formatting errors in metadata 
closes https://github.com/hasura/graphql-engine/issues/7608
closes https://github.com/hasura/graphql-engine/issues/7459

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3951
GitOrigin-RevId: bad3505c79fab10453580a6a43ad7e71bc2d3753
 2022-03-31 08:28:30 +00:00
Rakesh Emmadi
22a5ebf287 server/bigquery: improve throwing upstream exceptions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4095
GitOrigin-RevId: e19ffe058aaffa1cfa8d155f2e3a6ecafd6aab13
 2022-03-30 13:54:18 +00:00
Vishnu Bharathi
a3c707b718 ci: tag release v2.4.0 and v2.5.0-beta.1 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4106
GitOrigin-RevId: 83594358cf511e7b5e1cd7d48a28e3e397a20682
 2022-03-30 07:33:44 +00:00
Rikin Kachhia
cb75226cf1 update changelog for v2.5.0-beta 
<!-- Thank you for ss in the Title above ^ -->

## Description ✍️
<!-- Please fill this se-->
<!-- Describe the changes from a user's perspective -->

update changelog

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4099
Co-authored-by: Tirumarai Selvan <8663570+tirumaraiselvan@users.noreply.github.com>
GitOrigin-RevId: 5ac6a6bd36f2d0ebf7bd6873a0ea1d297fb92fe1
 2022-03-30 04:03:19 +00:00
Daniel Chambers
5873429e54 console: Improved computed field comment support [CON-94] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3946
Co-authored-by: Sooraj <8408875+soorajshankar@users.noreply.github.com>
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
GitOrigin-RevId: dfedf0f76c008b958630f66b58a59530e567a23d
 2022-03-29 09:21:28 +00:00