hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-15 01:12:56 +03:00
Code Issues Projects Releases Wiki Activity
5,868 Commits 138 Branches 441 Tags 4.4 GiB
570e16efe7
Commit Graph

1284 Commits

Author SHA1 Message Date
Vijay Prasanna
941179bfee fix (console): handle case sensitive SQL generation for table schema and names 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7224
GitOrigin-RevId: cbfa88a278282bcf12a5d19219093a34d93c830c
 2022-12-13 08:08:41 +00:00
Matthew Goodwin
bffdc2f930 console: refactor modify tab metadata hooks [GDC-666] 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7165
GitOrigin-RevId: b46408b3395198ac84f62eeae31a6bde3133c65f
 2022-12-12 18:47:22 +00:00
Rikin Kachhia
8eb24229f9 console: move header navbar tooltips to bottom 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7193
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: a2002d9f58e3b2a7f3f873caa34e9a1da24b5393
 2022-12-12 13:29:15 +00:00
Luca Restagno
5e0bbc80de console: support alloydb 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6764
Co-authored-by: Erik Magnusson <32518962+ejkkan@users.noreply.github.com>
GitOrigin-RevId: 091525fd86342df5371e8545bba6ebff31132d53
 2022-12-12 12:13:44 +00:00
Sooraj
df5c946174 console: import generated types in actions 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6313
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
Co-authored-by: Daniele Cammareri <5709409+dancamma@users.noreply.github.com>
GitOrigin-RevId: f522eef50e37412f2ae84f63efa08c32848ccc93
 2022-12-09 18:13:39 +00:00
Brandon Martin
c0aa2e8773 super-connector: Add display_name to super-connector 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7182
GitOrigin-RevId: 30c896a7ef52c44e90c324a4b2bb9fc5668863fa
 2022-12-08 21:24:54 +00:00
Vijay Prasanna
e1064c34e0 feature (console): View browse rows relationships for GDC tables (WIP) 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6875
GitOrigin-RevId: d905d84c3cf21790415ec22294e1efabaf93f185
 2022-12-07 14:53:13 +00:00
Nicolas Inchauspe
fec3707e2e GraphiQL style bugs 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7172
GitOrigin-RevId: 8381852fd0c9ac22dce22911d933b446f6e8de59
 2022-12-06 19:30:22 +00:00
Sameer Kolhar
dc065cb98d console: hotfix minor issues in Check Database Latency feature 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7176
GitOrigin-RevId: 8f86ee64d44c67bbea0ccfead14d0bc2cd92b03a
 2022-12-06 17:28:08 +00:00
Julian@Hasura
4aee57b174 console: Use custom display name for drivers in dropdown - GDC-653 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7098
Co-authored-by: Julian <843342+okjulian@users.noreply.github.com>
GitOrigin-RevId: cf92d6c9c5d5116ce5b0ce972e859308afe886c2
 2022-12-06 12:59:05 +00:00
Varun Choudhary
d10591daf3 console: add negative badge to show inconsistent remote schema 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7067
GitOrigin-RevId: 6eeae6945639e98fda9ab90ff05a6af5fc668454
 2022-12-06 10:57:46 +00:00
Rishichandra Wawhal
7f0e4b2092 console: hide onboarding for users who onboarded before onboarding was launched 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7168
GitOrigin-RevId: 8e119129b2a910fefd692e93a19007cdfd564bf5
 2022-12-06 06:10:34 +00:00
Luca Restagno
1ce631132a console: fix scenario in which data is not ready yet 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7161
GitOrigin-RevId: 4b03fba03b2c1b8a4d855d2db852e8ce4f82d579
 2022-12-05 15:23:51 +00:00
Gil Mizrahi
f45c379866 add concurrent_bulk api for parallel processing of read-only queries 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7087
Co-authored-by: Tom Harding <6302310+i-am-tom@users.noreply.github.com>
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: 0d7a212d004908bc014def9d3828647545c9e062
 2022-12-05 13:50:19 +00:00
Matthew Goodwin
12d4de57c0 console: Revisions to #6931 
For context: https://github.com/hasura/graphql-engine-mono/pull/6931

This PR makes some revisions that I had originally intended to be in the code, but due to some mixup, was refactored without discussion. @vijayprasanna13 and I synced up to try and make a decision about how to resolve it, but ultimately wanted to get more eyes on it to weigh in.

For context, when I refer to "premade selectors" I am talking about [this file](8a9264b14c/console/src/features/hasura-metadata-api/selectors.ts (L34))

And when I refer to "utility functions" (or metadata utility functions), I am talking about [this file](8a9264b14c/console/src/features/hasura-metadata-api/utils.ts (L38))

The changes I am suggesting here mostly about maintaining (IMHO) clearer separation of concern for selectors vs utility functions, and improving DX.

Here's how I see it high level:

![flows (light theme)](https://user-images.githubusercontent.com/49927862/204630900-aca2aad1-d760-409d-8ec6-446942b2d6ff.png#gh-light-mode-only)
![flows (dar theme)](https://user-images.githubusercontent.com/173663/204755227-e8850dbf-1012-4c7b-8087-dd6f16e5ca23.jpg#gh-dark-mode-only)

In other words, I want to avoid using pre-made selectors within a custom selector as it creates a pattern of multiple layers of curried functions and beings to (IMHO) look confusing and blur the separation of concern.

What I am proposing is that we have a convention of doing either

1) Developer wants the entire table object of a specific table. They can easily do this using one of the **premade** selectors and pass directly into `useMetdata()`:

```ts
const { isLoading, data: metadataTable } = useMetadata(
    MetadataSelectors.findTable(dataSourceName, table)
  );
```

2) Developer wants to get a specific piece of information on a specific table. They can leverage the `findMetadataTable()` utility function within a custom inline selector like this and avoid extra currying and double selector confusion:

  ```ts
const { isLoading, data: savedComment } = useMetadata(
    m => MetadataUtils.findMetadataTable(dataSourceName, table, m)?.configuration?.comment
  );
```

This is somewhat of a stylistic preference, but also one that I think makes a cleaner separation of concern in the way we are building the api and supportive pieces. In other words, premade selectors are _always_ a selector and not used to compose other selectors. It also makes available utility functions that are easy to pull of the shelf to do common metadata tasks whether in the scope of `useMetadata` or not.

## Simpler Approach?

We could also just go with **Flow # 2** and eliminate the premade selectors. The dev would then pass a custom selector into `useMetadata()` and if they prefer, use a utility function to support their task.

With that aside, whatever the team agrees makes more sense, I will gladly get on board with, but I wanted to make my case here : )

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7095
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: 7ecc2db172def0d2f714cbbb2f95a4b56a528093
 2022-12-02 18:28:40 +00:00
Erik Magnusson
ffdc9ceca8 console: fix clone value handling for the insert tab 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7097
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: 483ce76f24234f76f3b557c892c62d891e542eb7
 2022-12-02 10:55:56 +00:00
Abhijeet Khangarot
1d9d48a165 console: update heap custom tracking event names 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7115
GitOrigin-RevId: 4017f0aec418d78f24f78e0a5b0cc28faa7b45d8
 2022-12-01 05:28:38 +00:00
Erik Magnusson
e084126c73 console: upgrade nudging for oss users wanting to use ssl cockroach db 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7084
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: 4706cb52d46e22cfd3396233e6222f83dbc43cf7
 2022-11-30 11:42:15 +00:00
sfarqu
5b95e4f778 console: Remove x-hasura-admin-secret header from DB latency requests 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7101
GitOrigin-RevId: 48dd66ded2cfd7c440db67f8edb267196757c75c
 2022-11-30 07:19:14 +00:00
Sandeep Raj Kumar
3c3c8d6895 Add Login with SSO option to EE lite 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6881
GitOrigin-RevId: d4603a0252c2924851c09fff9debe4d699a20fca
 2022-11-30 05:21:35 +00:00
Daniele Cammareri
16561d2c9a feat(console): add import single endpoint from openAPI 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6970
GitOrigin-RevId: 14bbca9efbda6fa71f6b00ab5d45062d71abd794
 2022-11-29 19:09:53 +00:00
Luca Restagno
8a45b4d075 console: fix nested browse rows run query 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7072
GitOrigin-RevId: cf3aa7588c1dbf4dbb225491ab36fba35535b0d1
 2022-11-29 15:06:35 +00:00
Varun Choudhary
88fd90d0e5 console: show roles created from from allow list on data, RS and action permission tables 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7059
GitOrigin-RevId: 9ccdbf14ed7066f44cd9bd568101e6ec566c1762
 2022-11-29 14:01:14 +00:00
Abhijeet Khangarot
1e1622053a console: track console load custom event on heap 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7086
GitOrigin-RevId: 838fc52e603324f2df0b234be898033eb76a0766
 2022-11-29 12:48:29 +00:00
Erik Magnusson
459aa73d2b console: fix filtering using nullish values 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7076
GitOrigin-RevId: 369a8abc2fd871e0e67d07c9ef299f689c01d81a
 2022-11-29 09:33:04 +00:00
Varun Choudhary
ff223ab938 console: clean up response transform code base 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6782
Co-authored-by: Daniele Cammareri <5709409+dancamma@users.noreply.github.com>
GitOrigin-RevId: 57f4731d2d5eb74950e6e9c3a41a2a71f162c394
 2022-11-29 09:03:49 +00:00
Erik Magnusson
a4d669a71e console: added checks to hide previously removed sources 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6996
GitOrigin-RevId: 3467b68521b50afd364c7842c7e69fbe9bd7f90f
 2022-11-29 08:06:28 +00:00
Luca Restagno
e27ed1eb5b fix: show the accelerate project box on the cloud console only 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7060
GitOrigin-RevId: 6718c5412d8541f0ab19f4d53e6afa20543b9e8c
 2022-11-28 13:00:47 +00:00
Nicolas Inchauspe
25cc0b75d6 console: fix REST endpoint creation form width 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7061
GitOrigin-RevId: 6fa530518051fab25443889c261b8ae879e8af8f
 2022-11-28 11:07:39 +00:00
Erik Magnusson
6980054a35 console: removed unnecessary null defaulting from input fields 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6988
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: 0b56327130bd268403054479c9cfd725b65dfb72
 2022-11-28 10:35:35 +00:00
Varun Choudhary
b74c2952dd console: enable naming convention check to enable/disable naming convention carded radio button 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6897
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 9dba07b1febf44fe10426e6c383cc8f3e0b799a6
 2022-11-28 07:36:27 +00:00
Nicolas Beaussart
b01a9e2784 frontend: re import code into new mono 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6966
GitOrigin-RevId: 92a8909a3d316f6a6d5dc512057e60995389383d
 2022-11-24 17:21:59 +00:00
Varun Choudhary
3061f7a90c console: forwardClientHeader is not saved while creating action 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7012
GitOrigin-RevId: 3c343a794a581033cfbf1e2759e08694b4839e74
 2022-11-24 12:54:25 +00:00
Stefano Magni
fdb2d87174 console: Fix the RequestHeadersSelector interaction tests 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6963
GitOrigin-RevId: 5e6b56d5536d82cb93189b5b33c7cb14bc88d899
 2022-11-24 12:16:08 +00:00
Luca Restagno
4c109f9b85 Console: retain filters and sorts conditions while moving from one tab to the other 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6905
Co-authored-by: Abby Sassel <3883855+sassela@users.noreply.github.com>
Co-authored-by: Auke Booij <164426+abooij@users.noreply.github.com>
Co-authored-by: Erik Magnusson <32518962+ejkkan@users.noreply.github.com>
Co-authored-by: Daniel Harvey <4729125+danieljharvey@users.noreply.github.com>
Co-authored-by: Vishnu Bharathi <4211715+scriptnull@users.noreply.github.com>
Co-authored-by: Brandon Simmons <210815+jberryman@users.noreply.github.com>
Co-authored-by: awjchen <13142944+awjchen@users.noreply.github.com>
Co-authored-by: Krushan Bauva <31391329+krushanbauva@users.noreply.github.com>
GitOrigin-RevId: 889feeb75b8119f94d9d5da071c50374ac59f589
 2022-11-24 10:11:43 +00:00
Stefano Magni
c50cfad476 console: Improve the analytics docs 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7015
GitOrigin-RevId: 66e461f20173d5e669056f3d818821a1f1384bb4
 2022-11-23 16:04:30 +00:00
Matthew Goodwin
7a1dc37bf6 refactor (console): create global metadata hooks that use the new metadata types 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6931
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: e57ed8bf14f2b855c6f4c20e072ecd25a784d08b
 2022-11-23 13:18:15 +00:00
Varun Choudhary
8a35522970 console: console crashes on searching special character on table and action search bar 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7008
GitOrigin-RevId: 29e445da8d4be0daba60b02eb8a40c640086df2b
 2022-11-23 12:07:23 +00:00
Sameer Kolhar
42d2e9bf10 console: add UI to show DB connection latency reports on cloud console 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6808
GitOrigin-RevId: 2768bdf3611ecaf40ed1b967d27c57aa3d80034a
 2022-11-23 11:08:29 +00:00
Varun Choudhary
489d1fe493 console: browse back from allow list using browser back button 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6990
GitOrigin-RevId: 1c99dbdb7098dee57839cd98e4d19c19edd470b9
 2022-11-23 07:53:45 +00:00
Nicolas Inchauspe
0ebb4a04ec console: fix code exporter style 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6952
GitOrigin-RevId: 269cff9788a12a02f13f89c2d98793b8aa50ca25
 2022-11-23 07:53:36 +00:00
Erik Magnusson
55715f7074 console: added styling for relationship legacy tabs 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6938
GitOrigin-RevId: 644364a3e47bd23a5740aaf9e3b294a1f453f2c1
 2022-11-21 17:07:45 +00:00
Erik Magnusson
42832cdc84 console: fallback for editing expanded text fields 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6951
GitOrigin-RevId: fa0d2b8538b612ec86b1f9fa180188bb8d55b289
 2022-11-21 10:59:47 +00:00
Luca Restagno
02c21d21aa console: fix the condition to show the custom table tracking modal 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6944
GitOrigin-RevId: bfacd2dcf1aad95feb323db9686c7d9d15ebdaba
 2022-11-21 10:29:48 +00:00
Nicolas Inchauspe
4df205197a console: prevent react-ace to use a service worker 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6778
GitOrigin-RevId: 0a00b924bcc7b9dc0c7b465dc4d05a67549fd329
 2022-11-18 16:39:53 +00:00
Luca Restagno
6e091bae30 console: E2E test to verify DB compatibility 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6867
GitOrigin-RevId: be5803fd3b3436fc38c75ae70aa8d3e6a7f38402
 2022-11-17 17:00:58 +00:00
Vijay Prasanna
980813c4c5 refactor (console): relationship tab components for GDC, local types & stories 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6801
GitOrigin-RevId: d1e97752bc52633a3a853a8d474efb6c437ba5dd
 2022-11-16 12:58:25 +00:00
Daniele Cammareri
0a73187c8d console: add a generic mock that emulates metadata api 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6194
GitOrigin-RevId: f58c98b16ab156e742ab8a446124136fb4b0e638
 2022-11-15 09:29:56 +00:00
Erik Magnusson
4164f36bca hotfix: add functionality to make data tab filter read url values 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6854
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: 1e09591ecd6ef3c59e9ac157547c93a9eb7ac39e
 2022-11-14 13:59:06 +00:00
Matthew Goodwin
d829585e9c console: InputField clear button 
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6767
GitOrigin-RevId: 2d6a68507a7e7970b68d4eb25ea665c9269a49af
 2022-11-10 17:00:01 +00:00