Commit Graph

5595 Commits

Author SHA1 Message Date
Auke Booij
4c016b4c42 Clean up pg-client-hs
- Remove a few unnecessary helper functions
- Delete kind annotations
- Bring GHC warnings and language extensions more in line with those of the `graphql-engine` library
- Constrain unconstrained dependency on `hasql-pool`

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6251
GitOrigin-RevId: 10c2530f007f70cf1464cec36566ee2264589881
2022-10-07 11:56:55 +00:00
Tom Harding
1d1ab15b47 Remove parsing for functions in Cockroach
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6250
GitOrigin-RevId: 389f58a327096ef9586c7a0f35df243955f73a5d
2022-10-07 09:51:07 +00:00
Daniel Harvey
ba2e585a15 server: fetch col_description using value from column directly
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6228
GitOrigin-RevId: 8a887817ae3003bc63b49a79d3d4772b2dcea020
2022-10-07 08:42:16 +00:00
Sean Park-Ross
84c38e8a5c Docs: Fix Docker compose version issue in getting started
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6236
GitOrigin-RevId: 33ac857a6d0b0e0999de09e61a40e307d00f1574
2022-10-07 06:03:06 +00:00
Samir Talwar
585f35f271 Nix: Upgrade to GHC 9.2.4.
What fun!

Tested on x86_64 Linux and aarch64 macOS. I had to add a bunch of Haskell package overrides specifically for macOS on aarch64, but I made them apply to all macOS users because, well, it's just a couple of us right now and we're both using aarch64.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6239
GitOrigin-RevId: 4e5a20d21eb24c736e8663de3f1e05ce5705284a
2022-10-06 21:05:34 +00:00
Samir Talwar
36031d62d2 server/tests-py: Fix the run.sh and run-new.sh scripts to work with our new server-builder image.
This updates _docker-compose.yml_ to use the new image tags, and updates _run.sh_ accordingly.

While I was at it, I also added a `docker compose pull` instruction to make sure that we don't have surprises half-way through the script, and a few `echo` lines for clarity.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6235
GitOrigin-RevId: 3855f6898bd3e906c5f423d9d0d6a7031de3777a
2022-10-06 19:04:58 +00:00
Samir Talwar
f9ff7ae00c CI: Remove the custom Microsoft SQL Server image.
Now that we use the mssql-tools image for running `sqlcmd`, we no longer need this (or indeed use it very much).

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6152
GitOrigin-RevId: be8852a93889553c3ffd2ec00c0dda81b36c3d05
2022-10-06 16:21:44 +00:00
Daniel Harvey
bdf70651e8 tooling: bump .ghcversion to 9.2.4
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6226
GitOrigin-RevId: 46b9d3e118ca5394a5cb4869a020d5de0b873999
2022-10-06 14:13:39 +00:00
Luca Restagno
b0569e0eb7 console: fix e2e tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5557
GitOrigin-RevId: 5b07d94e7199b75546455e5702e6eaabfa5e1f7f
2022-10-06 14:13:30 +00:00
Daniel Harvey
ad53402d1d test: Check CockroachDB can query into JSONB values with a path
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6124
GitOrigin-RevId: 3de6b6c602d41d4d340c355171c10ac33582b9a5
2022-10-06 13:03:03 +00:00
Gil Mizrahi
d8452bf11c server: remove ghc libs from freeze file, update guides
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6231
GitOrigin-RevId: d877e46d7130217cd95eb9c507921e76a0009151
2022-10-06 12:27:09 +00:00
Varun Choudhary
4b79dfcb8d console: disable url field on view remote schema page
## Description 🔖

Disable URL field on view remote schema page. Earlier we are able to edit the URL name from the view remote schema page. ([VIDEO](https://user-images.githubusercontent.com/68095256/194233185-1c93722a-e8bb-4a78-9d8e-05a0eef572c3.mov))

## Related issue

https://hasurahq.atlassian.net/browse/GS-170

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6224
GitOrigin-RevId: 7a3a43a3648d6f88e66e886d34357939477bcc88
2022-10-06 11:38:22 +00:00
Varun Choudhary
bb5c1ad4d0 console: add response_transform in update_action api call
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6223
Co-authored-by: Daniele Cammareri <5709409+dancamma@users.noreply.github.com>
GitOrigin-RevId: 6687188c3fe1dc025273aa8f3bb0bac20b605a7d
2022-10-06 11:04:14 +00:00
Erik Magnusson
8fb1c1f344 console: added an error notification when successful gql response contains err…
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6204
GitOrigin-RevId: ab3135525a7cbb0d2efbd8a65b2b84942014b367
2022-10-06 10:31:43 +00:00
Daniel Harvey
87ca46f79b tests: add Postgres 14 and Postgres 15 pytests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5968
GitOrigin-RevId: 6569e58b89f014268152cfe7bf1f6c11233fbe49
2022-10-06 09:46:38 +00:00
Brandon Simmons
823babe885 server: switch to ghc 9.2 (2nd try)
## Migrating, for server devs

You will need the fork of 9.2.4 that we're using (for now):

```
ghcup -c -n install ghc --force -u "https://storage.googleapis.com/graphql-engine-cdn.hasura.io/ghc-bindists/ghc-x86_64-deb10-linux-9.2.4-hasura-fix.tar.xz" 9.2.4
```

or for m1 mac:

```
ghcup -c -n install ghc --force -u  "https://storage.googleapis.com/graphql-engine-cdn.hasura.io/ghc-bindists/ghc-arm64-apple-darwin-9.2.4-hasura-fix.tar.xz"
```

Samir is working on a nix build for nix folx

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6154
GitOrigin-RevId: 6716e3f2ee19f0281c8ad25383a1241fc362d616
2022-10-06 09:09:01 +00:00
Luca Restagno
1fb32bc2d4 console: isolate redux logic for the insert row tab
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6195
GitOrigin-RevId: c65e08266fb0a4946bbe4c37e89070fb02eba9f8
2022-10-06 08:00:54 +00:00
Rishichandra Wawhal
8613af582e console: update onboarding messages for the new template schema
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6221
GitOrigin-RevId: 1276a6208e34f20e735daaf856a1e099e52d3338
2022-10-06 06:12:28 +00:00
Daniel Chambers
d713cad315 Add support for lowercase table and column names in the Data Connector agent tests [GDC-463]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6179
GitOrigin-RevId: 6455e5809ea06b86dfbcddf781ee105088ca78f9
2022-10-05 23:25:00 +00:00
Jesse Hallett
77200563a4 rfc: separate metadata API types from business logic types
[Rendered](https://github.com/hasura/graphql-engine-mono/blob/jesse/rfc/metadata-dtos/rfcs/separate-metadata-api-types.md)

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4619
GitOrigin-RevId: a9e4c119ae53a37718fd7c7c1b658c6bfaa2616a
2022-10-05 18:39:45 +00:00
Samir Talwar
6a586cdaa0 api-tests: Sort and uniquify test module names in the Cabal file.
The duplicates make Cabal 3.8.x choke.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6206
GitOrigin-RevId: 7c6c69c721aed659a19db7b9124749dd6566d5dc
2022-10-05 12:38:48 +00:00
Philip Lykke Carlsen
3fea9ce4fc Refactor FromItem to use TableIdentifier
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6166
GitOrigin-RevId: 97d4fb0bec6d1c60e168f2503328ad5ef38915b2
2022-10-05 10:04:57 +00:00
Jigyasu Arya
24863e4601 community: streaming chat app - add graphql query tab
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6196
GitOrigin-RevId: 01ccf4e424428936a4a7bdc44bb37c480cfb92fc
2022-10-05 09:33:31 +00:00
Brandon Simmons
d76636a5a3 packaging: partially revert #5604, stay on focal to use libssl1.1. Add libssl explicitly.
Trying to run the image while debugging:  https://github.com/hasura/graphql-engine-mono/pull/6172/ I get:

    $ docker run -it hasura/graphql-engine:dev-b91a92b-jberrymanalexghc92-ci-REBASE10-cherry-.ubuntu.amd64
    graphql-engine: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

It seems as though the ubuntu image has been broken in some way since
moving to jammy (Which only ships with `libssl.3`), but strangely this
only shows up on main, not in PRs (except on the 9.2 branch…?)

we use this in tests for instance: .buildkite/scripts/test-dc-sdk.sh

Strangely I don't get the error with an image from recent PRs:
https://github.com/hasura/graphql-engine-mono/pull/6148
https://github.com/hasura/graphql-engine-mono/pull/6156 (to latest release)

...although Samir sees it on some he looked at

```
docker run -it hasura/graphql-engine:dev-46eaa39-plcreleasev2.13bq-scalars.ubuntu.amd64 graphql-engine version
Fatal Error: Either of --metadata-database-url or --database-url option expected
```

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6176
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 6eea65f2d1dc7f0d13bcd58f94737810d290cb89
2022-10-05 09:07:26 +00:00
Daniele Cammareri
bfca6d782d console: add types generator in add new action form
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6092
GitOrigin-RevId: 993de137c99d2af186d8f5088b3db6dfcb46a1e1
2022-10-04 18:44:26 +00:00
Jigyasu Arya
bf991be955 community: update streaming-subscriptions-chat ui
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6082
Co-authored-by: arjunyel <11153289+arjunyel@users.noreply.github.com>
Co-authored-by: Praveen Durairaju <14110316+praveenweb@users.noreply.github.com>
GitOrigin-RevId: 48a02077900571686529c52e835569ad9dbc6b1c
2022-10-04 14:16:56 +00:00
Sooraj
31c94f3180 console: Hide cumulative max connections
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6182
GitOrigin-RevId: 3cd58995ed418f6fdf9e09747b382f717f7ecfae
2022-10-04 13:26:53 +00:00
Varun Choudhary
761bcf6883 console: show event trigger invocation logs if only event logs are cleaned
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6169
GitOrigin-RevId: e89e798bcb9a754ddef258fc58e2ad35046e1141
2022-10-04 12:52:17 +00:00
Samir Talwar
740341382f CLI: Upgrade Dockertest to try and fix the build on CI.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6184
GitOrigin-RevId: 796f400fd45a58a5a81212e04a0730c53f04899a
2022-10-04 12:06:32 +00:00
Samir Talwar
64c40b9a95 CI: Run the "server hpack" check on main and invalidate the cache properly.
We seem to be rebuilding hpack on every PR. I'm hoping this will allow PRs to share a cache.

I have also changed the cache key to include the entirety of _server/VERSIONS.json_, and added the GHC version there, to make sure it's properly invalidated.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6142
GitOrigin-RevId: fc61a26ad721f59f52687913f6978902f4c2ca0a
2022-10-04 09:01:20 +00:00
Tom Harding
f05f746b94 Extract the test harness from the Hspec tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6095
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
GitOrigin-RevId: 51693f7324e62e201a2bdc701255cf6c730745e2
2022-10-04 08:31:26 +00:00
Auke Booij
05b3a64e8f Clean up Hasura.Prelude a bit
- Remove `onJust` in favor of the more general `for_`
- Remove `withJust` which was used only once
- Remove `hashNub` in favor of `Ord`-based `uniques`
- Simplify some of the implementations in `Hasura.Prelude`
- Add `hlint` hint from `maybe True` to `all`, and `maybe False` to `any`

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6173
GitOrigin-RevId: 2c6ebbe2d04f60071d2a53a2d43c6d62dbc4b84e
2022-10-03 21:50:53 +00:00
Auke Booij
6602ad44b1 Print the definitions of the types that are conflicting
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6139
GitOrigin-RevId: 1ab0eecb0f75fb57534fd39add9bfde5041c090e
2022-10-03 21:13:18 +00:00
Auke Booij
3efabe99b3 Memoize column parsers (within roles)
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6036
GitOrigin-RevId: 225698f6db02b16599d9f157c9fe4c03b16fb71b
2022-10-03 20:11:44 +00:00
Abhijeet Khangarot
52873dba95 console: add reload metadata call to useInstallMetadata hook
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6168
GitOrigin-RevId: f8f72ab47898594d6aa8327d44215c760756a160
2022-10-03 14:12:59 +00:00
Samir Talwar
000e9c2f24 CI: Upgrade our CI Docker images to the latest stable Debian + Ubuntu versions
This upgrades our Docker images from various Debian versions (mostly
`buster`, a.k.a. `oldstable`) to `bullseye` (a.k.a. `stable`).

`buster`/`oldstable` is still supported but I'm not sure for how long.

It also upgrades our HGE Docker image Ubuntu 20.04 to Ubuntu 22.04.

This will allow us to provide the latest Microsoft SQL Server Driver,
`msodbcsql18`, which is supported on both x86_64 (amd64) and
aarch64 (arm64).

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5604
GitOrigin-RevId: 385d8670476dd343635a4fbc564a6797c8872127
2022-10-03 13:17:23 +00:00
Varun Choudhary
1635ddd607 console: fix UI for auto-cleanup event trigger on modify page
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6164
GitOrigin-RevId: c1683c72f487d17e2fc46677b205cde862fe9663
2022-10-03 11:57:11 +00:00
Auke Booij
6515ae8dbe Improve description for table select columns enum type
Before:
```
select Name {unName = "upeopoeklplxfaa"}columns of table "exbiovdrgjqskdr"
```
After:
```
select "upeopoeklplxfaa" columns of table "exbiovdrgjqskdr"
```

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6143
GitOrigin-RevId: 80a4075057c6d7361a000cb5c1e9b7a166a4f125
2022-10-03 11:00:10 +00:00
Daniele Cammareri
4342151099 console: fix local object relationship deletion
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6147
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
GitOrigin-RevId: 2995cf3fabf651f40b8db50dfc93f25b42f02944
2022-10-03 10:25:47 +00:00
Nicolas Inchauspe
f4ec8ed1f1 console: rollback remote schema permission edition buttons migration
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6127
GitOrigin-RevId: f290daa147715918df194dc94cb1132aa50671b1
2022-10-03 08:13:36 +00:00
hasura-bot
4d462b7bbc docs: Fix minor typo
GITHUB_PR_NUMBER: 9049
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/9049

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6160
Co-authored-by: Matt Dailis <1189602+mattdailis@users.noreply.github.com>
GitOrigin-RevId: fd2ec7ca7b59d2c8964d372e4a61695aac5a4455
2022-10-02 10:50:08 +00:00
Auke Booij
b03ed983f1 Remove spaces before colons in error messages and descriptions
This PR is the result of running the following commands:
```bash
$ git grep -l '".* : "' -- '*.hs' | xargs sed -i -E 's/(".*) : "/\1: "/'
$ scripts/dev.sh test --integration --accept
```

Also manually fixed a few tests and docs

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6148
GitOrigin-RevId: cf8b87605d41d9ce86613a41ac5fd18691f5a641
2022-10-01 14:48:58 +00:00
Brandon Simmons
98a9c5af79 server: remove default +RTS -qn2 setting
We notice significant improvements to max GC pause time, for huge schema (both on 8.10 and 9.2)

This was added when we were on ghc-8.6.5. The referenced issues (from old oss repo) seem irrelevant or don't have useful information afaict

re. https://hasurahq.atlassian.net/browse/SRE-10
https://hasurahq.atlassian.net/browse/SRE-129

-----

**EDIT**: old discussion https://hasurahq.slack.com/archives/CKFUG6RCH/p1576518775017100

It sounds as though if the `replace_metadata` benchmark doesn't regress then we're okay

**EDIT**: Ooh nice, replace_metadata is much faster across the benchmark sets (see "both compared" details)

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6133
GitOrigin-RevId: c1e2292f29a52584062dfebf2dd676118fcd978f
2022-09-30 20:11:54 +00:00
Samir Talwar
b52dc90663 Nix: Get the Nix shell working on macOS/aarch64.
Improvements to the Nix configuration so that macOS is supported.

Microsoft SQL Server is still not supported (yet; I have something in mind there), but the rest works. You can still use Homebrew to install the SQL Server drivers.

I had to make the following changes:

* I updated nixpkgs, because it's been a while.

* I made `ODBCINSTINI` optional so that it's not loaded on macOS, as it depends on `msodbcsql17`, which is broken on macOS.

* I upgraded OpenSSL.

* I set `DYLD_LIBRARY_PATH` on macOS so GHC finds OpenSSL; otherwise, it uses the wrong version of `libcrypto`, and fails with a fun error:

  > WARNING: ghc is loading libcrypto in an unsafe way

* I patched GHC to fix compilation on macOS (copied from https://github.com/NixOS/nixpkgs/pull/149942).

To test this out, you can run `nix develop` (or install [direnv][] and add `use flake` to _.envrc.local_), and then try building HGE in the shell provided.

Fair warning: GHC needs to be built, and takes _aaages_ the first time. If this becomes useful to others, we can set up a shared cache.

[direnv]: https://direnv.net/

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5989
GitOrigin-RevId: 7130738d47709c37778b31c134061758ce23e959
2022-09-30 19:17:14 +00:00
nevermore
c46a50d950 console: query auto population and usage
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6107
Co-authored-by: Rishichandra Wawhal <27274869+wawhal@users.noreply.github.com>
Co-authored-by: Abhijeet Khangarot <26903230+abhi40308@users.noreply.github.com>
GitOrigin-RevId: 1a6761de0db9f4ece8a26c9af54178c7f2461943
2022-09-30 16:34:05 +00:00
Sean Park-Ross
f7183302f5 Docs: New Getting Started > How it Works page (WIP)
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5251
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: aceb6dcae6d0f10edc051e2f25073031826934ac
2022-09-30 14:03:35 +00:00
Rishichandra Wawhal
950e8dbe25 console: add onboarding events to neon integration; misc onboarding changes
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6131
Co-authored-by: Abhijeet Khangarot <26903230+abhi40308@users.noreply.github.com>
GitOrigin-RevId: 88ffbeb8539dee04ac4b83c6db124fa5817c303c
2022-09-30 13:57:14 +00:00
Philip Lykke Carlsen
7739f8e4a0 server: Permit strings for numerical input fields
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5996
GitOrigin-RevId: 2ed36898aa0286618f3dafe3513ef4e01c58aaba
2022-09-30 13:25:57 +00:00
Gil Mizrahi
d1434e4932 run bigquery with retry in test-harness
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6141
GitOrigin-RevId: dce43ed5ce5ffffaa7680f5fa550c7df59c8cae4
2022-09-30 12:49:02 +00:00
nevermore
1a62677583 console: update Neon Banner and adjust button
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6144
Co-authored-by: Abhijeet Khangarot <26903230+abhi40308@users.noreply.github.com>
GitOrigin-RevId: 09fe0008f004977cf0fbcbdb873df791656f82a8
2022-09-30 12:14:37 +00:00