Samir Talwar
ae5279ccda
Apply HLint's new proposed fixes.
...
Upgrading HLint brought in a bunch of new suggestions for improvements to the code.
I thought I'd go through them quickly and get them in.
This is not all of them, just the ones I thought were reasonable.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10505
GitOrigin-RevId: cefd661e9dcb973843b421fd0e31a5c5ffe4720f
2023-12-07 09:16:33 +00:00
Samir Talwar
d39f30c38c
Allow for columns without known types in MS SQL Server.
...
Sometimes, the `sys.types` table will not contain a type for a given column.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10506
GitOrigin-RevId: 7407e715a75d196f1bc0408d05f00804f85cbc55
2023-11-23 10:32:56 +00:00
Samir Talwar
0373beaed0
Upgrade nixpkgs, bump Haskell tool versions, and fix the new HLint errors.
...
Maintenance work to keep our server tools up to date.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10503
GitOrigin-RevId: 4402e39a5600d14c1e7d5eb4c91b152c2111f315
2023-11-22 09:02:34 +00:00
hasura-bot
17e1516511
fix: escape SQL column names in MSSQL's event trigger
...
GITHUB_PR_NUMBER: 9926
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/9926
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10378
Co-authored-by: Nakano as a Service <20109935+nakanoasaservice@users.noreply.github.com>
GitOrigin-RevId: 644e8fa2cf8c86f85c72c7a075e375a071cb5814
2023-10-30 09:19:24 +00:00
David Overton
82fa13db6e
Support joins on nested fields for MongoDB
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10345
GitOrigin-RevId: 1a4886b7ac5110ddf9233596068810963bde3371
2023-10-30 02:27:29 +00:00
Daniel Chambers
30ed6fc30d
Dynamic from file template variables in Data Connector config Kriti transforms
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10408
Co-authored-by: Matthew Goodwin <49927862+m4ttheweric@users.noreply.github.com>
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: c6d7a47079d93a6c0a987cd1df7ece9fa4d1a917
2023-10-27 12:36:11 +00:00
paritosh-08
9de2ab40e2
server: throw error in subscription for fields using remote relationship permission
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10415
Co-authored-by: Sean Park-Ross <94021366+seanparkross@users.noreply.github.com>
GitOrigin-RevId: 245c2805e312f2eb05b61eec64f714c6bd0308e4
2023-10-27 11:05:47 +00:00
Brandon Simmons
4007104653
server: GS-650: dynamic postgres connection strings from file
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10401
Co-authored-by: Rob Dominguez <24390149+robertjdominguez@users.noreply.github.com>
Co-authored-by: Matthew Goodwin <49927862+m4ttheweric@users.noreply.github.com>
GitOrigin-RevId: 94967922738533a80c1af33cca7feab724cc89f6
2023-10-26 22:24:39 +00:00
Naveen Naidu
a893b1b906
server, multitenant: model usage logs
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9744
Co-authored-by: pranshi06 <85474619+pranshi06@users.noreply.github.com>
Co-authored-by: paritosh-08 <85472423+paritosh-08@users.noreply.github.com>
GitOrigin-RevId: 270755e88fd17f8fd949ac06d31e408202078544
2023-10-03 05:17:39 +00:00
Philip Lykke Carlsen
2d2fe93adf
fix: MSSQL remote relationships handles large results
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10327
GitOrigin-RevId: c7e478f52f7aa7b44a3597886588b0c0f1e7341c
2023-09-25 08:49:43 +00:00
kodiakhq[bot]
07bad7c498
INFRA-832: logs OTLP export
...
https://hasurahq.atlassian.net/browse/INFRA-832
Foundational work already merged:
- #10171
- 0184ba8bfcae9b
- 699317ffd061d3
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10238
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Toan Nguyen <1615675+hgiasac@users.noreply.github.com>
GitOrigin-RevId: d88c6a1aafe74e7393873aacc61e6fce3bc7c068
2023-09-13 16:49:55 +00:00
Toan Nguyen
f915c7d1a2
server: support w3c traceparent context
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10218
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rob Dominguez <24390149+robertjdominguez@users.noreply.github.com>
GitOrigin-RevId: d3dbea6220fd2127ab76c0a240fc4725ca5d6aac
2023-09-13 13:42:30 +00:00
Brandon Martin
db59d5ccf4
Add schema post and deprecate get
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10281
GitOrigin-RevId: 9fae2d61bd5120302ae199016b71e2b0ecac422a
2023-09-07 13:35:29 +00:00
Samir Talwar
5e96f9a5a8
server: BigQuery: Add support for _like
within permissions.
...
We missed a few operators in BigQuery permissions, specifically `_like` and `_nlike`. This adds them.
[NDAT-866]: https://hasurahq.atlassian.net/browse/NDAT-866?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10274
GitOrigin-RevId: 4d1ebbdd15b80d09c65c5b792c33dffd618458fe
2023-09-06 14:55:21 +00:00
Philip Lykke Carlsen
b522a0f650
fix: Introduce naming-convention-sep-2023 feature flag
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10200
GitOrigin-RevId: 02654837c3b98a7cbfb89cf98a1d7b5287fed1b4
2023-08-28 08:43:08 +00:00
Philip Lykke Carlsen
3f9abc4477
chore: Linting
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10182
GitOrigin-RevId: f6680570cea8f0202e705559a048e4a654fe50bb
2023-08-23 15:39:37 +00:00
paritosh-08
e1cfc56fc3
server: add remote source relationship in permission
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9575
GitOrigin-RevId: 4566d51d48f9ace583b04fbe04c534d6aeb771ea
2023-08-22 14:35:14 +00:00
kodiakhq[bot]
7258c0ccdc
INFRA-832: incremental refactoring PR 2
...
Some refactorings required for https://hasurahq.atlassian.net/browse/INFRA-832 . No functional changes.
Also included is a small but important un-related bug fix
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10136
GitOrigin-RevId: 5468c5b5b1693c0c3b8781c9fa47191ad66fefca
2023-08-18 10:57:58 +00:00
Daniel Chambers
c726b528c4
Add table/function filtering and detail level to schema introspection for Data Connectors to improve performance
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10074
GitOrigin-RevId: 12de7387746f456cbefd9f76e446f56e9e643dc9
2023-08-18 04:29:17 +00:00
Daniel Harvey
f8d60a74a0
chore(server): Table -> Native Query object relationships
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10114
GitOrigin-RevId: 0181184d1bc0e851151f86a98c96c97888a10e3e
2023-08-17 15:35:31 +00:00
Samir Talwar
15ac52ded4
server: Fix the Analyze feature for SQL Server.
...
The "Analyze" feature for SQL Server only partially worked. It would show the SQL generated, but not the execution plan. This is because SQL Server doesn't support generating a plan for prepared statements with parameters.
To work around this, we restructure the query as one without parameters. Instead, we replace each parameter with a variable. We declare the variables but don't set values. We then plan _that_, which works.
We run all this in a single query because local variables only last for a single transaction/batch.
This feature does not work for stored procedures.
[NDAT-582]: https://hasurahq.atlassian.net/browse/NDAT-582?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10125
GitOrigin-RevId: a4b45b9b207456ff4fbd1b69b008e93f87346342
2023-08-17 12:51:57 +00:00
Lyndon Maydwell
41054de113
Data Connectors Native Queries Support
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9499
Co-authored-by: gneeri <10553562+gneeri@users.noreply.github.com>
GitOrigin-RevId: 1e351556c43e643aa973f87adc0306f076cd227e
2023-08-17 02:05:14 +00:00
Daniel Chambers
131fe3d9e6
Block the use of column redaction where the data connector agent does not support it
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10108
GitOrigin-RevId: 830102b8cf1e6ad53b9971460dee147b678f008d
2023-08-15 05:13:15 +00:00
David Overton
7a9e1f6ea6
Order by nested fields
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10082
GitOrigin-RevId: 9c53d7ce3635f442451e04f70f0975ed79a3f4f7
2023-08-14 06:41:50 +00:00
Daniel Harvey
cd324f747b
chore(server): Native Query -> Table object relationships
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10098
GitOrigin-RevId: 9b98bb0e285560cd03b04f867d1fa16dadd00df9
2023-08-10 14:23:47 +00:00
Samir Talwar
2d7bb085d5
server: Support _contains
and _contained_in
in permissions.
...
We recently added support for the `_contains` and `_contained_in` operators for PostgreSQL arrays. However, they weren't available in permissions.
This adds support for these operators for arrays too.
As these operators are overloaded to work with either JSONB or arrays, no validation is done on the value. If the value is not an array, it will fail when making a query.
[NDAT-806]: https://hasurahq.atlassian.net/browse/NDAT-806?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10075
GitOrigin-RevId: 02e4a57d39ac3303205c37add4186a587f65e409
2023-08-09 15:45:54 +00:00
Tom Harding
29bb76d6d3
Fix inherited roles leaking supposedly-hidden data via aggregation predicates for BigQuery
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10049
Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com>
GitOrigin-RevId: d0af2d29e29111097e17033e10c41d668eb5a351
2023-08-09 11:52:58 +00:00
Daniel Chambers
68f7d6e9a4
Add inherited roles data redaction support to the Data Connector API
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/10023
GitOrigin-RevId: d6947dd89dc59fce3f68b786192c59e731826c60
2023-08-03 06:10:53 +00:00
Philip Lykke Carlsen
2cb66592c3
fix: Apply naming conventions in more places
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9988
GitOrigin-RevId: e74797306a6a131b9b038a20cc6e40befb33ab77
2023-08-02 13:47:21 +00:00
David Overton
23d40fc500
Nested where
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9940
GitOrigin-RevId: c2115f1de4f647c4b559c98183c6260a1f5674dd
2023-08-01 05:41:36 +00:00
Daniel Chambers
7b2647e4e9
Fix inherited roles leaking supposedly-hidden data via streaming subscriptions for Postgres
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9977
GitOrigin-RevId: 56da6f97477095a1930cd29ff87ba5c3832d59f4
2023-08-01 01:47:44 +00:00
Samir Talwar
1a052dd44b
server: Avoid partial fields wherever possible.
...
This turns on the `partial-fields` warning, which yells at you if you try and create fields on sum types that end up being partial functions. These are dangerous; we had a bug because we introduced a new case to a data type, making the field accessors partial, and leading to a crash in certain cases.
This means that we have introduced a few wrappers in various places where the field names are useful, but we want to avoid partial matches.
Unfortunately this can be turned off by prefixing the field name with an underscore. Ideally we would try and avoid exporting any field names with underscores, but lenses make this hard. I have removed some underscores for the areas in which we've seen this break in the past.
We will have to be vigilant.
[NDAT-794]: https://hasurahq.atlassian.net/browse/NDAT-794?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9991
GitOrigin-RevId: fd69b1ef999682969f3507f0e97513f983da4da6
2023-07-28 10:54:24 +00:00
Philip Lykke Carlsen
cf2d205937
Fix(Sqlserver): Apply Column Redaction to order_by and _where
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9971
GitOrigin-RevId: 04cae8163af2d002a2d5aea73fb45088fc0eaea4
2023-07-26 16:05:00 +00:00
Daniel Chambers
bae14c70d4
Fix inherited roles leaking supposedly-hidden data via aggregation predicates for Postgres
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9961
GitOrigin-RevId: cffe2fda2f4dbc7929fc1aaac3887b7d12c4b467
2023-07-26 12:07:34 +00:00
Philip Lykke Carlsen
483409c26b
Fix(Sqlserver): Apply Column Redaction to aggregations
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9956
GitOrigin-RevId: ed7a734fabcaaead85999a25223a61f0cba7807c
2023-07-26 08:53:56 +00:00
Daniel Chambers
fa1441ac3b
Enable inherited role redaction tests for Citus and Cockroach and fix DISTINCT ON for Cockroach
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9951
GitOrigin-RevId: b078006a14ebdc007576314405734734ad1944c4
2023-07-26 04:50:25 +00:00
Daniel Chambers
592e2329d0
Fix inherited roles leaking supposedly-hidden data via filtering for Postgres
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9916
GitOrigin-RevId: 39f6f1aa21421dda6573bbae561c62ced3400034
2023-07-20 23:29:01 +00:00
Tom Harding
05cfb65b54
Log Postgres Source Names in Connection Errors
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9869
GitOrigin-RevId: 916758e7f1037cc67035894298e55771f9aa2d9f
2023-07-20 11:20:09 +00:00
Philip Lykke Carlsen
462abadb8c
feat(SqlServer): Configuration option to disable the connection pool
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9834
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 6b7f8bd660ddda0cae3a5457267f5af4906ff65a
2023-07-18 18:41:10 +00:00
Daniel Chambers
2f3defe3a9
Refactor inherited roles data redaction types
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9882
GitOrigin-RevId: cffb0643202ee18abdc90887fd0306fe0835c44e
2023-07-18 13:50:32 +00:00
Daniel Chambers
a86345421f
Fix inherited roles issue with ordering
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9868
GitOrigin-RevId: 0c2b50ec1a2d179a4f79b6c795bf8fecb7ad7c9f
2023-07-18 13:09:42 +00:00
Daniel Chambers
06a79b9e59
Fix inherited roles leaking supposedly-hidden data from aggregates for Postgres
...
[GDC-1292]: https://hasurahq.atlassian.net/browse/GDC-1292?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9799
GitOrigin-RevId: 8138c6064bffe8af5228c293e28513962e980820
2023-07-17 04:28:46 +00:00
David Overton
a46f07ea45
Logical models in get_table_info
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9798
GitOrigin-RevId: ab7b1dc0a4504c1ec103c449ca2e444589673c0f
2023-07-12 02:10:02 +00:00
Daniel Harvey
213f64c061
chore(server): add experiment feature flag to disable Postgres arrays in introspection
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9804
GitOrigin-RevId: eeb378153df070ffedcada6a91d3117a0a83dde9
2023-07-10 11:17:10 +00:00
Philip Lykke Carlsen
e8d7444b70
Feat: Use column nullabilty to generate simpler permissions SQL
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9793
GitOrigin-RevId: d7a3995efe5ca3936fa5b3a7ecf4574b694b9909
2023-07-10 09:28:54 +00:00
Naveen Naidu
f29105fb0c
server: remove input validation feature from experimental features
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9747
GitOrigin-RevId: d59a272558d190525245796518a764574bd93286
2023-07-04 13:23:20 +00:00
Daniel Harvey
f18a78bad4
chore(server): Postgres array enums fix
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9727
GitOrigin-RevId: a3d998083dfea171d15f20ae0774de8f3e627d49
2023-06-30 18:44:33 +00:00
Philip Lykke Carlsen
57690491af
fix: Soften validation requirements for nested inserts
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9721
GitOrigin-RevId: 794b6769b56dcb0bea3640ac9eb837e7f1e8375c
2023-06-29 14:17:04 +00:00
Daniel Harvey
cb02a9a034
chore(server): add tests/support for inserting JSON arrays
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9704
GitOrigin-RevId: 4c2820c302d056bed92bf61e3670419c6da1563e
2023-06-29 09:50:36 +00:00
Naveen Naidu
a367525e68
server/postgres: delete input validation [experimental]
...
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9666
Co-authored-by: Rakesh Emmadi <12475069+rakeshkky@users.noreply.github.com>
GitOrigin-RevId: 5fa7702401065869c953b23c6734b9b367247634
2023-06-28 13:46:00 +00:00