graphql-engine

hasura/graphql-engine

Fork 0

mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-17 20:41:49 +03:00

Commit Graph

Author	SHA1	Message	Date
Antoine Leblanc	e2ce1972f6	Prevent empty subscription roots (fix hasura/graphql-engine#6898 ) ### Description We always build a subscription root, even when there was no possible fields. This breaks some third party clients, as the spec does not allow empty types in the schema. This PR fixes this by changing the `buildSubscriptionParser` helper to return a `Maybe` value, and harmonizes / cleans places where we build the subscription root. https://github.com/hasura/graphql-engine-mono/pull/2357 GitOrigin-RevId: 1aeae25e321eee957e7645c436d17e69207309fd	2021-09-16 07:42:46 +00:00

Author

SHA1

Message

Date

Antoine Leblanc

e2ce1972f6

Prevent empty subscription roots (fix hasura/graphql-engine#6898 )

### Description

We always build a subscription root, even when there was no possible fields. This breaks some third party clients, as the spec does not allow empty types in the schema. This PR fixes this by changing the `buildSubscriptionParser` helper to return a `Maybe` value, and harmonizes / cleans places where we build the subscription root.

https://github.com/hasura/graphql-engine-mono/pull/2357

GitOrigin-RevId: 1aeae25e321eee957e7645c436d17e69207309fd

2021-09-16 07:42:46 +00:00

1 Commits