graphql-engine

hasura/graphql-engine

Fork 0

mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-16 01:44:03 +03:00

Commit Graph

Author	SHA1	Message	Date
Samir Talwar	dd46aa6715	server: Preserve ordering when possible, and sort when it's not. When upgrading to GHC v9.4, we noticed a number of failures because the sort order of HashMaps has changed. With this changeset, I am endeavoring to mitigate this now and in the future. This makes one of two changes in a few areas where we depend on the sort order of elements in a `HashMap`: 1. the ordering of the request is preserved with `InsOrdHashMap`, or 2. we sort the data after retrieving it. Fortunately, we do not do this anywhere where we _must_ preserve order; it's "just" descriptions, error messages, and OpenAPI metadata. The main problem is that tests are likely to fail each time we upgrade GHC (or whatever is providing the hash seed). [NDAT-705]: https://hasurahq.atlassian.net/browse/NDAT-705?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9390 GitOrigin-RevId: 84503e029b44094edbbc298651744bc2843c15f3	2023-06-02 09:31:26 +00:00
Gil Mizrahi	ee15c804bc	server/postgres: prefix identifiers longer than 63 characters with their md5 hash PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5080 GitOrigin-RevId: 58e5e6aab136617d1bbfc6621c89942da358b04d	2022-07-22 15:29:02 +00:00
Evie Ciobanu	1843ee7b0b	[server] fix LIMIT optimization not respecting ORDER BY https://github.com/hasura/graphql-engine-mono/pull/2239 Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com> Co-authored-by: Rakesh Emmadi <12475069+rakeshkky@users.noreply.github.com> GitOrigin-RevId: fabc825239950b11d673cfd33e8075a01409bcf6	2021-09-21 10:40:24 +00:00

Author

SHA1

Message

Date

Samir Talwar

dd46aa6715

server: Preserve ordering when possible, and sort when it's not.

When upgrading to GHC v9.4, we noticed a number of failures because the sort order of HashMaps has changed. With this changeset, I am endeavoring to mitigate this now and in the future.

This makes one of two changes in a few areas where we depend on the sort order of elements in a `HashMap`:

  1. the ordering of the request is preserved with `InsOrdHashMap`, or
  2. we sort the data after retrieving it.

Fortunately, we do not do this anywhere where we _must_ preserve order; it's "just" descriptions, error messages, and OpenAPI metadata. The main problem is that tests are likely to fail each time we upgrade GHC (or whatever is providing the hash seed).

[NDAT-705]: https://hasurahq.atlassian.net/browse/NDAT-705?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/9390
GitOrigin-RevId: 84503e029b44094edbbc298651744bc2843c15f3

2023-06-02 09:31:26 +00:00

Gil Mizrahi

ee15c804bc

server/postgres: prefix identifiers longer than 63 characters with their md5 hash

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5080
GitOrigin-RevId: 58e5e6aab136617d1bbfc6621c89942da358b04d

2022-07-22 15:29:02 +00:00

Evie Ciobanu

1843ee7b0b

[server] fix LIMIT optimization not respecting ORDER BY

https://github.com/hasura/graphql-engine-mono/pull/2239

Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
Co-authored-by: Rakesh Emmadi <12475069+rakeshkky@users.noreply.github.com>
GitOrigin-RevId: fabc825239950b11d673cfd33e8075a01409bcf6

2021-09-21 10:40:24 +00:00

3 Commits