Commit Graph

42 Commits

Author SHA1 Message Date
Karthikeyan Chinnakonda
3d33017296 [RFC] disable query/subscription root fields
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4449
GitOrigin-RevId: f7f4e60250b4c7375a973d0e5770ac134217767a
2022-05-06 11:19:48 +00:00
Naveen Naidu
abb57e58c8 server/MSSQL: Event Delivery System (Incremental PR - 3)
</details>

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3392
Co-authored-by: Divi <32202683+imperfect-fourth@users.noreply.github.com>
GitOrigin-RevId: 9df6b0aa7d91f22571b72d3e467da23b916c9140
2022-04-21 07:20:34 +00:00
Karthikeyan Chinnakonda
a3e6b1c741 server/mssql: add support for creating event triggers (incremental PR #2)
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2634
Co-authored-by: Naveen Naidu <30195193+Naveenaidu@users.noreply.github.com>
GitOrigin-RevId: 29567fa336c22d1812dfcfa6294f54e74a741f0c
2022-03-03 09:53:49 +00:00
Abby Sassel
45c95d8cd8 server/tests: Add some detail to the hspec test style guide
[rendered](https://github.com/hasura/graphql-engine-mono/blob/hspec-docs/server/tests-hspec/README.md)

This PR adds a little detail to the style guide, from design discussions whilst writing the RFC and reviewing some recent PRs.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3815
GitOrigin-RevId: f6ead6b3327eed022b8b51083ab6b9508d89f3d0
2022-02-28 17:51:30 +00:00
Philip Lykke Carlsen
58a270a638 First attempt at describing MSSQL Json updates in an RFC
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3699
GitOrigin-RevId: bdf3b33d7c1200850a506f4e5a0448539563e8d7
2022-02-21 15:13:21 +00:00
Rakesh Emmadi
60183df1ea server/mssql: use temporary tables for insert mutation execution
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3205
GitOrigin-RevId: ff889ce43ed613c283edefa68992eab7c36db18c
2021-12-22 11:05:29 +00:00
Abby Sassel
1d39c9ca2f server/rfc: memorialise internal discussions in upserts RFC
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3001
GitOrigin-RevId: e58f3ea33b3d3a8ffb8d9ffddbc3c91eda0ed8f7
2021-11-29 15:51:01 +00:00
Abby Sassel
8975513600 server/rfc: upserts on SQL Server
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2706
GitOrigin-RevId: ace98da6426e9d08dbe5ab10b2b16777101d61f5
2021-11-15 14:45:27 +00:00
Abby Sassel
aa38733d3b server/rfc: update haskell test suite RFC with discussion
Document open Qs and design decisions from the last week (with @chrisdone @aniketd @0x777 @jkachmar). Please let me know if I've misunderstood anything, otherwise I'll assume agreement and try to get notes merged eod tomorrow.

[Rendered](https://github.com/hasura/graphql-engine-mono/pull/2827/files#diff-413b62860d531837479c6dd82ec2b2d9124861dd86a0d3ab67c5eaf7bff6d781).

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2827
GitOrigin-RevId: 34116cc119463dc1d67d4430dafba77cbbd941d6
2021-11-11 18:30:36 +00:00
Philip Lykke Carlsen
ef4d194d79 RFC: Column Mutability
This PR contains two pull requests:

[Identity Columns](https://github.com/hasura/graphql-engine-mono/blob/rfc/identity-columns/rfcs/identity-columns.md) collects information and product decisions about identity columns. There are some decisions we need to make explicit.

[Column Mutability](https://github.com/hasura/graphql-engine-mono/blob/rfc/identity-columns/rfcs/column-mutability.md) proposes an implementation strategy for identity columns and similar that should be able to elegantly accommodate differences among backends. The idea is to model the notion of _column mutability_ rather than e.g. identity columns directly.

Please volunteer your opinions and perspectives on these topics in the PR comments.

---
Closes #2407

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2507
GitOrigin-RevId: 5eb14a53504985fd32933c182bee4cc13bb70a02
2021-11-02 13:43:28 +00:00
David Overton
aac64f2c81 Source typename customization (close graphql-engine#6974)
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/1616
GitOrigin-RevId: f7eefd2367929209aa77895ea585e96a99a78d47
2021-10-29 14:43:14 +00:00
Phil Freeman
05c5df49b5 server/rfc: Haskell integration test suite
[Rendered](https://github.com/hasura/graphql-engine-mono/blob/phil/hspec-test-suite-rfc/rfcs/hspec-test-suite.md)

Related to (but more broadly scoped than) https://github.com/hasura/graphql-engine/issues/7137

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2423
Co-authored-by: Abby Sassel <3883855+sassela@users.noreply.github.com>
GitOrigin-RevId: 5845b0323653d2d8ccdce69c29855abb7f401b7a
2021-10-28 10:36:11 +00:00
Abby Sassel
7e3c9acfe2 server/mssql: delete mutations rfc
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2596
Co-authored-by: Gil Mizrahi <8547573+soupi@users.noreply.github.com>
GitOrigin-RevId: f6c0049114d4d009d588efe650aed1063a8b87ed
2021-10-26 13:24:04 +00:00
Karthikeyan Chinnakonda
8acd35c2e7 rfc: log DB stats when the catalog is migrated
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2637
GitOrigin-RevId: c605d93172ae3cbde669bcac76583fe3903dec34
2021-10-20 12:33:23 +00:00
Tirumarai Selvan
2406de7601 move pro rfcs to pro namespace
Many pro-only feature RFCs were added in `rfcs` folder which were shadowed in OSS repo

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2546
GitOrigin-RevId: 0ae965393c04398014f910b5c8ecd2dcb3d5f861
2021-10-08 14:57:02 +00:00
Gil Mizrahi
7366184cbb RFC: limit over join optimization
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2424
GitOrigin-RevId: 95da4151190dbd66a6cc8e14e0f78a0a3dbbb5e6
2021-10-06 08:47:44 +00:00
Philip Lykke Carlsen
c839fc55df Revise function-root-field-customisation.md
### Description
* Removed unresolved questions since resolved
* Change status 'draft' → 'published'

### Changelog

- [X] `no-changelog-required` .

### Related Issues

fix https://github.com/hasura/graphql-engine/issues/7405

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2496
GitOrigin-RevId: 0bdba7f5d52f2a4bd70c525dab12698e9ceddb28
2021-10-04 11:39:59 +00:00
Philip Lykke Carlsen
648c566d0b RFC: Customisability of function root field names
[Rendered](https://github.com/hasura/graphql-engine-mono/blob/plc/customise-function-root-field-names-rfc/rfcs/function-root-field-customisation.md)

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2419
GitOrigin-RevId: e55295993e919dbed7936dcca7dcb06b34b761c8
2021-10-04 08:42:08 +00:00
Robert
fbd1262ea6 server: operation timeout with postgres cancelling
### Description

This PR implements operation timeouts, as specced in #1232.

RFC: [rfcs/operation-timeout-api-limits.md](c025a90fe9/rfcs/operation-timeout-api-limits.md)

There's still some things to be done (tests and docs most notably), but apart from that it can
be reviewed. I'd still appreciate feedback on the RFC!

TODO:
- [x] break out the `ApiLimits` refactoring into a separate PR: #2103
- [x] finish the `pg-client-hs` PR: https://github.com/hasura/pg-client-hs/pull/39
- [x] remove configurability, after testing, prior to merging
- [ ] tests: #2390 has some tests that I've run locally to confirm things work on a fundamental level
- [x] changelog
- [x] documentation
- [x] fill in the detailed PR checklist

### Changelog

- [x] `CHANGELOG.md` is updated with user-facing content relevant to this PR. If no changelog is required, then add the `no-changelog-required` label.

### Affected components

- [x] Server
- [ ] Console
- [ ] CLI
- [x] Docs
- [ ] Tests

### Related Issues

Product spec: #1232.

### Solution and Design

Compare `rfcs/operation-timeout-api-limits.md`.

### Steps to test and verify

Configure operation timeouts, e.g. by posting

```
{
  "type": "set_api_limits",
  "args": {
    "operation_timeout": {
      "global": 3
    }
  }
}
```

to `v1/metadata` to set an operation timeout of 3s. Then verify that
1. non-admin queries that take longer than 3s time out with a nice error message
2. that those queries return after ~3s (at least for postgres)
3. also that everything else still works as usual

### Limitations, known bugs & workarounds
- while this will cause slow queries against any backends to fail, it's only verified to actually interrupt queries against postgres
- this will only successfully short-cut (cancel) queries to postgres if the database server is responsive

#### Catalog upgrade
Does this PR change Hasura Catalog version?
- [x] No

#### Metadata

Does this PR add a new Metadata feature?
- [x] Yes
  - Does `run_sql` auto manages the new metadata through schema diffing?
    - [x] Not required
  - Does `run_sql` auto manages the definitions of metadata on renaming?
    - [x] Not required
  - Does `export_metadata`/`replace_metadata` supports the new metadata added?
    - [x] Yes

#### GraphQL
- [x] No new GraphQL schema is generated

#### Breaking changes

- [x] No Breaking changes

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/1593
GitOrigin-RevId: f0582d0be3ed9fadf89e0c4aaf96344d18331dc4
2021-09-29 16:21:05 +00:00
Solomon Bothwell
4e05bdcaec Feature/request transform string interpolation
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2443
Co-authored-by: Tirumarai Selvan <8663570+tirumaraiselvan@users.noreply.github.com>
GitOrigin-RevId: d7d68984d0ae1403bb414572e9704c01ed27deab
2021-09-29 08:14:29 +00:00
Naveen Naidu
3d95c67748 server/query-tags: implement new metadata specification and API
https://github.com/hasura/graphql-engine-mono/pull/2203

GitOrigin-RevId: 6169fcce0c6dccaec055bf8e723e9aa7c19a7f0c
2021-09-23 12:38:56 +00:00
Karthikeyan Chinnakonda
37200f35bd RFC: Event triggers in SQL Server research
https://github.com/hasura/graphql-engine-mono/pull/2043

GitOrigin-RevId: 1e7a028199865c79bd0581b4a1b31dd9c63f8d88
2021-09-20 16:52:58 +00:00
Tirumarai Selvan
dc8aa9906c spec for multiple admin secrets
GitOrigin-RevId: 8778c498d90c50cc144ed49b47cbbb657e712545
2021-09-20 09:02:18 +00:00
Solomon Bothwell
af5ff07614 Request Transformations
https://github.com/hasura/graphql-engine-mono/pull/1984

Co-authored-by: jkachmar <8461423+jkachmar@users.noreply.github.com>
GitOrigin-RevId: 1767d6bdde48c156fe171b5a9b7e44d7f2eb4869
2021-09-16 11:03:57 +00:00
Philip Lykke Carlsen
8549035d9b RFC: (Table) Permissions in MySQL
This PR introduces an RFC for permissions in MySQL. (solves #2097)

[Rendered](https://github.com/hasura/graphql-engine-mono/blob/plc/rfc/mysql-permissions/rfcs/permissions-mysql.md)

https://github.com/hasura/graphql-engine-mono/pull/2183

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: e63fb9ddfd3a8752e28536818193b04403635f0d
2021-09-09 06:41:51 +00:00
Tirumarai Selvan
dd88ad9631 RFC: role-based allowlist spec
RFC version for https://github.com/hasura/graphql-engine-mono/issues/2273

[Rendered](https://github.com/hasura/graphql-engine-mono/blob/rfc/role-based-allow-list-spec/rfcs/role-based-allow-list.md)

https://github.com/hasura/graphql-engine-mono/pull/2278

GitOrigin-RevId: 6d08b293b2a7fb23845eaaa0231afbe3748d1086
2021-09-08 11:04:36 +00:00
Evie Ciobanu
7a1446cec2 [rfc] MySQL relationships
Closes https://github.com/hasura/graphql-engine-mono/issues/2096

This RFC describes the MySQL relationships feature - [rendered](https://github.com/hasura/graphql-engine-mono/blob/evie/rfc/mysql-relationships/rfcs/mysql-relationships.md)

https://github.com/hasura/graphql-engine-mono/pull/2115

GitOrigin-RevId: 9f086120e65bfee091fa4c4e75c0f00f1fe4229f
2021-08-27 08:44:50 +00:00
Rakesh Emmadi
11a31b3a75 server/rfc: mutations on MSSQL backend
[rendered](https://github.com/hasura/graphql-engine-mono/blob/rakeshkky/rfc/mssql-mutations/rfcs/mutations-mssql.md)

Open for suggestions/improvements. Please comment.

https://github.com/hasura/graphql-engine-mono/pull/1974

GitOrigin-RevId: 4c27d9da99e6b41efafa1c6e5557731cb16c488f
2021-08-18 10:57:54 +00:00
Karthikeyan Chinnakonda
06f5e4fb77 server: inherited roles for mutations, remote schemas, actions and custom functions
https://github.com/hasura/graphql-engine-mono/pull/1715

GitOrigin-RevId: 4818292cff8c3a5b264968e7032887a1e98b6f79
2021-08-09 10:21:05 +00:00
David Overton
1abb1dee69 Remote Schema Customization take 2 using parser tranformations
https://github.com/hasura/graphql-engine-mono/pull/1740

GitOrigin-RevId: e807952058243a97f67cd9969fa434933a08652f
2021-07-30 11:33:59 +00:00
Naveen Naidu
f49e13c890 server: SQL query tags for GQL operations (closes #400)
https://github.com/hasura/graphql-engine-mono/pull/1393

GitOrigin-RevId: f867c16d8281865dac38c91f7dfcbf5815de898c
2021-07-29 08:30:10 +00:00
Karthikeyan Chinnakonda
6bddaa7564 server: inherited roles improvements for select permissions only
https://github.com/hasura/graphql-engine-mono/pull/1539

GitOrigin-RevId: 7444973e9cc7e0598eeb1bd7951ad45dd37ec550
2021-07-16 21:19:58 +00:00
Vamshi Surabhi
96104ec1a8 Revert "remote schema typename customisation"
This reverts the remote schema type customisation and namespacing feature temporarily as we test for certain conditions.

GitOrigin-RevId: f8ee97233da4597f703970c3998664c03582d8e7
2021-06-10 09:57:16 +00:00
David Overton
4a69fdeb01 Dmoverton/5863 prefix namespacing
GitOrigin-RevId: 108e8b25e745cb4f74d143d316262049cef62b70
2021-06-09 22:42:05 +00:00
Solomon Bothwell
3ad4089126 Rewrites PG Client Cert RFC
GitOrigin-RevId: 430301a70c75ef000d2736a28dfb3da34307c5a8
2021-05-25 03:12:16 +00:00
Solomon Bothwell
6d2d2a5826 Postgres Client Cert Update
Co-authored-by: Lyndon Maydwell <92299+sordina@users.noreply.github.com>
GitOrigin-RevId: 50fe785fbc0156fc7df3ad3c71c8aca7c0256318
2021-05-21 01:50:43 +00:00
Vamshi Surabhi
ab1ccfdbcd rfc: permissions layer on functions (#384)
GitOrigin-RevId: 1eb01e0d4579298478cdb3d1f2669d902e466c48
2021-03-04 04:08:09 +00:00
Vamshi Surabhi
95fe9be148 rfc: optimistic concurrency control for metadata changes (#480)
GitOrigin-RevId: 9b6f10138777e1d078cad37b0325b9973566c0a0
2021-03-04 04:08:03 +00:00
Lyndon Maydwell
0767333597 server: support restified versions of graphql queries (#303)
Restified GraphQL Endpoints feature.

GitOrigin-RevId: 3d6e589426ec21a60a915b47f579f0ac4934af45
2021-01-29 01:03:35 +00:00
Aravind
1f2037947d
cli: manage seed migrations as sql files (close #2431) (#3763) 2020-06-16 17:45:04 +05:30
Vamshi Surabhi
8455817858
rfc: admin-only/backend-only insert permissions (#4120) 2020-05-21 09:38:49 -05:00
Vamshi Surabhi
7b045f1a24
rfc: check condition in update permissions (#3750) 2020-02-25 11:46:24 +05:30