2 Commits

Author	SHA1	Message	Date
Antoine Leblanc	d66d2d81fd	server: use placeholder to prevent empty query roots ... ### Description The GraphQL spec has to conflicting requirements: 1. an object must contain at least one field: the schema may not contain empty objects 2. the _query_root_ must always be present Given _1_, the schema generation code removes from the schema all fields that would result in empty objects, such as a table for which a user does not have select permissions. But, as a result, our code also potentially removes _query_root_ if it is empty, breaking _2_. This PR introduces a dummy "placeholder" field in the query root if it's empty, to ensure we never remove it from the schema. ### Remaining work - [x] changelog entry - [x] tests PR-URL: https://github.com/hasura/graphql-engine-mono/pull/148 GitOrigin-RevId: bfd6bfcc2f3de92900b6ba566012f093399ca037	2022-01-27 18:08:11 +00:00
Antoine Leblanc	e2ce1972f6	Prevent empty subscription roots (fix hasura/graphql-engine#6898) ... ### Description We always build a subscription root, even when there was no possible fields. This breaks some third party clients, as the spec does not allow empty types in the schema. This PR fixes this by changing the `buildSubscriptionParser` helper to return a `Maybe` value, and harmonizes / cleans places where we build the subscription root. https://github.com/hasura/graphql-engine-mono/pull/2357 GitOrigin-RevId: 1aeae25e321eee957e7645c436d17e69207309fd	2021-09-16 07:42:46 +00:00