Commit Graph

4 Commits

Author SHA1 Message Date
Samir Talwar
f566f55d02 server/pytest: Attempting to improve TestNamingConventions.
I found a couple of flaws in `TestNamingConventions` and friends:

1. We had two test cases with the same name, which means one of them
   would be overwritten. Renamed to avoid conflict.
2. The `skipif` check for
   `TestNamingConventionWithoutExperimentalFeature` seemed broken. I
   have fixed it by making it line up with its `reason`, and extracted
   some logic out into a function to avoid duplication.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4958
GitOrigin-RevId: f572d86c893135839dbaba70bf89984bc9d79331
2022-07-05 12:37:30 +00:00
paritosh-08
3d001fedb8 server: respect experimental flag for naming convention of table column names
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4845
GitOrigin-RevId: f1347ec64ff883d1dcc87e588a063557d37cb968
2022-06-30 05:57:18 +00:00
paritosh-08
42da1dbc2e server/docs: follow up on the naming convention
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4563
GitOrigin-RevId: 0ae1f226a63dae34e6cb0d001b4915c05b0974cf
2022-05-27 05:56:52 +00:00
paritosh-08
fd30fb343b server: naming conventions for auto generated fields
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3982
Co-authored-by: Brandon Simmons <210815+jberryman@users.noreply.github.com>
GitOrigin-RevId: f90b2e8f394e7bd69780f003d2d980475f104f42
2022-05-26 11:55:29 +00:00