Commit Graph

3834 Commits

Author SHA1 Message Date
Rakesh Emmadi
fbfdf9a04d server/mssql: restrict "count" aggregate query on multiple columns
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3354
GitOrigin-RevId: d9890782ff8e3ea40ec52c0da82e43ecf5c36d2b
2022-01-18 14:54:46 +00:00
Kirill Zaborsky
47b9321ba4 BigQuery operators: like/nlike, geography
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2924
GitOrigin-RevId: 3748411cb4419a21a58283836adb5cb39d351d19
2022-01-18 13:37:12 +00:00
hasura-bot
69ea0e7026 docs: add Koyeb as a deployment option
GITHUB_PR_NUMBER: 6859
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/6859

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/1270
Co-authored-by: Edouard Bonlieu <2520463+edouardb@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: c084a60b50b405452e60581e16dc27c1fa0b22fc
2022-01-18 12:34:15 +00:00
Gil Mizrahi
11478c0b44 docs: add sql server default values and column presets docs
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3361
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: 687461886076526311506ab5611859ba507e562a
2022-01-18 10:49:34 +00:00
Daniel Chambers
2c5cf6983b Fixed schema & table dropdowns being unsorted on 'create event trigger' page
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3385
GitOrigin-RevId: 619f1bb8b22e048b47b629a1b6b3315943f1b1fe
2022-01-18 08:50:10 +00:00
Auke Booij
a7dbe95666 Hlint all Haskell code
So far we've only used `hlint` to lint the OSS code. This moves some things around to lint the Pro code as well.

Note that the CI action only runs `hlint` on Haskell files that are _changed_ by a PR, relative to its merge-base (usually `main`).

As a reminder, you can use the `ignore-server-hlint-checks` label to prevent this from blocking a merge.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3383
GitOrigin-RevId: d5779c63d780f526a1d58ae4107f0d5262a23ec1
2022-01-18 04:06:15 +00:00
Robert
501cb32604 tests: drop stale coverage-related functionality from test-server.sh
This coverage-related functionality has been inactive for a while, so
chances are it's rotted by now anyway. Removing in order to make
things a little bit simpler.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3299
GitOrigin-RevId: 1ac4d4e101fecca1931a099bdcb7ed4dce675575
2022-01-18 03:19:03 +00:00
Rakesh Emmadi
f45130bc39 server/mssql: move mssql_run_sql test cases from v1/run_sql to v2/mssql/run_sql
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3370
GitOrigin-RevId: dfeb6e2dfda3fbe6ec2d318909dc793042b86d04
2022-01-18 02:21:04 +00:00
Abhijeet Khangarot
54b5088acf rename webhook transforms to REST Connectors
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3334
Co-authored-by: Tirumarai Selvan <8663570+tirumaraiselvan@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 6722cc6449daa5111aa3d6afca8909c5af525bf7
2022-01-17 13:28:04 +00:00
Kirill Zaborsky
7beb15b4a3 distinct_on for BigQuery
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3191
GitOrigin-RevId: e9f1c814b2caf09946389c4bcb30a0c42277abaf
2022-01-17 10:02:17 +00:00
hasura-bot
bd8766171f docs: clarify server console in migrations guide
GITHUB_PR_NUMBER: 8030
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8030

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3366
Co-authored-by: Forrest <581906+factoidforrest@users.noreply.github.com>
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 3e6bd918160aaa314a59aaa708e35fb5789c04e0
2022-01-17 08:02:54 +00:00
Vamshi Surabhi
2e1be1d2c5 bump python test suite dependencies
This PR upgrades some of the pinned dependencies do not build with python 3.10 - cffi, ruamel, py. Further, it upgrades other packages where the effort is minimal.

For the reviewers: Please review it commit by commit.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3367
GitOrigin-RevId: c5401fe289d3185a79c4d382297f86fbde139825
2022-01-17 07:40:56 +00:00
Rakesh Emmadi
08f1725698 server/mssql: expand transactions to GraphQL queries and mssql_run_sql API
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3286
GitOrigin-RevId: 0b37767e271dfa43d36fa7f7cc9928ba6a22964d
2022-01-14 14:09:22 +00:00
hasura-bot
d5e2d613f0 cli: stop using healthz endpoint
GITHUB_PR_NUMBER: 7994
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/7994

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3268
Co-authored-by: Romain Briand <183016+romainbriand@users.noreply.github.com>
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: e034fddaea604ba98797e2d9dcab779b2cc21378
2022-01-14 04:17:41 +00:00
Gil Mizrahi
ac8f9daaa9 Use hspec-discover for hspec-tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3328
GitOrigin-RevId: 5f1cfc43434d971083b32e992e40f348bbf75ecd
2022-01-13 21:14:53 +00:00
Kirill Zaborsky
560daa63a8 BigQuery: fix support for joins in nodes of aggregate queries
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3233
GitOrigin-RevId: a3a4624d5cd0c4c562e27d1e3605882e7f5a3d0d
2022-01-13 15:09:52 +00:00
Evie Ciobanu
db22401e4f server: document python integration test suite
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3350
GitOrigin-RevId: 47dcebbfa84ed3681da40b3ea52e9b849b2fe8e4
2022-01-13 14:29:10 +00:00
hasura-bot
555f2aed89 Update README.turkish.md
GITHUB_PR_NUMBER: 7967
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/7967

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3212
Co-authored-by: melkecelioglu <67334822+melkecelioglu@users.noreply.github.com>
GitOrigin-RevId: fc1254d576daa5803b77db170df99041e6af2483
2022-01-13 13:44:29 +00:00
Rakesh Emmadi
42a2787290 server/mssql: update odbc git reference to the commit which has error message fix
## Description

I come across a flaky test due to inconsistent error messages from the odbc lib we use for MSSQL database interactions.
```
cabal new-run -- test:graphql-engine-tests mssql
Up to date

Database.MSSQL.TransactionSpec
  runTx
    runs command in a transaction
    commits a successful transaction, returning a single field
    commits a successful transaction, returning multiple fields
    an unsuccesful transaction, expecting Int
    a successfull query expecting multiple rows
    an unsuccesful transaction; expecting single row
    displays the SQL Server error on an unsuccessful transaction FAILED [1]
    rolls back an unsuccessful transaction

Failures:

  src-test/Database/MSSQL/TransactionSpec.hs:60:15:
  1) Database.MSSQL.TransactionSpec.runTx displays the SQL Server error on an unsuccessful transaction
       expected: UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type."
        but got: UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The definition for column 'INVALID_SYNTAX' must include a data type.\DEL"

  To rerun use: --match "/Database.MSSQL.TransactionSpec/runTx/displays the SQL Server error on an unsuccessful transaction/"

Randomized with seed 1101559172

Finished in 0.2140 seconds
8 examples, 1 failure
```
From above, we got a error message with `\DEL` appended. It is also driving the tests to fail in the CI on random PRs.

We brought this into notice of "fpco", the authors of the library and they got us a [quick fix](https://github.com/fpco/odbc/pull/43), which also improves the errors by removing the redundancy of the error message.

In this PR
- We update the `odbc` library git reference to fc5b592a60
- Update the error messages in tests to conform with improved error messages from `odbc`

## Related issues
Closes https://github.com/hasura/graphql-engine-mono/issues/3340

## Changelog

-  `CHANGELOG.md` is updated with user-facing content relevant to this PR.

## Affected components
-  server
-  tests

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3345
GitOrigin-RevId: a5694e8afb58b5ad71b9c9635a80dea1ec449f51
2022-01-13 11:15:01 +00:00
Evie Ciobanu
e30d51ee38 server: bump pytest version
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3348
GitOrigin-RevId: b1fd23da3c8af59e28575438ebffe75f6fb79428
2022-01-13 10:30:55 +00:00
Ikechukwu Eze
c01232ea13 console: create a hook for each loadShema sql queries
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3016
GitOrigin-RevId: 030eef3b8e71281c419f8f7ec6dcbd40a085be74
2022-01-13 09:24:31 +00:00
Vijay Prasanna
3d2dfc6077 console: fixes failing tests on modify page for tables
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3357
GitOrigin-RevId: 0672b1b7c82c7d99cf7a403cf535d435cbc8d887
2022-01-13 08:33:56 +00:00
Divi
5723baaab4 cli: fix migrate create command behaviour when no data provided
closes https://github.com/hasura/graphql-engine/issues/7971

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3292
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: 4f7e38d649c1f414132d576d0f288ca8d3cdb53d
2022-01-12 16:16:50 +00:00
Kali Vara Purushotham Santhati
695164b176 cli: misc changes
- Hasura CLI shows metadata diff in YAML for type `json` in directory mode. The expected behaviour is to show the diff in JSON
- The unified-json shows diff in YAML, not in JSON.
- Add new diff type unified-yaml which shows the diff in YAML unified format.
- Check the flag value of type in `hasura metadata diff --type`
- The help text of `seed apply`( `hasura seed apply --file seeds/1234_add_some_seed_data.sql`) should be updated to `hasura seed apply --file 1234_add_some_seed_data.sql --database-name default` and similarly in docs.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3246
Co-authored-by: Aravind K P <8335904+scriptonist@users.noreply.github.com>
GitOrigin-RevId: 1d16ad9ea4dd366af32498ce878ae132bd239be9
2022-01-12 13:25:22 +00:00
Rishichandra Wawhal
f99ba4ab55 cloud docs: remove unmaintained redundant changelog
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3347
GitOrigin-RevId: 1c3b98c105a89498853fb599d593c5ecd3483a54
2022-01-12 12:04:11 +00:00
Abhijeet Khangarot
30c4c4cfbb docs: update docs for webhook transforms
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3206
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tirumarai Selvan <8663570+tirumaraiselvan@users.noreply.github.com>
GitOrigin-RevId: 84c2dd89fffdc9e48c77c3c11444023c517cdb9c
2022-01-12 12:01:17 +00:00
hasura-bot
890b6714ba console: migrate some components to TypeScript
GITHUB_PR_NUMBER: 7984
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/7984

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3244
Co-authored-by: yuta-ike <38308823+yuta-ike@users.noreply.github.com>
Co-authored-by: Varun Choudhary <68095256+Varun-Choudhary@users.noreply.github.com>
GitOrigin-RevId: dae29147e5675871ed698729a34da4624f3ad359
2022-01-12 09:44:32 +00:00
hasura-bot
5f37f28fda console: migrate ColumnCreator component to TypeScript
GITHUB_PR_NUMBER: 7981
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/7981

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3243
Co-authored-by: yuta-ike <38308823+yuta-ike@users.noreply.github.com>
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: ce02bafa52eba26176e1295d0a526112244dadc0
2022-01-12 07:26:19 +00:00
Vishnu Bharathi
214191ab5c ci: add hotfix oss console pipeline
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3221
GitOrigin-RevId: 8dc60862eb75e3988a7add72d9b7d33f20a62048
2022-01-12 04:38:21 +00:00
Robert
a3e042c9ba tests: fail don't skip if the environment isn't right for webhook tests
This removes a weird bit of code that skips the webhook tests if the tests aren't run
as root. We want those tests to run, so they should fail if they can't run. The
check passes on buildkite, so it's all a bit theoretical.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3298
GitOrigin-RevId: c930b5baab07f8e33a4bcf54df251d84e55b412f
2022-01-11 15:29:35 +00:00
Gil Mizrahi
fe41fbabbd mssql: Test upserts with permissions
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3280
GitOrigin-RevId: 861d4db59f75c83daef975fb3471b3c07889c9bc
2022-01-11 13:36:56 +00:00
Robert
b892927c45 tests: run server test shell files through shfmt for consistent indentation
I don't have any particular opinion on what would be a desirable format,
it's just a pain working on them as is.

This is the first in a series of several smallish changes largely to `test-server.sh`,
chipping away at it to make things a bit less convoluted. Ultimately I'm trying to
run the python tests against graphql-engine-pro, but to get there I need to get
a bit more structure into what we have.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3297
GitOrigin-RevId: 08ecf0604a4d8ace73e9f008bf4abfbf7bdb9393
2022-01-11 11:22:42 +00:00
Naveen Naidu
d097aea394 server/mssql: Add omitNothingFields to MSSQLConnConfiguration
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3325
GitOrigin-RevId: 09f11073a9ef37f10281b778c6884fa420dece20
2022-01-11 09:52:00 +00:00
Vijay Prasanna
b791cd3866 console: enable oss auth layer
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3269
GitOrigin-RevId: e9135475f63263512c2c3f487c1fbfed9014e2a6
2022-01-11 09:12:23 +00:00
Evie Ciobanu
463a303390 server: add MSSQL module haddocks
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3293
GitOrigin-RevId: 3062d5b1f41ce1fb18afc78773a2c947d8765309
2022-01-10 22:55:48 +00:00
hasura-bot
866476ab36 docs: update references, api signatures, image widths
GITHUB_PR_NUMBER: 8011
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8011

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3317
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 90c8f75003a07c5153c9e478efa599ab0bfb85d9
2022-01-10 18:40:21 +00:00
Ikechukwu Eze
1691e93c96 console: rename Timeout to Operation time limit
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3312
GitOrigin-RevId: 8e54fd39c9193107f5c1b5c45089d9440d4b3d66
2022-01-10 13:09:59 +00:00
hasura-bot
57f38d8d7c Update README.md
GITHUB_PR_NUMBER: 8006
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/8006

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3295
Co-authored-by: Benjamin Kniffler <4349324+bkniffler@users.noreply.github.com>
GitOrigin-RevId: 02c45f3bd91ee4fd5fc77a97f466686127bc6425
2022-01-10 06:21:05 +00:00
Chris Done
14bf8ba1be hspec: Tests for MySQL equivalent to the ones from the Python suite. close hasura/graphql-engine#7757
This fills in the gaps specified in this comment: https://github.com/hasura/graphql-engine/issues/7757#issuecomment-979948890 From the issue regarding fleshing out all MySQL tests that we already had in the python suite.

I'll push commits here.

Closes https://github.com/hasura/graphql-engine/issues/7757

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3271
GitOrigin-RevId: 9f68ed1c2b81cae1d479f9482c975f18a699c93a
2022-01-07 17:52:53 +00:00
Abhijeet Khangarot
21d1baecb4 console: refactor getSetCommentSql signature
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3214
Co-authored-by: Vijay Prasanna <11921040+vijayprasanna13@users.noreply.github.com>
GitOrigin-RevId: c07a47bd88f173280ad8b1f14765e85bb8ea3ed6
2022-01-07 06:54:42 +00:00
Gil Mizrahi
59ab1bbe57 refactor Hasura.Backends.MSSQL.Instances.Execute
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3265
GitOrigin-RevId: f7faa22be30ecc5a876dc40ad93cb8d2452de65e
2022-01-06 09:49:58 +00:00
Gil Mizrahi
22a8f15017 docs: adding mssql insert and upsert docs
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3052
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: ad54607093aa5a353c2fbc01b51558ab192bdef9
2022-01-05 16:39:49 +00:00
Divya Bhushan
0406c8ad86 docs: add steps to create remote schema permissions + fix adding remote schema docs
<!-- Thank you for ss in the Title above ^ -->

## Description ✍️
<!-- Please fill this se-->
<!-- Describe the changes from a user's perspective -->
Included steps on how to create a user role and then restrict the user's access on certain fields on a remote schema.
Page edited: [Remote schema permissions](https://hasura.io/docs/latest/graphql/core/remote-schemas/auth/remote-schema-permissions.html)

### Related Issues ✍
[#1047](https://github.com/hasura/graphql-engine-mono/issues/1047)
<!-- Please make sure you e -->
<!-- Add the issue number below (e.g. #234) -->

### Steps to test and verify ✍
<!-- If this is a feature, w bug-fix, how do we verify the fix? -->
View the deployed preview page [here](https://deploy-preview-3229--hasura-docs-mono.netlify.app/graphql/core/remote-schemas/auth/remote-schema-permissions.html#create-remote-schema-permissions).

## Changelog ✍️

-  `CHANGELOG.md` is updated with user-facing content relevant to this PR.
  If no changelog is required, then add the `no-changelog-required` label.

## Affected components ✍️
<!-- Remove non-affected components from the list -->

-  Docs

---

### Kodiak commit message
Information used by [Kodiak bot](https://kodiakhq.com/) while merging this PR.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3229
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 7f963357afc129ba4553b270dbbc21a6f35066d6
2022-01-05 12:46:18 +00:00
hasura-bot
b67ae48430 docs: remove duplicated screenshot from dedicated vpc
GITHUB_PR_NUMBER: 7654
GITHUB_PR_URL: https://github.com/hasura/graphql-engine/pull/7654

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2531
Co-authored-by: Shahidh K Muhammed <4124733+shahidhk@users.noreply.github.com>
GitOrigin-RevId: 3b0d01abaeba708cef0078310d2df041f56b7e12
2022-01-05 11:14:01 +00:00
Philip Lykke Carlsen
304ec36c3a (Fix #3154) Remove occurrences of Text in MSSQL IR in favor of dedicated data types.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3264
GitOrigin-RevId: 923ea2794bef9850f1aa5714b610890d02165882
2022-01-05 11:10:39 +00:00
Rakesh Emmadi
f49bb2b180 server/mssql: rollback a transaction based on the transaction state
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3247
GitOrigin-RevId: 70307d8723a63b9314b6ff4d897dcac6e8e93fb9
2022-01-05 08:03:59 +00:00
Vishnu Bharathi
777a78ceff ci: automatically computes SHA for dockerfiles
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3193
GitOrigin-RevId: 34aa92c7e03b1b9bf10f7b3177d9d9a1fd44a8ac
2022-01-05 04:52:21 +00:00
Divya Bhushan
e59113f364 docs: minor editions on Access control page
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3263
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
GitOrigin-RevId: 08caf7df10cad0aea0916327736147a0a8f808d1
2022-01-04 12:41:30 +00:00
Naveen Naidu
3a8fadb22b server/mssql: support read replicas
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2578
Co-authored-by: Rikin Kachhia <54616969+rikinsk@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: 88a02f8a617006853b350f48f4317c78ab97435b
2022-01-04 11:54:56 +00:00
Kirill Zaborsky
71f2d04b4f Disable pretty printing in BigQuery responses
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3222
GitOrigin-RevId: 03cf0670d949efa7cdd16ee55124925fd54a31c0
2022-01-04 10:57:15 +00:00