mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-18 21:12:09 +03:00
a5589c185b
### Description
During the PDV refactor that led to 2.0, we broke an undocumented and untested semantic of inserts: accepting _explicit_ null values in nested object inserts.
In short: in the schema, we often distinguish between _explicit_ null values `{id: 3, author: null}` and _implicit_ null values that correspond to the field being omitted `{id: 3}`. In this particular case, we forgot to accept explicit null values. Since the field is optional (meaning we accept implicit null values), it was nullable in the schema, like it was in pre-PDV times. But in practice we would reject explicit nulls.
This PR fixes this, and adds a test. Furthermore, it does a bit of a cleanup of the Mutation part of the schema, and more specifically of all insertion code.
https://github.com/hasura/graphql-engine-mono/pull/2341
GitOrigin-RevId: 895cfeecef7e8e49903a3fb37987707150446eb0
|
||
|---|---|---|
| .. | ||
| articles_author_upsert_fail.yaml | ||
| articles_with_author_author_id_fail.yaml | ||
| articles_with_author_null.yaml | ||
| articles_with_author_returning.yaml | ||
| articles_with_author.yaml | ||
| author_one.yaml | ||
| author_upsert_articles_fail.yaml | ||
| author_upsert_one_no_update.yaml | ||
| author_upsert_one_update.yaml | ||
| author_with_articles_author_id_fail.yaml | ||
| author_with_articles_empty.yaml | ||
| author_with_articles_null.yaml | ||
| author_with_articles_one.yaml | ||
| author_with_articles.yaml | ||
| author_with_detail_fk.yaml | ||
| author_with_detail.yaml | ||
| schema_setup.yaml | ||
| schema_teardown.yaml | ||
| values_setup.yaml | ||
| values_teardown.yaml | ||