mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-22 23:11:41 +03:00
eab4f75212
This introduces an `ErrorMessage` newtype which wraps `Text` in a manner which is designed to be easy to construct, and difficult to deconstruct. It provides functionality similar to `Data.Text.Extended`, but designed _only_ for error messages. Error messages are constructed through `fromString`, concatenation, or the `toErrorValue` function, which is designed to be overridden for all meaningful domain types that might show up in an error message. Notably, there are not and should never be instances of `ToErrorValue` for `String`, `Text`, `Int`, etc. This is so that we correctly represent the value in a way that is specific to its type. For example, all `Name` values (from the _graphql-parser-hs_ library) are single-quoted now; no exceptions. I have mostly had to add `instance ToErrorValue` for various backend types (and also add newtypes where necessary). Some of these are not strictly necessary for this changeset, as I had bigger aspirations when I started. These aspirations have been tempered by trying and failing twice. As such, in this changeset, I have started by introducing this type to the `parseError` and `parseErrorWith` functions. In the future, I would like to extend this to the `QErr` record and the various `throwError` functions, but this is a much larger task and should probably be done in stages. For now, `toErrorMessage` and `fromErrorMessage` are provided for conversion to and from `Text`, but the intent is to stop exporting these once all error messages are converted to the new type. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5018 GitOrigin-RevId: 84b37e238992e4312255a87ca44f41af65e2d89a
63 lines
1.4 KiB
YAML
63 lines
1.4 KiB
YAML
- description: Test that a tracked VOLATILE function works as a mutation
|
|
url: /v1/graphql
|
|
status: 200
|
|
query:
|
|
query: |
|
|
mutation {
|
|
add_to_score(args: {search: "Bla", increment: 3}){
|
|
name
|
|
score
|
|
role_echo
|
|
}
|
|
}
|
|
response:
|
|
data:
|
|
add_to_score:
|
|
- name: Starke Blake
|
|
score: 3
|
|
role_echo: admin
|
|
- name: Bellamy Blake
|
|
score: 13
|
|
role_echo: admin
|
|
- name: Dora Black
|
|
score: 53
|
|
role_echo: admin
|
|
|
|
- description: Test that defaults in SQL function become default parameters in schema
|
|
url: /v1/graphql
|
|
status: 200
|
|
query:
|
|
# We omit 'increment' here, defaulting to 1
|
|
query: |
|
|
mutation {
|
|
add_to_score(args: {search: "Blake"}){
|
|
name
|
|
score
|
|
}
|
|
}
|
|
response:
|
|
data:
|
|
add_to_score:
|
|
- name: Starke Blake
|
|
score: 4
|
|
- name: Bellamy Blake
|
|
score: 14
|
|
|
|
- description: Sanity check that VOLATILE function didn't end up in query root too
|
|
url: /v1/graphql
|
|
# FIXME: here and elsewhere: https://github.com/hasura/graphql-engine/issues/6106
|
|
status: 200
|
|
query:
|
|
query: |
|
|
query {
|
|
add_to_score(args: {search: "Bla", increment: 3}){
|
|
name
|
|
}
|
|
}
|
|
response:
|
|
errors:
|
|
- extensions:
|
|
path: $.selectionSet.add_to_score
|
|
code: validation-failed
|
|
message: "field 'add_to_score' not found in type: 'query_root'"
|