mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-15 09:22:43 +03:00
504f13725f
> High-Level TODO: * [x] Code Changes * [x] Tests * [x] Check that pro/multitenant build ok * [x] Documentation Changes * [x] Updating this PR with full details * [ ] Reviews * [ ] Ensure code has all FIXMEs and TODOs addressed * [x] Ensure no files are checked in mistakenly * [x] Consider impact on console, cli, etc. ### Description > This PR adds support for adding set-cookie header on the response from the auth webhook. If the set-cookie header is sent by the webhook, it will be forwarded in the graphQL engine response. Fixes a bug in test-server.sh: testing of get-webhook tests was done by POST method and vice versa. To fix, the parameters were swapped. ### Changelog - [x] `CHANGELOG.md` is updated with user-facing content relevant to this PR. ### Affected components - [x] Server - [ ] Console - [ ] CLI - [x] Docs - [ ] Community Content - [ ] Build System - [x] Tests - [ ] Other (list it) ### Related Issues -> Closes [#2269](https://github.com/hasura/graphql-engine/issues/2269) ### Solution and Design > ### Steps to test and verify > Please refer to the docs to see how to send the set-cookie header from webhook. ### Limitations, known bugs & workarounds > - Support for only set-cookie header forwarding is added - the value forwarded in the set-cookie header cannot be validated completely, the [Cookie](https://hackage.haskell.org/package/cookie) package has been used to parse the header value and any unnecessary information is stripped off before forwarding the header. The standard given in [RFC6265](https://datatracker.ietf.org/doc/html/rfc6265) has been followed for the Set-Cookie format. ### Server checklist #### Catalog upgrade Does this PR change Hasura Catalog version? - [x] No - [ ] Yes - [ ] Updated docs with SQL for downgrading the catalog #### Metadata Does this PR add a new Metadata feature? - [x] No #### GraphQL - [x] No new GraphQL schema is generated - [ ] New GraphQL schema is being generated: - [ ] New types and typenames are correlated #### Breaking changes - [x] No Breaking changes PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2538 Co-authored-by: Robert <132113+robx@users.noreply.github.com> GitOrigin-RevId: d9047e997dd221b7ce4fef51911c3694037e7c3f
38 lines
774 B
Plaintext
38 lines
774 B
Plaintext
test-server-flags
|
|
haskell-tests
|
|
no-auth
|
|
admin-secret
|
|
admin-secret-unauthorized-role
|
|
jwt
|
|
jwt-stringified
|
|
jwt-audience-check-single-string
|
|
jwt-audience-check-list-string
|
|
jwt-issuer-check
|
|
jwt-with-claims-namespace-path
|
|
jwt-claims-map-with-json-path-values
|
|
jwt-claims-map-with-literal-values
|
|
jwt-with-expiry-time-leeway
|
|
jwt-cookie
|
|
cors-domains
|
|
auth-webhook-cookie
|
|
ws-init-cookie-read-cors-enabled
|
|
ws-init-cookie-noread
|
|
ws-init-cookie-read-cors-disabled
|
|
ws-graphql-api-disabled
|
|
ws-metadata-api-disabled
|
|
remote-schema-permissions
|
|
function-permissions
|
|
roles-inheritance
|
|
remote-schema-https
|
|
query-caching
|
|
query-logs
|
|
webhook-request-context
|
|
post-webhook
|
|
get-webhook
|
|
insecure-webhook
|
|
insecure-webhook-with-admin-secret
|
|
allowlist-queries
|
|
jwk-url
|
|
horizontal-scaling
|
|
developer-api-tests
|