mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-14 17:02:49 +03:00
b3641238a9
<!-- Thank you for submitting this PR! :) --> ## Description It turns out that every usage of `Builder::allow_all_namespaced` concerned itself with either introspection nodes or (in the GDS case) `None`. Combined with the fact that both the SDL and GDS implementations of `SchemaContext::introspection_namespace_node` were trivial, the `NamespacedNodeInfo` contained in `Namespaced::AllowAll(S::NamespacedNodeInfo)` is always functionally meaningless. This PR removes the `NamespacedNodeInfo` from `Namespaced::AllowAll` as well as `SchemaContext::introspection_namespace_node`, thus simplifying the implementation. <!-- Questions to consider answering: 1. What user-facing changes are being made? 2. What are issues related to this PR? (Consider adding `(close #<issue-no>)` to the PR title) 3. What is the conceptual design behind this PR? 4. How can this PR be tested/verified? 5. Does the PR have limitations? 6. Does the PR introduce breaking changes? --> ## Changelog - Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact. See [changelog guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide). - If no changelog is required ignore/remove this section and add a `no-changelog-required` label to the PR. ### Product _(Select all products this will be available in)_ - [ ] community-edition - [ ] cloud <!-- product : end : DO NOT REMOVE --> ### Type <!-- See changelog structure: https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog --> _(Select only one. In case of multiple, choose the most appropriate)_ - [ ] highlight - [ ] enhancement - [ ] bugfix - [ ] behaviour-change - [ ] performance-enhancement - [ ] security-fix <!-- type : end : DO NOT REMOVE --> ### Changelog entry <!-- - Add a user understandable changelog entry - Include all details needed to understand the change. Try including links to docs or issues if relevant - For Highlights start with a H4 heading (#### <entry title>) - Get the changelog entry reviewed by your team --> _Replace with changelog entry_ <!-- changelog-entry : end : DO NOT REMOVE --> <!-- changelog : end : DO NOT REMOVE --> V3_GIT_ORIGIN_REV_ID: 1525905488203ff07182aa700c9fff26512743ab |
||
---|---|---|
.. | ||
benches | ||
src | ||
tests | ||
Cargo.toml |