mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-18 21:12:09 +03:00
81d9071948
## Description When setting up a remote relationship to a remote schema, values coming from the left-hand side are given as _arguments_ to the targeted field of the remote schema. In turn, that means we need to adjust the arguments to that remote field; in the case of input objects, it means creating a brand new input object in which the relevant fields have been removed. To both avoid conflicts, and be explicit, we give a pretty verbose name to such an input object: its original name, followed by "remote_rel", followed by the full name of the field (table name + relationship name). The bug there was introduced when working on extending remote relationships to other backends: we changed the code that translates the table name to a graphql identifier to be generic, and use the table's `ToTxt` instance instead. However, when a table is not in the default schema, the character used by that instance is `.`, which is not a valid GraphQL name. This PR fixes it, by doing two things: - it defines a safe function to translate LHS identifiers to graphql names (by replacing all invalid characters by `_`) - it doesn't use `unsafeMkName` anymore, and checks at validation time that the type name is correct ## Further work On this PR: - [x] add a test - [x] write a Changelog entry Beyond this PR, we might want to: - prioritize #1747 - analyze all calls to `unsafeMkName` and remove as many as possible PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3363 GitOrigin-RevId: fe98eb1d34157b2c8323af453f5c369de616af38
121 lines
2.7 KiB
YAML
121 lines
2.7 KiB
YAML
type: bulk
|
|
args:
|
|
|
|
# To model this:
|
|
|
|
# query {
|
|
# profiles {
|
|
# id
|
|
# message {
|
|
# id
|
|
# msg
|
|
# }
|
|
# }
|
|
# }
|
|
|
|
#Profile table
|
|
|
|
- type: run_sql
|
|
args:
|
|
sql: |
|
|
create schema custom;
|
|
create table custom.profiles (
|
|
id serial primary key,
|
|
name text
|
|
);
|
|
insert into custom.profiles (name) values
|
|
( 'alice' ),
|
|
( 'bob' ),
|
|
( 'alice');
|
|
|
|
create table authors (
|
|
id serial primary key,
|
|
name text
|
|
);
|
|
create table employees (
|
|
id serial primary key,
|
|
name text
|
|
);
|
|
insert into employees (name) values ('alice'),(NULL),('bob');
|
|
create table students (
|
|
id serial primary key,
|
|
name text not null,
|
|
physics integer,
|
|
maths integer
|
|
);
|
|
insert into students (name, physics, maths) values ('alice', 45, 48), ('bob', 32, 40);
|
|
create function total_marks(student_row students)
|
|
returns integer as $$
|
|
select student_row.physics + student_row.maths
|
|
$$ language sql stable;
|
|
create function total_marks_offset(student_row students, "offset" integer)
|
|
returns integer as $$
|
|
select student_row.physics + student_row.maths - "offset"
|
|
$$ language sql stable;
|
|
create function total_marks_session(student_row students, hasura_session json)
|
|
returns integer as $$
|
|
select student_row.physics + student_row.maths - (hasura_session ->> 'x-hasura-offset')::integer
|
|
$$ language sql stable;
|
|
create table regression_7172 (
|
|
id serial primary key,
|
|
features json
|
|
);
|
|
insert into regression_7172 (features) values ('{"Start Color":44}');
|
|
|
|
- type: track_table
|
|
args:
|
|
schema: custom
|
|
name: profiles
|
|
|
|
- type: add_remote_schema
|
|
args:
|
|
name: my-remote-schema
|
|
definition:
|
|
url: http://localhost:4000
|
|
forward_client_headers: false
|
|
|
|
- type: track_table
|
|
args:
|
|
schema: public
|
|
name: authors
|
|
|
|
- type: track_table
|
|
args:
|
|
schema: public
|
|
name: employees
|
|
|
|
- type: track_table
|
|
args:
|
|
schema: public
|
|
name: students
|
|
|
|
- type: add_computed_field
|
|
args:
|
|
table: students
|
|
name: total_marks
|
|
definition:
|
|
function: total_marks
|
|
table_argument: student_row
|
|
|
|
- type: add_computed_field
|
|
args:
|
|
table: students
|
|
name: total_marks_offset
|
|
definition:
|
|
function: total_marks_offset
|
|
table_argument: student_row
|
|
|
|
- type: add_computed_field
|
|
args:
|
|
table: students
|
|
name: total_marks_session
|
|
definition:
|
|
function: total_marks_session
|
|
table_argument: student_row
|
|
session_argument: hasura_session
|
|
|
|
- type: track_table
|
|
args:
|
|
schema: public
|
|
name: regression_7172
|