We currently have a fairly intricate way of running our PostgreSQL and MSSQL integration tests (not the API tests). By splitting them out, we can simplify this a lot. Most prominently, we can rely on Cabal to be our argument parser instead of writing our own. We can also simplify how they're run in CI. They are currently (weirdly) run alongside the Python integration tests. This breaks them out into their own jobs for better visibility, and to avoid conflating the two. The changes are as follows: - The "unit" tests that rely on a running PostgreSQL database are extracted out to a new test directory so they can be run separately. - Most of the `Main` module comes with them. - We now refer to these as "integration" tests instead. - Likewise for the "unit" tests that rely on a running MS SQL Server database. These are a little simpler and we can use `hspec-discover`, with a `SpecHook` to extract the connection string from an environment variable. - Henceforth, these are the MS SQL Server integration tests. - New CI jobs have been added for each of these. - There wasn't actually a job for the MS SQL Server integration tests. It's pretty amazing they still run well. - The "haskell-tests" CI job, which used to run the PostgreSQL integration tests, has been removed. - The makefiles and contributing guide have been updated to run these. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6912 GitOrigin-RevId: 67bbe2941bba31793f63d04a9a693779d4463ee1
13 KiB
Tips and tricks
This document contains various tips and tricks to make development easier.
Table of contents
- Use curl and yaml2json to test the graphql-engine API directly
- Convert a test case to a live example
- Run a remote MSSQL instance with dev.sh
- Add a unit test for SQL generation
- Benchmark a query on postgres
- Automatically run unit tests on change
Use curl and yaml2json to test the graphql-engine API directly
- yaml2json - many of our tests are written in yaml, this utility can convert them to json which graphql-engine understands
Example invocation:
cat /tmp/metadata.yaml | yaml2json | curl -d @- http://localhost:8181/v1/metadata
Convert a test case to a live example
To manually run an integration test one needs to:
- Run
scripts/dev.sh <postgres|graphql-engine|mssql>
- import the metadata or connect to DBs as you need
- initialise the MSSQL DB with the raw SQL page
- test the thing via GraphiQL
Fortunately this process can be somewhat automated.
We'll use the TestGraphQLQueryBasicMSSQL
test as an example.
Prerequisites
- yaml2json
- curl
Start-up graphql-engine
First step stays the same. Start up the relevant databases and graphql-engine in seperate terminals.
We also need mssql for this test, this can be skipped if you're testing postgres for example.
scripts/dev.sh postgres
scripts/dev.sh mssql
scripts/dev.sh graphql-engine
Connect to a database
In the case of mssql, we also need to register the database. This can be done in the hasura console but going to
the DATA
tab, then Manage
button on the left and then Connect Database
button. Add a mssql database with the
connection string that scripts/dev.sh mssql
outputed.
Note: the database name should match the source
field that tests use. In mssql's case this is usually mssql
.
Setup schema
The test TestGraphQLQueryBasicMSSQL
is defined in server/tests-py/test_graphql_queries.py
.
From there we can learn that the test files are found in the dir
server/tests-py/queries/graphql_query/basic
.
For mssql, we are looking for these files:
setup_schema_mssql.yaml
- creates tables and inserts valuessetup_mssql.yaml
- creates relationships, permissions, etc.
And we will run them in that order.
For postgres tests, you will want to run setup.yaml
and maybe values_setup.yaml
as well.
We will setup an api call to graphql-engine per setup file:
cat server/tests-py/queries/graphql_query/basic/schema_setup.yaml | yaml2json | curl -d @- localhost:8181/v1/query
cat server/tests-py/queries/graphql_query/basic/schema_setup_mssql.yaml | yaml2json | curl -d @- localhost:8181/v2/query
cat server/tests-py/queries/graphql_query/basic/setup_mssql.yaml | yaml2json | curl -d @- localhost:8181/v1/metadata
Run tests
We have two options:
-
Take the query from the test you like and run in in graphql.
-
Extract the query into a separate file:
/tmp/query.yaml
:query: | query { author { id name } }
And use an api call:
cat /tmp/query.yaml | yaml2json | curl -d @- localhost:8181/v1/graphql
To include session variables, use the
-H
curl option:cat /tmp/query.yaml | yaml2json | curl -H "X-Hasura-Role: user" -H "X-Hasura-User-Id: 1" -d @- localhost:8181/v1/graphql
Cleanup
Easiest way to clean-up is to terminate graphql-engine and the database.
But it is also possible to run the teardown files against graphql-engine. Like this:
cat server/tests-py/queries/graphql_query/basic/teardown_mssql.yaml | yaml2json | curl -d @- localhost:8181/v1/metadata
cat server/tests-py/queries/graphql_query/basic/schema_teardown_mssql.yaml | yaml2json | curl -d @- localhost:8181/v2/query
cat server/tests-py/queries/graphql_query/basic/schema_teardown.yaml | yaml2json | curl -d @- localhost:8181/v1/query
Run a remote MSSQL instance with dev.sh
Sometimes we might want to run a database such as MSSQL on a remote computer using scripts/dev.sh mssql
and connect
to it from graphql-engine
which runs on a different computer. Currently, mssql instance running using
scripts/dev.sh mssql
will only be exposed to the machine it is run on.
To change that and expose it to other machines as well, we need to edit scripts/containers/mssql.sh
and change
the MSSQL_HOST
variable to the external IP of the machine.
Add a unit test for SQL generation
We will look at the SQL generation of delete for MSSQL as an example. We want to test the conversion of AnnDel
to structured SQL.
We can unit test individual transformations, for example that the Hasura.Backends.MSSQL.FromIr.fromDelete
function converts an AnnDel
to the correct SQL DELETE
statement, like this:
- Add a new HSpec file in
server/src-test/Database/MSSQL/
named something likeDeleteSpec.hs
:- This test should expose a
spec
function with the tests - It can use the
shouldBe
orshouldSatisfy
combinators to compare the input to the expected output - We can use
runValidate
andrunFromIr
just as it is used in the codebase to extract the value
- This test should expose a
- We can use
ltrace
or similar to print the input tofromDelete
when run from graphql-engine instead of crafting it by hand - We can print the output of the function when running the test, or craft the expected output ourselves
- We need to add another line to
unitSpecs
inserver/src-test/main.hs
Note: it is possible that Eq
and Show
instances will need to be added for the input and output types
for this to work (so that hspec can compare the values and display the expected/got mismatches)
Test example
module Hasura.Backends.MSSQL.FromIRTest
( spec,
)
where
import Control.Monad.Validate (runValidate)
import Database.ODBC.SQLServer
import Debug.Trace qualified as D
import Hasura.Backends.MSSQL.FromIr
import Hasura.Backends.MSSQL.Types.Internal hiding (FieldName)
import Hasura.Backends.MSSQL.Types.Internal qualified as MSSQL
import Hasura.Prelude
import Hasura.RQL.IR
import Hasura.RQL.Types
import Language.GraphQL.Draft.Syntax
import Test.Hspec
spec :: Spec
spec =
describe "Translate Delete" $
it "AnnDel to Delete" $ do
-- Can also be @`shouldBe` Right result@ instead
runValidate (runFromIr (fromDelete input)) `shouldSatisfy` thing
where
thing =
\case
Left _ -> False
Right x -> D.traceShow x True
input :: AnnDel 'MSSQL
input =
AnnDel
{ dqp1Table = TableName {tableName = "author", tableSchema = "dbo"},
dqp1Where =
( BoolAnd [],
BoolAnd [...]
),
dqp1Output = MOutMultirowFields [...],
dqp1AllCols = [...]
}
result :: Delete
result =
Delete
{ deleteTable =
Aliased
{ aliasedThing = TableName {tableName = "author", tableSchema = "dbo"},
aliasedAlias = "t_author1"
},
deleteOutput = Output {...},
deleteTempTable = TempTable {...},
deleteWhere = Where [...]
}
See as a commit: 6fe03938d4
(please completely ignore the Show
related changes)
Benchmark a query on postgres
We can measure the performance of a postgres query using the pgbench tool.
pgbench
lets us run a query on postgres repeatedly and reports information such as the number of transactions completed in a given time.
We can also compare multiple queries by running each of them using pgbench and compare the results.
Process
To measure, we need to:
- Define the schema
- Generate and insert data
- Run the query/queries with
pgbench
- Compare the results (When comparing multiple queries)
Define the schema
This can be done by creating a sql file with the relevant tables for the benchmark. For example:
-- tables.ddl
drop table if exists author;
drop table if exists article;
CREATE TABLE author(
id SERIAL PRIMARY KEY,
name TEXT NOT NULL
);
CREATE TABLE article(
id SERIAL PRIMARY KEY,
title TEXT NOT NULL,
author_id INTEGER
);
Generate data
Note: When deciding on the data we want to generate, it is important to remember that the shape of the data, such as its size and distribution of values, can affect the benchmark results. So make sure you have this in mind when generating the data.
Data for the benchmark can be generated using your favorite programming language. For example, using Haskell:
-- data-gen.hs
import System.Environment
import Data.Maybe
main = do
args <- getArgs
let
numOfRows = maybe 500 read $ listToMaybe args
divEveryRows = maybe 80 read $ listToMaybe $ drop 1 args
putStrLn $ "Number of rows: " <> show numOfRows
putStrLn $ "Number of unique authors used: " <> show divEveryRows
let
sql i = "insert into author(name) values ('Title " <> show i <> "');"
writeFile "insert_author.sql" $ unlines $ map sql [1..numOfRows]
let
sql i = "insert into article(title, author_id) values ('Title " <> show i <> "', " <> show (i `mod` divEveryRows) <> ");"
writeFile "insert_article.sql" $ unlines $ map sql [1..numOfRows]
This snippet above generates sql insert statements for our tables which can be later inserted into postgres.
Pgbench
We can measure our query with pgbench with the following (or similar) invocation, which limits the benchmark time (-T
) to 20 seconds,
and uses a single client (-c
).
pgbench -c 1 -T 20 -n -U <username> -d <database> -p 5432 -h 127.0.0.1 -f <queryfile.sql> 2> /dev/null
One script to rule them all
All of the above steps can be glued together by a simple bash script:
#!/bin/bash
echo "* Generating data..."
runghc data-gen.hs 1000 200
echo "* Creating schema and inserting data..."
PGPASSWORD=postgres psql -h 127.0.0.1 -p 25432 postgres -U postgres -f tables.ddl > /dev/null
PGPASSWORD=postgres psql -h 127.0.0.1 -p 25432 postgres -U postgres -f insert_author.sql > /dev/null
PGPASSWORD=postgres psql -h 127.0.0.1 -p 25432 postgres -U postgres -f insert_article.sql > /dev/null
echo "* Benchmarking..."
echo ""
echo "-------------------------"
echo "** Query 1: <description>"
echo "-------------------------"
PGPASSWORD=postgres pgbench -c 1 -T 20 -n -U postgres -d postgres -p 25432 -h 127.0.0.1 -f <query_1>.sql 2> /dev/null
echo "-------------------------"
echo "** Query 2: <description>"
echo "-------------------------"
PGPASSWORD=postgres pgbench -c 1 -T 20 -n -U postgres -d postgres -p 25432 -h 127.0.0.1 -f <query_2>.sql 2> /dev/null
Which can be run by starting a postgres database with scripts/dev.sh postgres
and running bash script.sh
.
Compare the results
One simple metric we can use to compare the results of two queries is to look at the transactions rate. The benchmark which managed to complete more transactions in a specific time frame is often faster.
Note: Benchmark results can vary for many reasons, such as the state of the machine and the processes running in parallel. It is important to take that into account when measuring, and considering benchmarking multiple times.
---------------------------
** Query 1: Without LIMIT 1
---------------------------
pgbench (14.1, server 12.6)
transaction type: no_limit.sql
scaling factor: 1
query mode: simple
number of clients: 1
number of threads: 1
duration: 20 s
number of transactions actually processed: 6624
latency average = 3.019 ms
initial connection time = 2.930 ms
tps = 331.190445 (without initial connection time)
------------------------
** Query 2: With LIMIT 1
------------------------
pgbench (14.1, server 12.6)
transaction type: with_limit.sql
scaling factor: 1
query mode: simple
number of clients: 1
number of threads: 1
duration: 20 s
number of transactions actually processed: 5822
latency average = 3.435 ms
initial connection time = 3.523 ms
tps = 291.082637 (without initial connection time)
From looking at the transactions rate, we can see that 6624
manage to complete for the first query, but only 5822
transactions coleted for the second query.
This makes the first query faster by 6624 / 5822 * 100 - 100 = roughly 13%
. For the usecase and data we measured.
Automatically run unit tests on change
Use ghcid
And run this:
ghcid -a -c "cabal repl graphql-engine:graphql-engine-tests -f -O0" --test Main.main --setup ":set args --match TheNameOfTestsIWantToRun" --width 100 --height 30