mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-15 09:22:43 +03:00
35c58f0000
<!-- Thank you for submitting this PR! :) --> ## Description When trying to reproduce a remote relationships bug, I managed to find this bug where remote relationships to commands ignore the argument mappings. A command argument can be called one thing in the NDC itself (ie, `id`), but we might want to expose it as `actor_id` in the engine as that's nicer for the user. As we referred to everything with `String`, we did not convert back to the NDC argument name when sending information from a remote relationship, this PR fixes that. We also add a `ConnectorArgumentName` newtype which replaces a bunch of uses of `String`, and would have guided us towards not creating this bug in the first place. <!-- Questions to consider answering: 1. What user-facing changes are being made? 2. What are issues related to this PR? (Consider adding `(close #<issue-no>)` to the PR title) 3. What is the conceptual design behind this PR? 4. How can this PR be tested/verified? 5. Does the PR have limitations? 6. Does the PR introduce breaking changes? --> ## Changelog - Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact. See [changelog guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide). - If no changelog is required ignore/remove this section and add a `no-changelog-required` label to the PR. ### Product _(Select all products this will be available in)_ - [X] community-edition - [X] cloud <!-- product : end : DO NOT REMOVE --> ### Type <!-- See changelog structure: https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog --> _(Select only one. In case of multiple, choose the most appropriate)_ - [ ] highlight - [ ] enhancement - [X] bugfix - [ ] behaviour-change - [ ] performance-enhancement - [ ] security-fix <!-- type : end : DO NOT REMOVE --> ### Changelog entry <!-- - Add a user understandable changelog entry - Include all details needed to understand the change. Try including links to docs or issues if relevant - For Highlights start with a H4 heading (#### <entry title>) - Get the changelog entry reviewed by your team --> Fix to correctly use argument mappings when resolving remote relationships to commands. <!-- changelog-entry : end : DO NOT REMOVE --> <!-- changelog : end : DO NOT REMOVE --> V3_GIT_ORIGIN_REV_ID: 2219e50d6cb28456e60c6794dc163d9b90573f8e |
||
|---|---|---|
| .. | ||
| benches | ||
| bin/engine | ||
| src | ||
| tests | ||
| build.rs | ||
| Cargo.toml | ||