mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-17 12:31:52 +03:00
40db3d7eab
### Description This PR attempts to fix several issues with source customization as it relates to remote relationships. There were several issues regarding casing: at the relationship border, we didn't properly set the target source's case, we didn't have access to the list of supported features to decide whether the feature was allowed or not, and we didn't have access to the global default. However, all of that information is available when we build the schema cache, as we do resolve the case of some elements such as function names: we can therefore resolve source information at the same time, and simplify both the root of the schema and the remote relationship border. To do this, this PR introduces a new type, `ResolvedSourceCustomization`, to be used in the Schema Cache, as opposed to the metadata's `SourceCustomization`, following a pattern established by a lot of other types. ### Remaining work and open questions One major point of confusion: it seems to me that we didn't set the case at all across remote relationships, which would suggest we would use the case of the LHS source across the subset of the RHS one that is accessible through the remote relationship, which would in turn "corrupt" the parser cache and might result in the wrong case being used for that source later on. Is that assesment correct, and was I right to fix it? Another one is that we seem not to be using the local case of the RHS to name the field in an object relationship; unless I'm mistaken we only use it for array relationships? Is that intentional? This PR is also missing tests that would show-case the difference, and a changelog entry. To my knowledge, all the tests of this feature are in the python test suite; this could be the opportunity to move them to the hspec suite, but this might be a considerable amount of work? PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5619 GitOrigin-RevId: 51a81b713a74575e82d9f96b51633f158ce3a47b |
||
|---|---|---|
| .. | ||
| Metadata | ||
| Permission | ||
| Relationship | ||
| RemoteRelationship | ||
| RemoteSchema | ||
| Schema | ||
| Webhook | ||
| Action.hs | ||
| ApiLimit.hs | ||
| ComputedField.hs | ||
| CustomTypes.hs | ||
| DataConnector.hs | ||
| Endpoint.hs | ||
| EventTrigger.hs | ||
| GraphqlSchemaIntrospection.hs | ||
| Headers.hs | ||
| InheritedRoles.hs | ||
| Metadata.hs | ||
| Network.hs | ||
| Permission.hs | ||
| QueryCollection.hs | ||
| QueryTags.hs | ||
| Relationship.hs | ||
| RemoteRelationship.hs | ||
| RemoteSchema.hs | ||
| ScheduledTrigger.hs | ||
| Schema.hs | ||
| SourceKinds.hs | ||