graphql-engine/server/src-lib/Hasura/GraphQL/Execute/Inline.hs
Samir Talwar 342391f39d Upgrade Ormolu to v0.5.
This upgrades the version of Ormolu required by the HGE repository to v0.5.0.1, and reformats all code accordingly.

Ormolu v0.5 reformats code that uses infix operators. This is mostly useful, adding newlines and indentation to make it clear which operators are applied first, but in some cases, it's unpleasant. To make this easier on the eyes, I had to do the following:

* Add a few fixity declarations (search for `infix`)
* Add parentheses to make precedence clear, allowing Ormolu to keep everything on one line
* Rename `relevantEq` to `(==~)` in #6651 and set it to `infix 4`
* Add a few _.ormolu_ files (thanks to @hallettj for helping me get started), mostly for Autodocodec operators that don't have explicit fixity declarations

In general, I think these changes are quite reasonable. They mostly affect indentation.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6675
GitOrigin-RevId: cd47d87f1d089fb0bc9dcbbe7798dbceedcd7d83
2022-11-02 20:55:13 +00:00

228 lines
8.3 KiB
Haskell
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

{-# LANGUAGE TemplateHaskell #-}
-- | This module implements /fragment inlining/, which converts all fragment
-- spreads in a GraphQL query to inline fragments. For example, given a query like
--
-- > query {
-- > users {
-- > id
-- > ...userFields
-- > }
-- > }
-- >
-- > fragment userFields on User {
-- > name
-- > favoriteColor
-- > }
--
-- the fragment inliner will convert it to this:
--
-- > query {
-- > users {
-- > id
-- > ... on User {
-- > name
-- > favoriteColor
-- > }
-- > }
-- > }
--
-- This is a straightforward and mechanical transformation, but it simplifies
-- further processing, since we catch unbound fragments and recursive fragment
-- definitions early in the pipeline, so parsing does not have to worry about it.
-- In that sense, fragment inlining is similar to the variable resolution pass
-- performed by "Hasura.GraphQL.Execute.Resolve", but for fragment definitions
-- rather than variables.
module Hasura.GraphQL.Execute.Inline
( InlineMT,
InlineM,
inlineSelectionSet,
inlineField,
runInlineMT,
runInlineM,
)
where
import Control.Lens
import Data.HashMap.Strict.Extended qualified as Map
import Data.HashSet qualified as Set
import Data.List qualified as L
import Data.Text qualified as T
import Data.Text.Extended
import Hasura.Base.Error
import Hasura.Prelude
import Hasura.Server.Utils
import Language.GraphQL.Draft.Syntax
-- | Internal bookkeeping used during inlining.
data InlineEnv = InlineEnv
{ -- | All known fragment definitions.
_ieFragmentDefinitions :: HashMap Name FragmentDefinition,
-- | Fragments were currently inlining higher up in the call stack, used to
-- detect fragment cycles.
_ieFragmentStack :: [Name]
}
-- | Internal bookkeeping used during inlining.
newtype InlineState = InlineState
{ -- | A cache of fragment definitions weve already inlined, so we dont need
-- to inline them again.
_isFragmentCache :: HashMap Name (InlineFragment NoFragments Name)
}
$(makeLensesFor [("_ieFragmentStack", "ieFragmentStack")] ''InlineEnv)
$(makeLenses ''InlineState)
type MonadInline m =
( MonadError QErr m,
MonadReader InlineEnv m,
MonadState InlineState m
)
type InlineMT m a = MonadError QErr m => (StateT InlineState (ReaderT InlineEnv m)) a
type InlineM a = InlineMT (Except QErr) a
{-# INLINE runInlineMT #-}
runInlineMT ::
forall m a.
(MonadError QErr m) =>
HashMap Name FragmentDefinition ->
InlineMT m a ->
m a
runInlineMT uniqueFragmentDefinitions =
flip
runReaderT
InlineEnv
{ _ieFragmentDefinitions = uniqueFragmentDefinitions,
_ieFragmentStack = []
}
. flip evalStateT InlineState {_isFragmentCache = mempty}
{-# INLINE runInlineM #-}
runInlineM ::
forall a.
HashMap Name FragmentDefinition ->
InlineM a ->
Either QErr a
runInlineM fragments = runExcept . runInlineMT fragments
-- | Inlines all fragment spreads in a 'SelectionSet'; see the module
-- documentation for "Hasura.GraphQL.Execute.Inline" for details.
inlineSelectionSet ::
(MonadError QErr m, Foldable t) =>
t FragmentDefinition ->
SelectionSet FragmentSpread Name ->
m (SelectionSet NoFragments Name)
inlineSelectionSet fragmentDefinitions selectionSet = do
let fragmentDefinitionMap = Map.groupOnNE _fdName fragmentDefinitions
uniqueFragmentDefinitions <- flip
Map.traverseWithKey
fragmentDefinitionMap
\fragmentName fragmentDefinitions' ->
case fragmentDefinitions' of
a :| [] -> return a
_ -> throw400 ParseFailed $ "multiple definitions for fragment " <>> fragmentName
let usedFragmentNames = Set.fromList $ fragmentsInSelectionSet selectionSet
definedFragmentNames = Set.fromList $ Map.keys uniqueFragmentDefinitions
-- At the time of writing, this check is disabled using
-- a local binding because, the master branch doesn't implement this
-- check.
-- TODO: Do this check using a feature flag
isFragmentValidationEnabled = False
when (isFragmentValidationEnabled && (usedFragmentNames /= definedFragmentNames)) $
throw400 ValidationFailed $
"following fragment(s) have been defined, but have not been used in the query - "
<> T.concat
( L.intersperse ", " $
map unName $
Set.toList $
Set.difference definedFragmentNames usedFragmentNames
)
-- The below code is a manual inlining of 'runInlineMT', as appearently the
-- inlining optimization does not trigger, even with the INLINE pragma.
traverse inlineSelection selectionSet
& flip evalStateT InlineState {_isFragmentCache = mempty}
& flip
runReaderT
InlineEnv
{ _ieFragmentDefinitions = uniqueFragmentDefinitions,
_ieFragmentStack = []
}
where
fragmentsInSelectionSet :: SelectionSet FragmentSpread Name -> [Name]
fragmentsInSelectionSet selectionSet' = concatMap getFragFromSelection selectionSet'
getFragFromSelection :: Selection FragmentSpread Name -> [Name]
getFragFromSelection = \case
SelectionField fld -> fragmentsInSelectionSet $ _fSelectionSet fld
SelectionFragmentSpread fragmentSpread -> [_fsName fragmentSpread]
SelectionInlineFragment inlineFragment -> fragmentsInSelectionSet $ _ifSelectionSet inlineFragment
inlineSelection ::
MonadInline m =>
Selection FragmentSpread Name ->
m (Selection NoFragments Name)
inlineSelection (SelectionField field) =
withPathK "selectionSet" $ SelectionField <$> inlineField field
inlineSelection (SelectionFragmentSpread spread) =
withPathK "selectionSet" $
SelectionInlineFragment <$> inlineFragmentSpread spread
inlineSelection (SelectionInlineFragment fragment@InlineFragment {_ifSelectionSet}) = do
selectionSet <- traverse inlineSelection _ifSelectionSet
pure $! SelectionInlineFragment fragment {_ifSelectionSet = selectionSet}
{-# INLINE inlineField #-}
inlineField :: MonadInline m => Field FragmentSpread Name -> m (Field NoFragments Name)
inlineField field@(Field {_fSelectionSet}) = withPathK (unName $ _fName field) $ do
selectionSet <- traverse inlineSelection _fSelectionSet
pure $! field {_fSelectionSet = selectionSet}
inlineFragmentSpread ::
MonadInline m =>
FragmentSpread Name ->
m (InlineFragment NoFragments Name)
inlineFragmentSpread FragmentSpread {_fsName, _fsDirectives} = do
InlineEnv {_ieFragmentDefinitions, _ieFragmentStack} <- ask
InlineState {_isFragmentCache} <- get
if
-- If weve already inlined this fragment, no need to process it again.
| Just fragment <- Map.lookup _fsName _isFragmentCache ->
pure $! addSpreadDirectives fragment
-- Fragment cycles are always illegal; see
-- http://spec.graphql.org/June2018/#sec-Fragment-spreads-must-not-form-cycles
| (fragmentCycle, _ : _) <- break (== _fsName) _ieFragmentStack ->
throw400 ValidationFailed $
"the fragment definition(s) "
<> englishList "and" (toTxt <$> (_fsName :| reverse fragmentCycle))
<> " form a cycle"
-- We didnt hit the fragment cache, so look up the definition and convert
-- it to an inline fragment.
| Just FragmentDefinition {_fdTypeCondition, _fdSelectionSet} <-
Map.lookup _fsName _ieFragmentDefinitions -> withPathK (unName _fsName) $ do
selectionSet <-
locally ieFragmentStack (_fsName :) $
traverse inlineSelection _fdSelectionSet
let fragment =
InlineFragment
{ _ifTypeCondition = Just _fdTypeCondition,
-- As far as I can tell, the GraphQL spec says that directives
-- on the fragment definition do NOT apply to the fields in its
-- selection set.
_ifDirectives = [],
_ifSelectionSet = selectionSet
}
modify' $ over isFragmentCache $ Map.insert _fsName fragment
pure $! addSpreadDirectives fragment
-- If we get here, the fragment name is unbound; raise an error.
-- http://spec.graphql.org/June2018/#sec-Fragment-spread-target-defined
| otherwise ->
throw400 ValidationFailed $
"reference to undefined fragment " <>> _fsName
where
addSpreadDirectives fragment =
fragment {_ifDirectives = _ifDirectives fragment ++ _fsDirectives}