mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-18 21:12:09 +03:00
6e1761f8f9
### Description This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`). For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys). Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases. Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it). While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs. ### Keeping track of concrete type names The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens: ```graphql query { author(id: 53478) { ... on Writer { name articles { title } } ... on Artist { name articles { title } } } } ``` If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query. To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810 GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
203 lines
9.7 KiB
Haskell
203 lines
9.7 KiB
Haskell
module Hasura.GraphQL.Schema.RemoteRelationship
|
|
( remoteRelationshipField,
|
|
)
|
|
where
|
|
|
|
import Control.Lens
|
|
import Data.Has
|
|
import Data.HashMap.Strict.Extended qualified as Map
|
|
import Data.List.NonEmpty qualified as NE
|
|
import Data.Text.Extended
|
|
import Hasura.Base.Error
|
|
import Hasura.GraphQL.Execute.Types qualified as ET
|
|
import Hasura.GraphQL.Parser
|
|
import Hasura.GraphQL.Parser qualified as P
|
|
import Hasura.GraphQL.Parser.Internal.Parser qualified as P
|
|
import Hasura.GraphQL.Schema.Backend
|
|
import Hasura.GraphQL.Schema.Common
|
|
import Hasura.GraphQL.Schema.Instances ()
|
|
import Hasura.GraphQL.Schema.Remote
|
|
import Hasura.GraphQL.Schema.Select
|
|
import Hasura.GraphQL.Schema.Table
|
|
import Hasura.Prelude
|
|
import Hasura.RQL.DDL.RemoteRelationship.Validate
|
|
import Hasura.RQL.IR qualified as IR
|
|
import Hasura.RQL.Types.Common (FieldName, RelType (..), relNameToTxt)
|
|
import Hasura.RQL.Types.Relationships.Remote
|
|
import Hasura.RQL.Types.Relationships.ToSchema
|
|
import Hasura.RQL.Types.Relationships.ToSchema qualified as Remote
|
|
import Hasura.RQL.Types.RemoteSchema
|
|
import Hasura.RQL.Types.ResultCustomization
|
|
import Hasura.RQL.Types.SchemaCache
|
|
import Hasura.RQL.Types.SourceCustomization (mkCustomizedTypename)
|
|
import Hasura.SQL.AnyBackend
|
|
import Hasura.Session
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
|
|
|
-- | Remote relationship field parsers
|
|
remoteRelationshipField ::
|
|
forall r m n lhsJoinField.
|
|
(MonadBuildSchemaBase r m n) =>
|
|
RemoteFieldInfo lhsJoinField ->
|
|
m (Maybe [FieldParser n (IR.RemoteRelationshipField UnpreparedValue)])
|
|
remoteRelationshipField RemoteFieldInfo {..} = runMaybeT do
|
|
queryType <- asks $ qcQueryType . getter
|
|
-- https://github.com/hasura/graphql-engine/issues/5144
|
|
-- The above issue is easily fixable by removing the following guard
|
|
guard $ queryType == ET.QueryHasura
|
|
case _rfiRHS of
|
|
RFISource anyRemoteSourceFieldInfo ->
|
|
dispatchAnyBackend @BackendSchema anyRemoteSourceFieldInfo \remoteSourceFieldInfo -> do
|
|
fields <- lift $ remoteRelationshipToSourceField remoteSourceFieldInfo
|
|
pure $ fmap (IR.RemoteSourceField . mkAnyBackend) <$> fields
|
|
RFISchema remoteSchema -> do
|
|
fields <- MaybeT $ remoteRelationshipToSchemaField _rfiLHS remoteSchema
|
|
pure $ pure $ IR.RemoteSchemaField <$> fields
|
|
|
|
-- | Parser(s) for remote relationship fields to a remote schema
|
|
remoteRelationshipToSchemaField ::
|
|
forall r m n lhsJoinField.
|
|
(MonadBuildSchemaBase r m n) =>
|
|
Map.HashMap FieldName lhsJoinField ->
|
|
RemoteSchemaFieldInfo ->
|
|
m (Maybe (FieldParser n (IR.RemoteSchemaSelect (IR.RemoteRelationshipField UnpreparedValue))))
|
|
remoteRelationshipToSchemaField lhsFields RemoteSchemaFieldInfo {..} = runMaybeT do
|
|
remoteRelationshipQueryCtx <- asks $ qcRemoteRelationshipContext . getter
|
|
RemoteRelationshipQueryContext roleIntrospectionResultOriginal _ remoteSchemaCustomizer <-
|
|
-- The remote relationship field should not be accessible
|
|
-- if the remote schema is not accessible to the said role
|
|
hoistMaybe $ Map.lookup _rrfiRemoteSchemaName remoteRelationshipQueryCtx
|
|
role <- askRoleName
|
|
let hasuraFieldNames = Map.keysSet lhsFields
|
|
relationshipDef = ToSchemaRelationshipDef _rrfiRemoteSchemaName hasuraFieldNames _rrfiRemoteFields
|
|
(newInpValDefns :: [G.TypeDefinition [G.Name] RemoteSchemaInputValueDefinition], remoteFieldParamMap) <-
|
|
if role == adminRoleName
|
|
then do
|
|
-- we don't validate the remote relationship when the role is admin
|
|
-- because it's already been validated, when the remote relationship
|
|
-- was created
|
|
pure (_rrfiInputValueDefinitions, _rrfiParamMap)
|
|
else do
|
|
(_, roleRemoteField) <-
|
|
afold @(Either _) $
|
|
-- TODO: this really needs to go way, we shouldn't be doing
|
|
-- validation when building parsers
|
|
validateToSchemaRelationship relationshipDef _rrfiLHSIdentifier _rrfiName (_rrfiRemoteSchema, roleIntrospectionResultOriginal) lhsFields
|
|
pure (Remote._rrfiInputValueDefinitions roleRemoteField, Remote._rrfiParamMap roleRemoteField)
|
|
let roleIntrospection@(RemoteSchemaIntrospection typeDefns) = irDoc roleIntrospectionResultOriginal
|
|
-- add the new input value definitions created by the remote relationship
|
|
-- to the existing schema introspection of the role
|
|
remoteRelationshipIntrospection = RemoteSchemaIntrospection $ typeDefns <> Map.fromListOn getTypeName newInpValDefns
|
|
fieldName <- textToName $ relNameToTxt _rrfiName
|
|
|
|
-- This selection set parser, should be of the remote node's selection set parser, which comes
|
|
-- from the fieldCall
|
|
let fieldCalls = unRemoteFields _rrfiRemoteFields
|
|
parentTypeName = irQueryRoot roleIntrospectionResultOriginal
|
|
nestedFieldType <- lift $ lookupNestedFieldType parentTypeName roleIntrospection fieldCalls
|
|
let typeName = G.getBaseType nestedFieldType
|
|
fieldTypeDefinition <-
|
|
onNothing (lookupType roleIntrospection typeName)
|
|
-- the below case will never happen because we get the type name
|
|
-- from the schema document itself i.e. if a field exists for the
|
|
-- given role, then it's return type also must exist
|
|
$
|
|
throw500 $ "unexpected: " <> typeName <<> " not found "
|
|
-- These are the arguments that are given by the user while executing a query
|
|
let remoteFieldUserArguments = map snd $ Map.toList remoteFieldParamMap
|
|
remoteFld <-
|
|
withRemoteSchemaCustomization remoteSchemaCustomizer $
|
|
lift $
|
|
P.wrapFieldParser nestedFieldType
|
|
<$> remoteField remoteRelationshipIntrospection parentTypeName fieldName Nothing remoteFieldUserArguments fieldTypeDefinition
|
|
|
|
pure $
|
|
remoteFld
|
|
`P.bindField` \fld@IR.GraphQLField {IR._fArguments = args, IR._fSelectionSet = selSet, IR._fName = fname} -> do
|
|
let remoteArgs =
|
|
Map.toList args <&> \(argName, argVal) -> IR.RemoteFieldArgument argName $ P.GraphQLValue argVal
|
|
let resultCustomizer =
|
|
applyFieldCalls fieldCalls $
|
|
applyAliasMapping (singletonAliasMapping fname (fcName $ NE.last fieldCalls)) $
|
|
makeResultCustomizer remoteSchemaCustomizer fld
|
|
pure $
|
|
IR.RemoteSchemaSelect
|
|
{ IR._rselArgs = remoteArgs,
|
|
IR._rselResultCustomizer = resultCustomizer,
|
|
IR._rselSelection = selSet,
|
|
IR._rselFieldCall = fieldCalls,
|
|
IR._rselRemoteSchema = _rrfiRemoteSchema
|
|
}
|
|
where
|
|
-- Apply parent field calls so that the result customizer modifies the nested field
|
|
applyFieldCalls :: NonEmpty FieldCall -> ResultCustomizer -> ResultCustomizer
|
|
applyFieldCalls fieldCalls resultCustomizer =
|
|
foldr (modifyFieldByName . fcName) resultCustomizer $ NE.init fieldCalls
|
|
|
|
lookupNestedFieldType' ::
|
|
(MonadSchema n m, MonadError QErr m) =>
|
|
G.Name ->
|
|
RemoteSchemaIntrospection ->
|
|
FieldCall ->
|
|
m G.GType
|
|
lookupNestedFieldType' parentTypeName remoteSchemaIntrospection (FieldCall fcName _) =
|
|
case lookupObject remoteSchemaIntrospection parentTypeName of
|
|
Nothing -> throw400 RemoteSchemaError $ "object with name " <> parentTypeName <<> " not found"
|
|
Just G.ObjectTypeDefinition {..} ->
|
|
case find ((== fcName) . G._fldName) _otdFieldsDefinition of
|
|
Nothing -> throw400 RemoteSchemaError $ "field with name " <> fcName <<> " not found"
|
|
Just G.FieldDefinition {..} -> pure _fldType
|
|
|
|
lookupNestedFieldType ::
|
|
(MonadSchema n m, MonadError QErr m) =>
|
|
G.Name ->
|
|
RemoteSchemaIntrospection ->
|
|
NonEmpty FieldCall ->
|
|
m G.GType
|
|
lookupNestedFieldType parentTypeName remoteSchemaIntrospection (fieldCall :| rest) = do
|
|
fieldType <- lookupNestedFieldType' parentTypeName remoteSchemaIntrospection fieldCall
|
|
case NE.nonEmpty rest of
|
|
Nothing -> pure fieldType
|
|
Just rest' -> do
|
|
lookupNestedFieldType (G.getBaseType fieldType) remoteSchemaIntrospection rest'
|
|
|
|
-- | Parser(s) for remote relationship fields to a database table.
|
|
-- Note that when the target is a database table, an array relationship
|
|
-- declaration would have the '_aggregate' field in addition to the array
|
|
-- relationship field, hence [FieldParser ...] instead of 'FieldParser'
|
|
remoteRelationshipToSourceField ::
|
|
forall r m n tgt.
|
|
(MonadBuildSchemaBase r m n, BackendSchema tgt) =>
|
|
RemoteSourceFieldInfo tgt ->
|
|
m [FieldParser n (IR.RemoteSourceSelect (IR.RemoteRelationshipField UnpreparedValue) UnpreparedValue tgt)]
|
|
remoteRelationshipToSourceField RemoteSourceFieldInfo {..} =
|
|
withTypenameCustomization (mkCustomizedTypename $ Just _rsfiSourceCustomization) do
|
|
tableInfo <- askTableInfo @tgt _rsfiSource _rsfiTable
|
|
fieldName <- textToName $ relNameToTxt _rsfiName
|
|
maybePerms <- tableSelectPermissions @tgt tableInfo
|
|
case maybePerms of
|
|
Nothing -> pure []
|
|
Just tablePerms -> do
|
|
parsers <- case _rsfiType of
|
|
ObjRel -> do
|
|
selectionSetParserM <- tableSelectionSet _rsfiSource tableInfo
|
|
pure $ case selectionSetParserM of
|
|
Nothing -> []
|
|
Just selectionSetParser ->
|
|
pure $
|
|
subselection_ fieldName Nothing selectionSetParser <&> \fields ->
|
|
IR.SourceRelationshipObject $
|
|
IR.AnnObjectSelectG fields _rsfiTable $ IR._tpFilter $ tablePermissionsInfo tablePerms
|
|
ArrRel -> do
|
|
let aggFieldName = fieldName <> $$(G.litName "_aggregate")
|
|
selectionSetParser <- selectTable _rsfiSource tableInfo fieldName Nothing
|
|
aggSelectionSetParser <- selectTableAggregate _rsfiSource tableInfo aggFieldName Nothing
|
|
pure $
|
|
catMaybes
|
|
[ selectionSetParser <&> fmap IR.SourceRelationshipArray,
|
|
aggSelectionSetParser <&> fmap IR.SourceRelationshipArrayAggregate
|
|
]
|
|
pure $
|
|
parsers <&> fmap \select ->
|
|
IR.RemoteSourceSelect _rsfiSource _rsfiSourceConfig select _rsfiMapping
|