mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-15 09:22:43 +03:00
6ed9f36125
These tests are intended to catch issues in upgrading HGE. However: * the tests are very convoluted and hard to understand, * we can only run a small subset of Python tests that don't mutate any data or metadata, and * I have never seen them fail for a legitimate reason, but I've seen a lot of flakes. While we do believe it's important to test that upgrades don't break the stored introspection, these tests don't seem to be doing that any more. I humbly request that we delete them now and either (a) figure out how to test this properly, or (b) just wait for v3, which does away with reintrospecting on server startup entirely. [NDAT-259]: https://hasurahq.atlassian.net/browse/NDAT-259?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8844 GitOrigin-RevId: 528bc632fce377b7eff2026b832bd58586ac5a0b |
||
---|---|---|
.. | ||
pgbouncer | ||
postgres-12.0-alpine-postgis3 | ||
postgres-13.0-alpine-postgis3 | ||
.gitignore | ||
build-docker-image.sh | ||
ciignore.sh | ||
cli-migrations-builder.dockerfile | ||
config.yml | ||
install-cli-builder-deps.sh | ||
README.md | ||
server-test-names.txt | ||
test-console.sh | ||
test-deprecated-server-flags.sh | ||
test-server-flags.sh | ||
test-server.sh |
TODO(swann): write this out better
Any tests in test-server.sh
should also have their names added to
server-test-names.txt
, otherwise the CI pipelines will not run them.