mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-18 13:02:11 +03:00
cc6c86aeab
## Description Thanks to #1664, the Metadata API types no longer require a `ToJSON` instance. This PR follows up with a cleanup of the types of the arguments to the metadata API: - whenever possible, it moves those argument types to where they're used (RQL.DDL.*) - it removes all unrequired instances (mostly `ToJSON`) This PR does not attempt to do it for _all_ such argument types. For some of the metadata operations, the type used to describe the argument to the API and used to represent the value in the metadata are one and the same (like for `CreateEndpoint`). Sometimes, the two types are intertwined in complex ways (`RemoteRelationship` and `RemoteRelationshipDef`). In the spirit of only doing uncontroversial cleaning work, this PR only moves types that are not used outside of RQL.DDL. Furthermore, this is a small step towards separating the different types all jumbled together in RQL.Types. ## Notes This PR also improves several `FromJSON` instances to make use of `withObject`, and to use a human readable string instead of a type name in error messages whenever possible. For instance: - before: `expected Object for Object, but encountered X` after: `expected Object for add computed field, but encountered X` - before: `Expecting an object for update query` after: `expected Object for update query, but encountered X` This PR also renames `CreateFunctionPermission` to `FunctionPermissionArgument`, to remove the quite surprising `type DropFunctionPermission = CreateFunctionPermission`. This PR also deletes some dead code, mostly in RQL.DML. This PR also moves a PG-specific source resolving function from DDL.Schema.Source to the only place where it is used: App.hs. https://github.com/hasura/graphql-engine-mono/pull/1844 GitOrigin-RevId: a594521194bb7fe6a111b02a9e099896f9fed59c
63 lines
1.9 KiB
Haskell
63 lines
1.9 KiB
Haskell
module Hasura.RQL.DDL.Relationship.Rename
|
|
( RenameRel
|
|
, runRenameRel
|
|
) where
|
|
|
|
import Hasura.Prelude
|
|
|
|
import qualified Data.HashMap.Strict as Map
|
|
|
|
import Data.Aeson
|
|
import Data.Text.Extended
|
|
|
|
import Hasura.Base.Error
|
|
import Hasura.EncJSON
|
|
import Hasura.RQL.DDL.Schema (renameRelationshipInMetadata)
|
|
import Hasura.RQL.Types
|
|
|
|
|
|
data RenameRel b
|
|
= RenameRel
|
|
{ _rrSource :: !SourceName
|
|
, _rrTable :: !(TableName b)
|
|
, _rrName :: !RelName
|
|
, _rrNewName :: !RelName
|
|
}
|
|
|
|
instance (Backend b) => FromJSON (RenameRel b) where
|
|
parseJSON = withObject "rename relationship" $ \o ->
|
|
RenameRel
|
|
<$> o .:? "source" .!= defaultSource
|
|
<*> o .: "table"
|
|
<*> o .: "name"
|
|
<*> o .: "new_name"
|
|
|
|
renameRelP2
|
|
:: forall b m
|
|
. (QErrM m, CacheRM m, BackendMetadata b)
|
|
=> SourceName -> TableName b -> RelName -> RelInfo b -> m MetadataModifier
|
|
renameRelP2 source qt newRN relInfo = withNewInconsistentObjsCheck $ do
|
|
tabInfo <- askTableCoreInfo @b source qt
|
|
-- check for conflicts in fieldInfoMap
|
|
case Map.lookup (fromRel newRN) $ _tciFieldInfoMap tabInfo of
|
|
Nothing -> return ()
|
|
Just _ ->
|
|
throw400 AlreadyExists $ "cannot rename relationship " <> oldRN
|
|
<<> " to " <> newRN <<> " in table " <> qt <<>
|
|
" as a column/relationship with the name already exists"
|
|
-- update metadata
|
|
execWriterT $ renameRelationshipInMetadata @b source qt oldRN (riType relInfo) newRN
|
|
where
|
|
oldRN = riName relInfo
|
|
|
|
runRenameRel
|
|
:: forall b m
|
|
. (MonadError QErr m, CacheRWM m, MetadataM m, BackendMetadata b)
|
|
=> RenameRel b -> m EncJSON
|
|
runRenameRel (RenameRel source qt rn newRN) = do
|
|
tabInfo <- askTableCoreInfo @b source qt
|
|
ri <- askRelType (_tciFieldInfoMap tabInfo) rn ""
|
|
withNewInconsistentObjsCheck $
|
|
renameRelP2 source qt newRN ri >>= buildSchemaCache
|
|
pure successMsg
|