graphql-engine/server/src-lib/Hasura/GraphQL/Schema/RemoteRelationship.hs
Antoine Leblanc 512a4dbb92 Use a different reader context for sources and remote schemas with new SchemaT monad.
### Description

This PR changes all the schema code to operate in a specific `SchemaT` monad, rather than in an arbitrary `m` monad. `SchemaT` is intended to be used opaquely with `runSourceSchema` and `runRemoteSchema`. The main goal of this is to allow a different reader context per part of the schema: this PR also minimizes the contexts. This means that we no longer require `SchemaOptions` when building remote schemas' schema, and this PR therefore removes a lot of dummy / placeholder values accordingly.

### Performance and stacking

This PR has been through several iterations. #5339 was the original version, that accomplished the same thing by stacking readers on top of the stack at every remote relationship boundary. This raised performance concerns, and @0x777 confirmed with an ad-hoc test that in some extreme cases we could see up to a 10% performance impact. This version, while more verbose, allows us to unstack / re-stack the readers, and avoid that problem. #5517 adds a new benchmark set to be able to automatically measure this on every PR.

### Remaining work

- [x] a comment (or perhaps even a Note?) should be added to `SchemaT`
- [x] we probably want for #5517 to be merged first so that we can confirm the lack of performance penalty

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5458
GitOrigin-RevId: e06b83d90da475f745b838f1fd8f8b4d9d3f4b10
2022-09-06 16:49:23 +00:00

230 lines
11 KiB
Haskell

module Hasura.GraphQL.Schema.RemoteRelationship
( remoteRelationshipField,
)
where
import Control.Lens
import Data.Has
import Data.HashMap.Strict.Extended qualified as Map
import Data.List.NonEmpty qualified as NE
import Data.Text.Casing qualified as C
import Data.Text.Extended
import Hasura.Base.Error
import Hasura.GraphQL.Schema.Backend
import Hasura.GraphQL.Schema.Common
import Hasura.GraphQL.Schema.Instances ()
import Hasura.GraphQL.Schema.NamingCase
import Hasura.GraphQL.Schema.Options
import Hasura.GraphQL.Schema.Parser (FieldParser, MonadMemoize)
import Hasura.GraphQL.Schema.Parser qualified as P
import Hasura.GraphQL.Schema.Remote
import Hasura.GraphQL.Schema.Select
import Hasura.GraphQL.Schema.Table
import Hasura.GraphQL.Schema.Typename (withTypenameCustomization)
import Hasura.Name qualified as Name
import Hasura.Prelude
import Hasura.RQL.DDL.RemoteRelationship.Validate
import Hasura.RQL.IR qualified as IR
import Hasura.RQL.Types.Common (FieldName, RelType (..), relNameToTxt)
import Hasura.RQL.Types.Relationships.Remote
import Hasura.RQL.Types.Relationships.ToSchema
import Hasura.RQL.Types.Relationships.ToSchema qualified as Remote
import Hasura.RQL.Types.RemoteSchema
import Hasura.RQL.Types.ResultCustomization
import Hasura.RQL.Types.SchemaCache hiding (askTableInfo)
import Hasura.RQL.Types.Source
import Hasura.RQL.Types.SourceCustomization
import Hasura.SQL.AnyBackend
import Hasura.Session
import Language.GraphQL.Draft.Syntax qualified as G
-- | Remote relationship field parsers
remoteRelationshipField ::
SchemaContext ->
SchemaOptions ->
SourceCache ->
RemoteSchemaMap ->
RemoteSchemaPermissions ->
RemoteRelationshipParserBuilder
remoteRelationshipField schemaContext schemaOptions sourceCache remoteSchemaCache remoteSchemaPermissions = RemoteRelationshipParserBuilder
\RemoteFieldInfo {..} -> do
queryType <- retrieve scSchemaKind
-- Remote relationships aren't currently supported in Relay, due to type conflicts, and
-- introspection issues such as https://github.com/hasura/graphql-engine/issues/5144.
if not $ isHasuraSchema queryType
then pure Nothing
else case _rfiRHS of
RFISource anyRemoteSourceFieldInfo ->
-- see Note [SchemaT and stacking]
lift $
runSourceSchema schemaContext schemaOptions $
dispatchAnyBackendWithTwoConstraints @BackendSchema @BackendTableSelectSchema
anyRemoteSourceFieldInfo
\remoteSourceFieldInfo -> do
fields <- remoteRelationshipToSourceField sourceCache remoteSourceFieldInfo
pure $ Just $ fmap (IR.RemoteSourceField . mkAnyBackend) <$> fields
RFISchema remoteSchema ->
-- see Note [SchemaT and stacking]
lift $ runRemoteSchema schemaContext do
fields <- remoteRelationshipToSchemaField remoteSchemaCache remoteSchemaPermissions _rfiLHS remoteSchema
pure $ fmap (pure . fmap IR.RemoteSchemaField) fields
-- | Parser(s) for remote relationship fields to a remote schema
remoteRelationshipToSchemaField ::
forall r m n lhsJoinField.
(MonadBuildRemoteSchema r m n) =>
RemoteSchemaMap ->
RemoteSchemaPermissions ->
Map.HashMap FieldName lhsJoinField ->
RemoteSchemaFieldInfo ->
SchemaT r m (Maybe (FieldParser n (IR.RemoteSchemaSelect (IR.RemoteRelationshipField IR.UnpreparedValue))))
remoteRelationshipToSchemaField remoteSchemaCache remoteSchemaPermissions lhsFields RemoteSchemaFieldInfo {..} = runMaybeT do
roleName <- retrieve scRole
remoteSchemaContext <-
Map.lookup _rrfiRemoteSchemaName remoteSchemaCache
`onNothing` throw500 ("invalid remote schema name: " <>> _rrfiRemoteSchemaName)
introspection <- hoistMaybe $ getIntrospectionResult remoteSchemaPermissions roleName remoteSchemaContext
let remoteSchemaRelationships = _rscRemoteRelationships remoteSchemaContext
roleIntrospection = irDoc introspection
remoteSchemaRoot = irQueryRoot introspection
remoteSchemaCustomizer = rsCustomizer $ _rscInfo remoteSchemaContext
RemoteSchemaIntrospection typeDefns = roleIntrospection
let hasuraFieldNames = Map.keysSet lhsFields
relationshipDef = ToSchemaRelationshipDef _rrfiRemoteSchemaName hasuraFieldNames _rrfiRemoteFields
(newInpValDefns :: [G.TypeDefinition [G.Name] RemoteSchemaInputValueDefinition], remoteFieldParamMap) <-
if roleName == adminRoleName
then do
-- we don't validate the remote relationship when the role is admin
-- because it's already been validated, when the remote relationship
-- was created
pure (_rrfiInputValueDefinitions, _rrfiParamMap)
else do
(_, roleRemoteField) <-
afold @(Either _) $
-- TODO: this really needs to go way, we shouldn't be doing
-- validation when building parsers
validateToSchemaRelationship relationshipDef _rrfiLHSIdentifier _rrfiName (_rrfiRemoteSchema, introspection) lhsFields
pure (Remote._rrfiInputValueDefinitions roleRemoteField, Remote._rrfiParamMap roleRemoteField)
let -- add the new input value definitions created by the remote relationship
-- to the existing schema introspection of the role
remoteRelationshipIntrospection = RemoteSchemaIntrospection $ typeDefns <> Map.fromListOn getTypeName newInpValDefns
fieldName <- textToName $ relNameToTxt _rrfiName
-- This selection set parser, should be of the remote node's selection set parser, which comes
-- from the fieldCall
let fieldCalls = unRemoteFields _rrfiRemoteFields
nestedFieldType <- lift $ lookupNestedFieldType remoteSchemaRoot roleIntrospection fieldCalls
let typeName = G.getBaseType nestedFieldType
fieldTypeDefinition <-
onNothing (lookupType roleIntrospection typeName)
-- the below case will never happen because we get the type name
-- from the schema document itself i.e. if a field exists for the
-- given role, then it's return type also must exist
$
throw500 $ "unexpected: " <> typeName <<> " not found "
-- These are the arguments that are given by the user while executing a query
let remoteFieldUserArguments = map snd $ Map.toList remoteFieldParamMap
remoteFld <-
withRemoteSchemaCustomization remoteSchemaCustomizer $
lift $
P.wrapFieldParser nestedFieldType
<$> remoteField remoteRelationshipIntrospection remoteSchemaRelationships remoteSchemaRoot fieldName Nothing remoteFieldUserArguments fieldTypeDefinition
pure $
remoteFld
`P.bindField` \fld@IR.GraphQLField {IR._fArguments = args, IR._fSelectionSet = selSet, IR._fName = fname} -> do
let remoteArgs =
Map.toList args <&> \(argName, argVal) -> IR.RemoteFieldArgument argName $ P.GraphQLValue argVal
let resultCustomizer =
applyFieldCalls fieldCalls $
applyAliasMapping (singletonAliasMapping fname (fcName $ NE.last fieldCalls)) $
makeResultCustomizer remoteSchemaCustomizer fld
pure $
IR.RemoteSchemaSelect
{ IR._rselArgs = remoteArgs,
IR._rselResultCustomizer = resultCustomizer,
IR._rselSelection = selSet,
IR._rselFieldCall = fieldCalls,
IR._rselRemoteSchema = _rrfiRemoteSchema
}
where
-- Apply parent field calls so that the result customizer modifies the nested field
applyFieldCalls :: NonEmpty FieldCall -> ResultCustomizer -> ResultCustomizer
applyFieldCalls fieldCalls resultCustomizer =
foldr (modifyFieldByName . fcName) resultCustomizer $ NE.init fieldCalls
lookupNestedFieldType' ::
(MonadMemoize m, MonadError QErr m) =>
G.Name ->
RemoteSchemaIntrospection ->
FieldCall ->
SchemaT r m G.GType
lookupNestedFieldType' parentTypeName remoteSchemaIntrospection (FieldCall fcName _) =
case lookupObject remoteSchemaIntrospection parentTypeName of
Nothing -> throw400 RemoteSchemaError $ "object with name " <> parentTypeName <<> " not found"
Just G.ObjectTypeDefinition {..} ->
case find ((== fcName) . G._fldName) _otdFieldsDefinition of
Nothing -> throw400 RemoteSchemaError $ "field with name " <> fcName <<> " not found"
Just G.FieldDefinition {..} -> pure _fldType
lookupNestedFieldType ::
(MonadMemoize m, MonadError QErr m) =>
G.Name ->
RemoteSchemaIntrospection ->
NonEmpty FieldCall ->
SchemaT r m G.GType
lookupNestedFieldType parentTypeName remoteSchemaIntrospection (fieldCall :| rest) = do
fieldType <- lookupNestedFieldType' parentTypeName remoteSchemaIntrospection fieldCall
case NE.nonEmpty rest of
Nothing -> pure fieldType
Just rest' -> do
lookupNestedFieldType (G.getBaseType fieldType) remoteSchemaIntrospection rest'
-- | Parser(s) for remote relationship fields to a database table.
-- Note that when the target is a database table, an array relationship
-- declaration would have the '_aggregate' field in addition to the array
-- relationship field, hence [FieldParser ...] instead of 'FieldParser'
remoteRelationshipToSourceField ::
forall r m n tgt.
( MonadBuildSourceSchema r m n,
BackendSchema tgt,
BackendTableSelectSchema tgt
) =>
SourceCache ->
RemoteSourceFieldInfo tgt ->
SchemaT r m [FieldParser n (IR.RemoteSourceSelect (IR.RemoteRelationshipField IR.UnpreparedValue) IR.UnpreparedValue tgt)]
remoteRelationshipToSourceField sourceCache RemoteSourceFieldInfo {..} =
withTypenameCustomization (mkCustomizedTypename (Just _rsfiSourceCustomization) HasuraCase) do
tCase <- asks getter
roleName <- retrieve scRole
sourceInfo <-
onNothing (unsafeSourceInfo @tgt =<< Map.lookup _rsfiSource sourceCache) $
throw500 $ "source not found " <> dquote _rsfiSource
tableInfo <- askTableInfo sourceInfo _rsfiTable
fieldName <- textToName $ relNameToTxt _rsfiName
case tableSelectPermissions @tgt roleName tableInfo of
Nothing -> pure []
Just tablePerms -> do
parsers <- case _rsfiType of
ObjRel -> do
selectionSetParserM <- tableSelectionSet sourceInfo tableInfo
pure $ case selectionSetParserM of
Nothing -> []
Just selectionSetParser ->
pure $
P.subselection_ fieldName Nothing selectionSetParser <&> \fields ->
IR.SourceRelationshipObject $
IR.AnnObjectSelectG fields _rsfiTable $ IR._tpFilter $ tablePermissionsInfo tablePerms
ArrRel -> do
let aggFieldName = applyFieldNameCaseIdentifier tCase $ C.fromAutogeneratedTuple (fieldName, [G.convertNameToSuffix Name._aggregate])
selectionSetParser <- selectTable sourceInfo tableInfo fieldName Nothing
aggSelectionSetParser <- selectTableAggregate sourceInfo tableInfo aggFieldName Nothing
pure $
catMaybes
[ selectionSetParser <&> fmap IR.SourceRelationshipArray,
aggSelectionSetParser <&> fmap IR.SourceRelationshipArrayAggregate
]
pure $
parsers <&> fmap \select ->
IR.RemoteSourceSelect _rsfiSource _rsfiSourceConfig select _rsfiMapping