mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-14 17:02:49 +03:00
63f1a93b54
`test-server.sh` is largely concerned with running the python test suite in `server/tests-py`. However, there are two odd test sets in there which don't belong, and make `test-server.sh` awkward to work with. One is `haskell-tests` (the "postgres" part of server unit tests), which we're not touching here. The other is `test-server-flags`, which runs some shell script based tests against the command line interface. This commit moves `test-server-flags` out of `test-server.sh`, and into a separate buildkite step. Reasons are largely: - it doesn't belong with the python tests - it doesn't need to run against various backends The larger scope within which I'd place this change is that we should aim to move the logic that's in test-server.sh to live closer to server/tests-py and be shared between the local dev setup and CI. There shouldn't be this much logic in CI scripts at all (choosing with what flags to run graphql-engine, choosing which arguments to pass to pytest, etc.). This change hardly gets us there, but the way that test-server.sh mixes concerns is one obstacle in ever getting away from the current state. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3300 GitOrigin-RevId: a15300a1dd276fa9f0cc29ddbf4ba7497919a6ec |
||
---|---|---|
.. | ||
pgbouncer | ||
postgres-12.0-alpine-postgis3 | ||
postgres-13.0-alpine-postgis3 | ||
server-upgrade-downgrade | ||
.gitignore | ||
build-docker-image.sh | ||
ciignore.sh | ||
cli-migrations-builder.dockerfile | ||
config.yml | ||
install-cli-builder-deps.sh | ||
README.md | ||
server-test-names.txt | ||
test-console.sh | ||
test-deprecated-server-flags.sh | ||
test-server-flags.sh | ||
test-server.sh |
TODO(swann): write this out better
Any tests in test-server.sh
should also have their names added to
server-test-names.txt
, otherwise the CI pipelines will not run them.