mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-15 09:22:43 +03:00
640457b09a
<!-- Thank you for submitting this PR! :) --> ## Description This PR fixes the bug where passing a null value to a nullable input field resulted in an error. It also uncomments the test for that. JIRA: https://hasurahq.atlassian.net/browse/V3ENGINE-97 According to [the graphql spec](https://spec.graphql.org/October2021/#sec-Null-Value): > > > ```graphql > { > field(arg: null) > field > } > ``` > The first has explicitly provided null to the argument “arg”, while the second has implicitly not provided a value to the argument “arg”. These two forms may be interpreted differently. We are also considering the two cases separately, i.e., if something is absent and nullable vs if something is set to null and is nullable. We are not manually adding the nullable fields and setting them to null if not specified explicitly. ## Changelog - Add a changelog entry (in the "Changelog entry" section below) if the changes in this PR have any user-facing impact. See [changelog guide](https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide). - If no changelog is required ignore/remove this section and add a `no-changelog-required` label to the PR. ### Product _(Select all products this will be available in)_ - [x] community-edition - [x] cloud <!-- product : end : DO NOT REMOVE --> ### Type <!-- See changelog structure: https://github.com/hasura/graphql-engine-mono/wiki/Changelog-Guide#structure-of-our-changelog --> _(Select only one. In case of multiple, choose the most appropriate)_ - [ ] highlight - [ ] enhancement - [x] bugfix - [ ] behaviour-change - [ ] performance-enhancement - [ ] security-fix <!-- type : end : DO NOT REMOVE --> ### Changelog entry <!-- - Add a user understandable changelog entry - Include all details needed to understand the change. Try including links to docs or issues if relevant - For Highlights start with a H4 heading (#### <entry title>) - Get the changelog entry reviewed by your team --> allow null for nullable field <!-- changelog-entry : end : DO NOT REMOVE --> <!-- changelog : end : DO NOT REMOVE --> --------- Co-authored-by: Anon Ray <ecthiender@users.noreply.github.com> V3_GIT_ORIGIN_REV_ID: 4aa181899379905aaca1a71f498b85515180ae1d |
||
|---|---|---|
| .. | ||
| custom-connector | ||
| engine | ||
| hasura-authn-core | ||
| hasura-authn-jwt | ||
| hasura-authn-webhook | ||
| lang-graphql | ||
| metadata-schema-generator | ||
| open-dds | ||
| opendds-derive | ||
| recursion_limit_macro | ||
| tracing-util | ||